dajac commented on code in PR #16309:
URL: https://github.com/apache/kafka/pull/16309#discussion_r1639492866
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1648,9 +1650,11 @@ private CoordinatorResult<Void, CoordinatorRecord>
classicGroupJoinToConsumerGro
Map<String, TopicMetadata> subscriptionMetadata =
group.subscriptionMetadata();
Map<String, Integer> subscribedTopicNamesMap =
group.subscribedTopicNames();
SubscriptionType subscriptionType = group.subscriptionType();
- final ConsumerPartitionAssignor.Subscription subscription =
deserializeSubscription(protocols);
+ final ConsumerProtocolSubscription subscription =
deserializeSubscription(protocols);
final List<ConsumerGroupHeartbeatRequestData.TopicPartitions>
ownedTopicPartitions =
toTopicPartitions(subscription.ownedPartitions(),
metadataImage.topics());
+ final Optional<String> rackId = subscription.rackId() == null ||
subscription.rackId().isEmpty() ?
Review Comment:
I wonder if we could define an helper method in `Utils` for this. What do
you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
