harryfallows commented on code in PR #16280:
URL: https://github.com/apache/kafka/pull/16280#discussion_r1639845590
##########
core/src/main/scala/kafka/server/ConfigHandler.scala:
##########
@@ -239,19 +239,24 @@ class BrokerConfigHandler(private val brokerConfig:
KafkaConfig,
def processConfigChanges(brokerId: String, properties: Properties): Unit = {
def getOrDefault(prop: String): Long = {
- if (properties.containsKey(prop))
- properties.getProperty(prop).toLong
- else
- QuotaConfigs.QUOTA_BYTES_PER_SECOND_DEFAULT
+ brokerConfig.dynamicConfig.currentDynamicBrokerConfigs get prop match {
Review Comment:
I've updated it, WDYT? Sorry if my code is dodgy, this is my first time
writing Scala.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
