dajac commented on PR #16309: URL: https://github.com/apache/kafka/pull/16309#issuecomment-2167587707
> It seems we can apply this simplification to following code, since the protocol data can offer all required info > > https://github.com/apache/kafka/blob/888a17760347223614da9243dc3751a18403cfa6/core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala#L501 > > https://github.com/apache/kafka/blob/8afa5e74ac02ad4d079f33f04042b056c170be95/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java#L1319 > > https://github.com/apache/kafka/blob/888a17760347223614da9243dc3751a18403cfa6/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java#L1193 I agree for the changes in the `group-coordinator` package. However, I would not touch the scala code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
