[jira] [Commented] (KAFKA-14543) Move LogOffsetMetadata to storage module

2022-12-22 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651182#comment-17651182 ] Satish Duggana commented on KAFKA-14543: [~mimaison] `LogOffsetMetadata` refact

[jira] [Commented] (KAFKA-14543) Move LogOffsetMetadata to storage module

2022-12-22 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651192#comment-17651192 ] Mickael Maison commented on KAFKA-14543: [~satish.duggana] I pretty much have th

[GitHub] [kafka] showuon commented on pull request #8066: KAFKA-4090: Validate SSL connection in client

2022-12-22 Thread GitBox
showuon commented on PR #8066: URL: https://github.com/apache/kafka/pull/8066#issuecomment-1362674869 Sorry that this issue didn't get much attention. I went through all the discussions in JIRA, it looks like we had 3 solutions so far: 1. [KIP-498](https://cwiki.apache.org/confluence/dis

[jira] [Commented] (KAFKA-14190) Corruption of Topic IDs with pre-2.8.0 ZK admin clients

2022-12-22 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651224#comment-17651224 ] Divij Vaidya commented on KAFKA-14190: -- Adding reports of users facing this bug whi

[jira] [Commented] (KAFKA-14190) Corruption of Topic IDs with pre-2.8.0 ZK admin clients

2022-12-22 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651225#comment-17651225 ] Divij Vaidya commented on KAFKA-14190: -- h2. Detection and recovery from this situat

[GitHub] [kafka] mimaison opened a new pull request, #13038: KAFKA-14543: Move LogOffsetMetadata to storage module

2022-12-22 Thread GitBox
mimaison opened a new pull request, #13038: URL: https://github.com/apache/kafka/pull/13038 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

[jira] [Commented] (KAFKA-14543) Move LogOffsetMetadata to storage module

2022-12-22 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651249#comment-17651249 ] Mickael Maison commented on KAFKA-14543: I opened https://github.com/apache/kafk

[GitHub] [kafka] chia7712 commented on pull request #12979: KAFKA-14544 The "is-future" should be removed from metrics tags after future log becomes current log

2022-12-22 Thread GitBox
chia7712 commented on PR #12979: URL: https://github.com/apache/kafka/pull/12979#issuecomment-1362800962 the new test is unstable. Will fix it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] satishd opened a new pull request, #13039: KAFKA 14480 Move the required dependant classes for ProducerStateManager

2022-12-22 Thread GitBox
satishd opened a new pull request, #13039: URL: https://github.com/apache/kafka/pull/13039 KAFKA 14480 Move the required dependant classes for ProducerStateManager These include LogOffsetMetadata, Snapshot, LastRecord, TxnMetadata, BatchMetadata, ProducerStateEntry, ProducerAppendInfo

[GitHub] [kafka] satishd opened a new pull request, #13040: KAFKA-14480 Move ProducerStateManager to storage module.

2022-12-22 Thread GitBox
satishd opened a new pull request, #13040: URL: https://github.com/apache/kafka/pull/13040 KAFKA-14480 Move ProducerStateManager to storage module. This is not yet complete as it is dependant on https://issues.apache.org/jira/browse/KAFKA-14478. ### Committer Checklist (exclud

[jira] [Commented] (KAFKA-6579) Consolidate window store and session store unit tests into a single class

2022-12-22 Thread Ahmed Sobeh (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651299#comment-17651299 ] Ahmed Sobeh commented on KAFKA-6579: AbstractWindowBytesStoreTest was actually create

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

2022-12-22 Thread GitBox
divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1055534331 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -1600,9 +1605,8 @@ public void testCloseInterrupt() throws Exception {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

2022-12-22 Thread GitBox
divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1055540081 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -2403,17 +2404,46 @@ private ClusterResourceListeners configureClusterResource

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

2022-12-22 Thread GitBox
divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1055542979 ## clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java: ## @@ -590,6 +595,14 @@ public boolean handleResponse(FetchResponse response, short ver

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

2022-12-22 Thread GitBox
divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1055548123 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -2403,17 +2404,40 @@ private ClusterResourceListeners configureClusterResource

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12802: KAFKA-14311: Connect Worker clean shutdown does not cleanly stop connectors/tasks

2022-12-22 Thread GitBox
vamossagar12 commented on code in PR #12802: URL: https://github.com/apache/kafka/pull/12802#discussion_r1055570645 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1658,11 +1659,20 @@ private void backoff(long ms) {

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12802: KAFKA-14311: Connect Worker clean shutdown does not cleanly stop connectors/tasks

2022-12-22 Thread GitBox
vamossagar12 commented on code in PR #12802: URL: https://github.com/apache/kafka/pull/12802#discussion_r1055576373 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java: ## @@ -3629,6 +3630,64 @@ public void testPollDurationOnS

[GitHub] [kafka] jolshan commented on pull request #13036: KAFKA-14534: Reduce flakiness in TransactionsExpirationTest

2022-12-22 Thread GitBox
jolshan commented on PR #13036: URL: https://github.com/apache/kafka/pull/13036#issuecomment-1363004305 Thanks for working on this test. I've been struggling with it (as the author 😅 ) for a while. I think what Luke says makes sense. The gap between the expiries is too small. --

[jira] [Created] (KAFKA-14547) Be able to run kafka KRaft Server in tests without needing to run a storage setup script

2022-12-22 Thread Natan Silnitsky (Jira)
Natan Silnitsky created KAFKA-14547: --- Summary: Be able to run kafka KRaft Server in tests without needing to run a storage setup script Key: KAFKA-14547 URL: https://issues.apache.org/jira/browse/KAFKA-14547

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12802: KAFKA-14311: Connect Worker clean shutdown does not cleanly stop connectors/tasks

2022-12-22 Thread GitBox
vamossagar12 commented on code in PR #12802: URL: https://github.com/apache/kafka/pull/12802#discussion_r1055610031 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -271,6 +275,9 @@ public DistributedHerder(DistributedCo

[GitHub] [kafka] vamossagar12 commented on pull request #12802: KAFKA-14311: Connect Worker clean shutdown does not cleanly stop connectors/tasks

2022-12-22 Thread GitBox
vamossagar12 commented on PR #12802: URL: https://github.com/apache/kafka/pull/12802#issuecomment-1363006858 Thanks Chris! Made the suggested changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13036: KAFKA-14534: Reduce flakiness in TransactionsExpirationTest

2022-12-22 Thread GitBox
gharris1727 commented on code in PR #13036: URL: https://github.com/apache/kafka/pull/13036#discussion_r1055666985 ## core/src/test/scala/integration/kafka/api/TransactionsExpirationTest.scala: ## @@ -128,10 +128,13 @@ class TransactionsExpirationTest extends KafkaServerTestHar

[GitHub] [kafka] gharris1727 commented on pull request #13036: KAFKA-14534: Reduce flakiness in TransactionsExpirationTest

2022-12-22 Thread GitBox
gharris1727 commented on PR #13036: URL: https://github.com/apache/kafka/pull/13036#issuecomment-1363112472 > after your change, it failed other tests: Thanks, fixed. I was running only the first test locally and didn't check to see what the timeouts in the other test were. > A

[GitHub] [kafka] jolshan commented on a diff in pull request #13036: KAFKA-14534: Reduce flakiness in TransactionsExpirationTest

2022-12-22 Thread GitBox
jolshan commented on code in PR #13036: URL: https://github.com/apache/kafka/pull/13036#discussion_r1055678738 ## core/src/test/scala/integration/kafka/api/TransactionsExpirationTest.scala: ## @@ -128,10 +128,13 @@ class TransactionsExpirationTest extends KafkaServerTestHarness

[GitHub] [kafka] jolshan commented on a diff in pull request #13036: KAFKA-14534: Reduce flakiness in TransactionsExpirationTest

2022-12-22 Thread GitBox
jolshan commented on code in PR #13036: URL: https://github.com/apache/kafka/pull/13036#discussion_r1055683579 ## core/src/test/scala/integration/kafka/api/TransactionsExpirationTest.scala: ## @@ -205,9 +211,9 @@ class TransactionsExpirationTest extends KafkaServerTestHarness {

[GitHub] [kafka] jolshan commented on a diff in pull request #13036: KAFKA-14534: Reduce flakiness in TransactionsExpirationTest

2022-12-22 Thread GitBox
jolshan commented on code in PR #13036: URL: https://github.com/apache/kafka/pull/13036#discussion_r1055685104 ## core/src/test/scala/integration/kafka/api/TransactionsExpirationTest.scala: ## @@ -129,9 +129,11 @@ class TransactionsExpirationTest extends KafkaServerTestHarness

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13036: KAFKA-14534: Reduce flakiness in TransactionsExpirationTest

2022-12-22 Thread GitBox
gharris1727 commented on code in PR #13036: URL: https://github.com/apache/kafka/pull/13036#discussion_r1055697654 ## core/src/test/scala/integration/kafka/api/TransactionsExpirationTest.scala: ## @@ -205,9 +211,9 @@ class TransactionsExpirationTest extends KafkaServerTestHarne

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13036: KAFKA-14534: Reduce flakiness in TransactionsExpirationTest

2022-12-22 Thread GitBox
gharris1727 commented on code in PR #13036: URL: https://github.com/apache/kafka/pull/13036#discussion_r1055698925 ## core/src/test/scala/integration/kafka/api/TransactionsExpirationTest.scala: ## @@ -129,9 +129,11 @@ class TransactionsExpirationTest extends KafkaServerTestHarn

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13036: KAFKA-14534: Reduce flakiness in TransactionsExpirationTest

2022-12-22 Thread GitBox
gharris1727 commented on code in PR #13036: URL: https://github.com/apache/kafka/pull/13036#discussion_r1055697654 ## core/src/test/scala/integration/kafka/api/TransactionsExpirationTest.scala: ## @@ -205,9 +211,9 @@ class TransactionsExpirationTest extends KafkaServerTestHarne

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13036: KAFKA-14534: Reduce flakiness in TransactionsExpirationTest

2022-12-22 Thread GitBox
gharris1727 commented on code in PR #13036: URL: https://github.com/apache/kafka/pull/13036#discussion_r1055697654 ## core/src/test/scala/integration/kafka/api/TransactionsExpirationTest.scala: ## @@ -205,9 +211,9 @@ class TransactionsExpirationTest extends KafkaServerTestHarne

[GitHub] [kafka] jolshan commented on a diff in pull request #13036: KAFKA-14534: Reduce flakiness in TransactionsExpirationTest

2022-12-22 Thread GitBox
jolshan commented on code in PR #13036: URL: https://github.com/apache/kafka/pull/13036#discussion_r1055725758 ## core/src/test/scala/integration/kafka/api/TransactionsExpirationTest.scala: ## @@ -129,9 +129,11 @@ class TransactionsExpirationTest extends KafkaServerTestHarness

[GitHub] [kafka] jolshan commented on a diff in pull request #13036: KAFKA-14534: Reduce flakiness in TransactionsExpirationTest

2022-12-22 Thread GitBox
jolshan commented on code in PR #13036: URL: https://github.com/apache/kafka/pull/13036#discussion_r1055726851 ## core/src/test/scala/integration/kafka/api/TransactionsExpirationTest.scala: ## @@ -205,9 +211,9 @@ class TransactionsExpirationTest extends KafkaServerTestHarness {

[GitHub] [kafka] gharris1727 commented on pull request #11818: KAFKA-12558: Do not prematurely mutate partiton state and provide con…

2022-12-22 Thread GitBox
gharris1727 commented on PR #11818: URL: https://github.com/apache/kafka/pull/11818#issuecomment-1363205406 Thanks for the update @emilnkrastev. It appears there are some CI failures that mention offsets translation that we need to look into, especially in `MirrorConnectorsIntegration

[jira] [Created] (KAFKA-14548) Stable streams applications stall due to infrequent restoreConsumer polls

2022-12-22 Thread Greg Harris (Jira)
Greg Harris created KAFKA-14548: --- Summary: Stable streams applications stall due to infrequent restoreConsumer polls Key: KAFKA-14548 URL: https://issues.apache.org/jira/browse/KAFKA-14548 Project: Kafk

[jira] [Updated] (KAFKA-14548) Stable streams applications stall due to infrequent restoreConsumer polls

2022-12-22 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14548: Description: We have observed behavior with Streams where otherwise healthy applications stall an

[jira] [Commented] (KAFKA-14548) Stable streams applications stall due to infrequent restoreConsumer polls

2022-12-22 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651401#comment-17651401 ] Greg Harris commented on KAFKA-14548: - [~mjsax] as you had previously categorized h

[jira] [Updated] (KAFKA-14548) Stable streams applications stall due to infrequent restoreConsumer polls

2022-12-22 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14548: Description: We have observed behavior with Streams where otherwise healthy applications stall an

[jira] [Updated] (KAFKA-14549) Move LogDirFailureChannel to storage module

2022-12-22 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14549: Fix Version/s: 3.5.0 > Move LogDirFailureChannel to storage module > -

[jira] [Assigned] (KAFKA-14549) Move LogDirFailureChannel to storage module

2022-12-22 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri reassigned KAFKA-14549: --- Assignee: Federico Valeri > Move LogDirFailureChannel to storage module > -

[jira] [Created] (KAFKA-14549) Move LogDirFailureChannel to storage module

2022-12-22 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-14549: --- Summary: Move LogDirFailureChannel to storage module Key: KAFKA-14549 URL: https://issues.apache.org/jira/browse/KAFKA-14549 Project: Kafka Issue Type:

[GitHub] [kafka] fvaleri opened a new pull request, #13041: KAFKA-14549: Move LogDirFailureChannel to storage module

2022-12-22 Thread GitBox
fvaleri opened a new pull request, #13041: URL: https://github.com/apache/kafka/pull/13041 For broader context on this change, please check: * KAFKA-14470: Move log layer to storage module -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [kafka] ijuma opened a new pull request, #13042: KAFKA-14476: Move OffsetMap and related to storage module

2022-12-22 Thread GitBox
ijuma opened a new pull request, #13042: URL: https://github.com/apache/kafka/pull/13042 For broader context on this change, please check: * KAFKA-14470: Move log layer to storage module ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementa

[GitHub] [kafka] ijuma commented on pull request #13042: KAFKA-14476: Move OffsetMap and related to storage module

2022-12-22 Thread GitBox
ijuma commented on PR #13042: URL: https://github.com/apache/kafka/pull/13042#issuecomment-1363376725 cc @satishd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[jira] [Updated] (KAFKA-14476) Move OffsetMap to storage module

2022-12-22 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-14476: Fix Version/s: 3.5.0 > Move OffsetMap to storage module > > >

[jira] [Commented] (KAFKA-14548) Stable streams applications stall due to infrequent restoreConsumer polls

2022-12-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651440#comment-17651440 ] Matthias J. Sax commented on KAFKA-14548: - {quote}This is an anti-pattern, as fr

[jira] [Commented] (KAFKA-14543) Move LogOffsetMetadata to storage module

2022-12-22 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651456#comment-17651456 ] Satish Duggana commented on KAFKA-14543: [~mimaison] Pulling these changes shoul

[GitHub] [kafka] satishd commented on a diff in pull request #13042: KAFKA-14476: Move OffsetMap and related to storage module

2022-12-22 Thread GitBox
satishd commented on code in PR #13042: URL: https://github.com/apache/kafka/pull/13042#discussion_r1055958939 ## storage/src/main/java/org/apache/kafka/server/log/internals/SkimpyOffsetMap.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] satishd commented on pull request #13042: KAFKA-14476: Move OffsetMap and related to storage module

2022-12-22 Thread GitBox
satishd commented on PR #13042: URL: https://github.com/apache/kafka/pull/13042#issuecomment-1363493292 @ijuma There are test failures occurring in LogCleanerLagIntegrationTest, OffsetMapTest, and LogCleanerParameterizedIntegrationTest -- This is an automated message from the Apache Git S

[GitHub] [kafka] satishd commented on a diff in pull request #13042: KAFKA-14476: Move OffsetMap and related to storage module

2022-12-22 Thread GitBox
satishd commented on code in PR #13042: URL: https://github.com/apache/kafka/pull/13042#discussion_r1055973548 ## storage/src/main/java/org/apache/kafka/server/log/internals/SkimpyOffsetMap.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] satishd commented on a diff in pull request #13042: KAFKA-14476: Move OffsetMap and related to storage module

2022-12-22 Thread GitBox
satishd commented on code in PR #13042: URL: https://github.com/apache/kafka/pull/13042#discussion_r1055973548 ## storage/src/main/java/org/apache/kafka/server/log/internals/SkimpyOffsetMap.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] ijuma commented on a diff in pull request #13042: KAFKA-14476: Move OffsetMap and related to storage module

2022-12-22 Thread GitBox
ijuma commented on code in PR #13042: URL: https://github.com/apache/kafka/pull/13042#discussion_r1055980846 ## storage/src/main/java/org/apache/kafka/server/log/internals/SkimpyOffsetMap.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] ijuma commented on a diff in pull request #13042: KAFKA-14476: Move OffsetMap and related to storage module

2022-12-22 Thread GitBox
ijuma commented on code in PR #13042: URL: https://github.com/apache/kafka/pull/13042#discussion_r1055981406 ## storage/src/main/java/org/apache/kafka/server/log/internals/SkimpyOffsetMap.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] ijuma commented on a diff in pull request #13042: KAFKA-14476: Move OffsetMap and related to storage module

2022-12-22 Thread GitBox
ijuma commented on code in PR #13042: URL: https://github.com/apache/kafka/pull/13042#discussion_r1055981406 ## storage/src/main/java/org/apache/kafka/server/log/internals/SkimpyOffsetMap.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] ijuma commented on pull request #13042: KAFKA-14476: Move OffsetMap and related to storage module

2022-12-22 Thread GitBox
ijuma commented on PR #13042: URL: https://github.com/apache/kafka/pull/13042#issuecomment-1363545216 @satishd Addressed your comments and pushed an additional fix to address an `OffsetMapTest` failure. The CI build should be good now, but I'll wait for it to complete. -- This is an auto

[GitHub] [kafka] ijuma commented on pull request #13042: KAFKA-14476: Move OffsetMap and related to storage module

2022-12-22 Thread GitBox
ijuma commented on PR #13042: URL: https://github.com/apache/kafka/pull/13042#issuecomment-1363545617 @dengziming Fyi, I pushed a small fix right after your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [kafka] dengziming commented on a diff in pull request #13037: MINOR: make sure all partition info is propagated

2022-12-22 Thread GitBox
dengziming commented on code in PR #13037: URL: https://github.com/apache/kafka/pull/13037#discussion_r1055993951 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -452,6 +452,7 @@ object TestUtils extends Logging { } catch { case e: ExecutionException =

[GitHub] [kafka] showuon commented on a diff in pull request #13037: MINOR: make sure all partition info is propagated

2022-12-22 Thread GitBox
showuon commented on code in PR #13037: URL: https://github.com/apache/kafka/pull/13037#discussion_r1055995690 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -452,6 +452,7 @@ object TestUtils extends Logging { } catch { case e: ExecutionException => i

[GitHub] [kafka] showuon commented on a diff in pull request #13037: MINOR: make sure all partition info is propagated

2022-12-22 Thread GitBox
showuon commented on code in PR #13037: URL: https://github.com/apache/kafka/pull/13037#discussion_r1055995690 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -452,6 +452,7 @@ object TestUtils extends Logging { } catch { case e: ExecutionException => i

[GitHub] [kafka] showuon commented on a diff in pull request #13037: MINOR: make sure all partition info is propagated

2022-12-22 Thread GitBox
showuon commented on code in PR #13037: URL: https://github.com/apache/kafka/pull/13037#discussion_r1055995690 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -452,6 +452,7 @@ object TestUtils extends Logging { } catch { case e: ExecutionException => i

[GitHub] [kafka] ijuma commented on a diff in pull request #13041: KAFKA-14549: Move LogDirFailureChannel to storage module

2022-12-22 Thread GitBox
ijuma commented on code in PR #13041: URL: https://github.com/apache/kafka/pull/13041#discussion_r1056024481 ## storage/src/main/java/org/apache/kafka/server/log/internals/LogDirFailureChannel.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [kafka] ijuma commented on a diff in pull request #13038: KAFKA-14543: Move LogOffsetMetadata to storage module

2022-12-22 Thread GitBox
ijuma commented on code in PR #13038: URL: https://github.com/apache/kafka/pull/13038#discussion_r1056046009 ## storage/src/main/java/org/apache/kafka/server/log/internals/LogOffsetMetadata.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Created] (KAFKA-14550) MoveSnapshotFile and CorruptSnapshotException to storage module

2022-12-22 Thread Satish Duggana (Jira)
Satish Duggana created KAFKA-14550: -- Summary: MoveSnapshotFile and CorruptSnapshotException to storage module Key: KAFKA-14550 URL: https://issues.apache.org/jira/browse/KAFKA-14550 Project: Kafka

[GitHub] [kafka] ijuma commented on a diff in pull request #13037: MINOR: make sure all partition info is propagated

2022-12-22 Thread GitBox
ijuma commented on code in PR #13037: URL: https://github.com/apache/kafka/pull/13037#discussion_r1056083746 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -452,6 +452,7 @@ object TestUtils extends Logging { } catch { case e: ExecutionException => if

[GitHub] [kafka] satishd opened a new pull request, #13043: [Draft] Move ProducerStateManager auxiliary classes to storage module.

2022-12-22 Thread GitBox
satishd opened a new pull request, #13043: URL: https://github.com/apache/kafka/pull/13043 Move ProducerStateManager auxiliary classes to storage module. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and