gharris1727 commented on PR #11818: URL: https://github.com/apache/kafka/pull/11818#issuecomment-1363205406
Thanks for the update @emilnkrastev. It appears there are some CI failures that mention offsets translation that we need to look into, especially in `MirrorConnectorsIntegrationSSLTest` Additionally, I'm trying to think of ways to reliably test this behavior. You've translated the existing test to work with the new update signature, but we haven't really targeted the semaphore balking behavior in a regression test. The lack of code coverage is partly why we didn't notice this before. Here's a couple of ideas that might work, i'll let you choose whichever one you think makes more sense. * Mock the semaphore acquire/release and unit test to simulate balking in MirrorSourceTaskTest * Mock the producer and delay the send callback to cause the real semaphore to balk in MirrorSourceTaskTest * Refactor the MirrorSourceTask semaphore to make it more unit-testable. * Add a test to MirrorConnectorsIntegrationTestBase with a large contention on this semaphore and assert that the checkpoint offsets are sensible. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
