[GitHub] [kafka] jolshan commented on a diff in pull request #13036: KAFKA-14534: Reduce flakiness in TransactionsExpirationTest

Thu, 22 Dec 2022 09:22:15 -0800 


jolshan commented on code in PR #13036:
URL: https://github.com/apache/kafka/pull/13036#discussion_r1055683579


##########
core/src/test/scala/integration/kafka/api/TransactionsExpirationTest.scala:
##########
@@ -205,9 +211,9 @@ class TransactionsExpirationTest extends 
KafkaServerTestHarness {
     serverProps.put(KafkaConfig.AutoLeaderRebalanceEnableProp, false.toString)
     serverProps.put(KafkaConfig.GroupInitialRebalanceDelayMsProp, "0")
     
serverProps.put(KafkaConfig.TransactionsAbortTimedOutTransactionCleanupIntervalMsProp,
 "200")
-    serverProps.put(KafkaConfig.TransactionalIdExpirationMsProp, "1000")
+    serverProps.put(KafkaConfig.TransactionalIdExpirationMsProp, "10000")

Review Comment:
   Maybe a nit, but was this much of an increase required? (Next time I should 
write tests that use mock time 😓 )



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to