vamossagar12 commented on code in PR #12802:
URL: https://github.com/apache/kafka/pull/12802#discussion_r1055610031
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##########
@@ -271,6 +275,9 @@ public DistributedHerder(DistributedConfig config,
this.workerGroupId =
config.getString(DistributedConfig.GROUP_ID_CONFIG);
this.workerSyncTimeoutMs =
config.getInt(DistributedConfig.WORKER_SYNC_TIMEOUT_MS_CONFIG);
this.workerTasksShutdownTimeoutMs =
config.getLong(DistributedConfig.TASK_SHUTDOWN_GRACEFUL_TIMEOUT_MS_CONFIG);
+ // Timeout for herderExecutor to gracefully terminate is set to a
value to accommodate
+ // reading to the end of the config topic + successfully attempting to
stop all connectors and tasks and a buffer of 10s
+ this.herderExecutorTerminationTimeoutMs = this.workerSyncTimeoutMs +
this.workerTasksShutdownTimeoutMs +
Worker.CONNECTOR_GRACEFUL_SHUTDOWN_TIMEOUT_MS + 10000;
Review Comment:
makes sense. it was starting to look cluttered. Moved it out as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
