[GitHub] [kafka] showuon commented on a change in pull request #11288: MINOR: Fix error response generation

showuon commented on a change in pull request #11288: URL: https://github.com/apache/kafka/pull/11288#discussion_r703239913 ## File path: clients/src/main/java/org/apache/kafka/common/requests/DescribeProducersRequest.java ## @@ -80,6 +80,7 @@ public DescribeProducersResponse

[GitHub] [kafka] showuon commented on pull request #11288: MINOR: Fix error response generation

showuon commented on pull request #11288: URL: https://github.com/apache/kafka/pull/11288#issuecomment-914059309 Also, this PR title should be updated to link to JIRA tickets. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] tombentley commented on pull request #11301: KAFKA-13276: Prefer KafkaFuture in admin Result constructors

tombentley commented on pull request #11301: URL: https://github.com/apache/kafka/pull/11301#issuecomment-914082991 @dajac @showuon thanks, I've addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] tombentley commented on a change in pull request #11301: KAFKA-13276: Prefer KafkaFuture in admin Result constructors

tombentley commented on a change in pull request #11301: URL: https://github.com/apache/kafka/pull/11301#discussion_r703274931 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminApiFuture.java ## @@ -109,7 +110,7 @@ private void completeException

[GitHub] [kafka] patrickstuedi commented on a change in pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

patrickstuedi commented on a change in pull request #10798: URL: https://github.com/apache/kafka/pull/10798#discussion_r703309462 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -505,6 +506,14 @@ private void closeOpenIterat

[GitHub] [kafka] patrickstuedi commented on a change in pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

patrickstuedi commented on a change in pull request #10798: URL: https://github.com/apache/kafka/pull/10798#discussion_r703312659 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -505,6 +506,14 @@ private void closeOpenIterat

[GitHub] [kafka] vamossagar12 commented on a change in pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

vamossagar12 commented on a change in pull request #10798: URL: https://github.com/apache/kafka/pull/10798#discussion_r70661 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -505,6 +506,14 @@ private void closeOpenIterato

[GitHub] [kafka] vamossagar12 commented on a change in pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

vamossagar12 commented on a change in pull request #10798: URL: https://github.com/apache/kafka/pull/10798#discussion_r703336198 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -505,6 +506,14 @@ private void closeOpenIterato

[GitHub] [kafka] vamossagar12 commented on a change in pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

vamossagar12 commented on a change in pull request #10798: URL: https://github.com/apache/kafka/pull/10798#discussion_r703336198 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -505,6 +506,14 @@ private void closeOpenIterato

[GitHub] [kafka] apenam opened a new pull request #11305: Make classpath smaller

apenam opened a new pull request #11305: URL: https://github.com/apache/kafka/pull/11305 Fix `The input line is too long. The syntax of the command is incorrect` error when running on a windows environment. *More detailed description of your change, if necessary. The PR title and

[GitHub] [kafka] TomerWizman commented on a change in pull request #11250: Kafka 12766 - Disabling WAL-related Options in RocksDB

TomerWizman commented on a change in pull request #11250: URL: https://github.com/apache/kafka/pull/11250#discussion_r703348241 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java ## @@ -2

[GitHub] [kafka] tombentley commented on a change in pull request #11302: KAFKA-13243: KIP-773 Differentiate metric latency measured in ms and ns

tombentley commented on a change in pull request #11302: URL: https://github.com/apache/kafka/pull/11302#discussion_r703359283 ## File path: clients/src/main/java/org/apache/kafka/common/network/Selector.java ## @@ -1272,12 +1274,27 @@ private Meter createMeter(Metrics metrics,

[GitHub] [kafka] jlprat commented on pull request #11254: KAFKA-2424: Introduce Scalafix linter

jlprat commented on pull request #11254: URL: https://github.com/apache/kafka/pull/11254#issuecomment-914189101 Rebased the changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [kafka] cadonna commented on a change in pull request #11250: Kafka 12766 - Disabling WAL-related Options in RocksDB

cadonna commented on a change in pull request #11250: URL: https://github.com/apache/kafka/pull/11250#discussion_r703386486 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.java ## @@ -1

[GitHub] [kafka] jlprat commented on pull request #11302: KAFKA-13243: KIP-773 Differentiate metric latency measured in ms and ns

jlprat commented on pull request #11302: URL: https://github.com/apache/kafka/pull/11302#issuecomment-914195040 Thanks for your feedback @tombentley . You feel free to review the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] patrickstuedi commented on a change in pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

patrickstuedi commented on a change in pull request #10798: URL: https://github.com/apache/kafka/pull/10798#discussion_r703439679 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -505,6 +506,14 @@ private void closeOpenIterat

[GitHub] [kafka] TomerWizman commented on a change in pull request #11250: Kafka 12766 - Disabling WAL-related Options in RocksDB

TomerWizman commented on a change in pull request #11250: URL: https://github.com/apache/kafka/pull/11250#discussion_r703445569 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.java ## @

[GitHub] [kafka] TomerWizman commented on a change in pull request #11250: Kafka 12766 - Disabling WAL-related Options in RocksDB

TomerWizman commented on a change in pull request #11250: URL: https://github.com/apache/kafka/pull/11250#discussion_r703445686 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.java ## @

[GitHub] [kafka] TomerWizman commented on a change in pull request #11250: Kafka 12766 - Disabling WAL-related Options in RocksDB

TomerWizman commented on a change in pull request #11250: URL: https://github.com/apache/kafka/pull/11250#discussion_r703445767 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.java ## @

[GitHub] [kafka] TomerWizman commented on a change in pull request #11250: Kafka 12766 - Disabling WAL-related Options in RocksDB

TomerWizman commented on a change in pull request #11250: URL: https://github.com/apache/kafka/pull/11250#discussion_r703454226 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.java ## @

[GitHub] [kafka] cadonna commented on a change in pull request #11250: Kafka 12766 - Disabling WAL-related Options in RocksDB

cadonna commented on a change in pull request #11250: URL: https://github.com/apache/kafka/pull/11250#discussion_r703455477 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.java ## @@ -3

[GitHub] [kafka] vamossagar12 commented on a change in pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

vamossagar12 commented on a change in pull request #10798: URL: https://github.com/apache/kafka/pull/10798#discussion_r703469853 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -505,6 +506,14 @@ private void closeOpenIterato

[jira] [Assigned] (KAFKA-13262) Mock Clients Now Have Final close() Methods

[ https://issues.apache.org/jira/browse/KAFKA-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reassigned KAFKA-13262: --- Assignee: Ismael Juma > Mock Clients Now Have Final close() Methods > -

[GitHub] [kafka] ijuma opened a new pull request #11306: MINOR: Update build dependencies (Q3 2021)

ijuma opened a new pull request #11306: URL: https://github.com/apache/kafka/pull/11306 TBD: release notes, etc Note that checkstyle will be upgraded in a separate PR as it requires code changes in a large number of files. ### Committer Checklist (excluded from commit messag

[GitHub] [kafka] ijuma opened a new pull request #11307: KAFKA-13262: Remove final from `MockConsumer.close()` and delegate implementation

ijuma opened a new pull request #11307: URL: https://github.com/apache/kafka/pull/11307 I added the final via 2f3600198722 to catch overriding mistakes since the implementation was moved from the deprecated and overloaded `close` with two parameters to the no-arg `close`. I d

[GitHub] [kafka] dajac commented on a change in pull request #11307: KAFKA-13262: Remove final from `MockConsumer.close()` and delegate implementation

dajac commented on a change in pull request #11307: URL: https://github.com/apache/kafka/pull/11307#discussion_r703548948 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java ## @@ -446,8 +447,8 @@ public synchronized void resume(Collection

[GitHub] [kafka] ijuma commented on a change in pull request #11307: KAFKA-13262: Remove final from `MockConsumer.close()` and delegate implementation

ijuma commented on a change in pull request #11307: URL: https://github.com/apache/kafka/pull/11307#discussion_r703555946 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java ## @@ -446,8 +447,8 @@ public synchronized void resume(Collection

[GitHub] [kafka] C0urante commented on pull request #10112: KAFKA-12226: Prevent source task offset failure when producer is overwhelmed

C0urante commented on pull request #10112: URL: https://github.com/apache/kafka/pull/10112#issuecomment-914348989 @rhauch Overall that looks good to me. It's an elegant solution to the tricky problem you noted about the opacity of task-provided source offsets w/r/t ordering. I'm a l

[jira] [Updated] (KAFKA-13243) Differentiate metric latency measured in millis and nanos

[ https://issues.apache.org/jira/browse/KAFKA-13243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat updated KAFKA-13243: --- Fix Version/s: 3.1.0 > Differentiate metric latency measured in millis and nanos > -

[GitHub] [kafka] viktorsomogyi commented on pull request #11276: KAFKA-13240: Disable HTTP TRACE Method in Connect

viktorsomogyi commented on pull request #11276: URL: https://github.com/apache/kafka/pull/11276#issuecomment-914396172 Rebased the build, it was conflicting with another change that replaced EasyMock/Powermock with Mockito so I had to change that part of my tests too. (Ran them locally suc

[GitHub] [kafka] vvcephei commented on a change in pull request #11213: KAFKA-13201: Convert KTable suppress to new PAPI

vvcephei commented on a change in pull request #11213: URL: https://github.com/apache/kafka/pull/11213#discussion_r703626660 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/suppress/KTableSuppressProcessorSupplier.java ## @@ -150,16 +153,16 @@ pu

[GitHub] [kafka] vvcephei commented on a change in pull request #11213: KAFKA-13201: Convert KTable suppress to new PAPI

vvcephei commented on a change in pull request #11213: URL: https://github.com/apache/kafka/pull/11213#discussion_r703627436 ## File path: streams/src/test/java/org/apache/kafka/test/MockInternalNewProcessorContext.java ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Softw

[jira] [Created] (KAFKA-13277) Serialization of long tagged string in request/response throws BufferOverflowException

Rajini Sivaram created KAFKA-13277: -- Summary: Serialization of long tagged string in request/response throws BufferOverflowException Key: KAFKA-13277 URL: https://issues.apache.org/jira/browse/KAFKA-13277

[GitHub] [kafka] ijuma merged pull request #11303: MINOR: Upgrade compression libraries (Q3 2021)

ijuma merged pull request #11303: URL: https://github.com/apache/kafka/pull/11303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[jira] [Commented] (KAFKA-13277) Serialization of long tagged string in request/response throws BufferOverflowException

[ https://issues.apache.org/jira/browse/KAFKA-13277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411309#comment-17411309 ] Ismael Juma commented on KAFKA-13277: - [~rsivaram] isn't this a blocker for 3.0? >

[GitHub] [kafka] vvcephei commented on a change in pull request #11213: KAFKA-13201: Convert KTable suppress to new PAPI

vvcephei commented on a change in pull request #11213: URL: https://github.com/apache/kafka/pull/11213#discussion_r703630483 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/suppress/KTableSuppressProcessorSupplier.java ## @@ -198,7 +201,7 @@ priv

[jira] [Commented] (KAFKA-13277) Serialization of long tagged string in request/response throws BufferOverflowException

[ https://issues.apache.org/jira/browse/KAFKA-13277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411311#comment-17411311 ] Rajini Sivaram commented on KAFKA-13277: [~ijuma] Yes, it will be good include i

[jira] [Updated] (KAFKA-13277) Serialization of long tagged string in request/response throws BufferOverflowException

[ https://issues.apache.org/jira/browse/KAFKA-13277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram updated KAFKA-13277: --- Priority: Blocker (was: Major) > Serialization of long tagged string in request/response th

[jira] [Updated] (KAFKA-13277) Serialization of long tagged string in request/response throws BufferOverflowException

[ https://issues.apache.org/jira/browse/KAFKA-13277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram updated KAFKA-13277: --- Fix Version/s: (was: 3.0.1) 3.0.0 > Serialization of long tagged stri

[jira] [Updated] (KAFKA-13266) `InitialFetchState` should be created after partition is removed from the fetchers

[ https://issues.apache.org/jira/browse/KAFKA-13266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13266: Priority: Blocker (was: Critical) > `InitialFetchState` should be created after partition is remo

[jira] [Updated] (KAFKA-13266) `InitialFetchState` should be created after partition is removed from the fetchers

[ https://issues.apache.org/jira/browse/KAFKA-13266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13266: Fix Version/s: 3.0.0 > `InitialFetchState` should be created after partition is removed from the

[jira] [Updated] (KAFKA-13276) Public DescribeConsumerGroupsResult constructor refers to KafkaFutureImpl

[ https://issues.apache.org/jira/browse/KAFKA-13276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13276: Fix Version/s: 3.0.0 > Public DescribeConsumerGroupsResult constructor refers to KafkaFutureImpl >

[jira] [Commented] (KAFKA-13260) FindCoordinator errorCounts does not handle v4

[ https://issues.apache.org/jira/browse/KAFKA-13260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411315#comment-17411315 ] Ismael Juma commented on KAFKA-13260: - 3.0.0 hasn't been released yet, so it's a bit

[jira] [Updated] (KAFKA-13266) `InitialFetchState` should be created after partition is removed from the fetchers

[ https://issues.apache.org/jira/browse/KAFKA-13266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13266: Affects Version/s: (was: 3.0.0) > `InitialFetchState` should be created after partition is rem

[jira] [Updated] (KAFKA-13260) FindCoordinator errorCounts does not handle v4

[ https://issues.apache.org/jira/browse/KAFKA-13260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13260: Affects Version/s: (was: 3.0.0) > FindCoordinator errorCounts does not handle v4 > ---

[jira] [Updated] (KAFKA-13260) FindCoordinator errorCounts does not handle v4

[ https://issues.apache.org/jira/browse/KAFKA-13260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13260: Fix Version/s: 3.0.0 > FindCoordinator errorCounts does not handle v4 > --

[jira] [Assigned] (KAFKA-13276) Public DescribeConsumerGroupsResult constructor refers to KafkaFutureImpl

[ https://issues.apache.org/jira/browse/KAFKA-13276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reassigned KAFKA-13276: --- Assignee: Tom Bentley > Public DescribeConsumerGroupsResult constructor refers to KafkaFutu

[jira] [Updated] (KAFKA-13260) FindCoordinator errorCounts does not handle v4

[ https://issues.apache.org/jira/browse/KAFKA-13260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13260: Priority: Blocker (was: Major) > FindCoordinator errorCounts does not handle v4 > ---

[jira] [Updated] (KAFKA-13259) DescribeProducers response does not include an error when it failed

[ https://issues.apache.org/jira/browse/KAFKA-13259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13259: Fix Version/s: 3.0.0 > DescribeProducers response does not include an error when it failed > -

[jira] [Updated] (KAFKA-13259) DescribeProducers response does not include an error when it failed

[ https://issues.apache.org/jira/browse/KAFKA-13259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13259: Affects Version/s: (was: 3.0.0) > DescribeProducers response does not include an error when it

[jira] [Updated] (KAFKA-13258) AlterClientQuotas response does not include an error when it failed

[ https://issues.apache.org/jira/browse/KAFKA-13258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13258: Fix Version/s: 3.0.0 > AlterClientQuotas response does not include an error when it failed > -

[jira] [Updated] (KAFKA-13259) DescribeProducers response does not include an error when it failed

[ https://issues.apache.org/jira/browse/KAFKA-13259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13259: Fix Version/s: 2.8.1 > DescribeProducers response does not include an error when it failed > -

[jira] [Updated] (KAFKA-13258) AlterClientQuotas response does not include an error when it failed

[ https://issues.apache.org/jira/browse/KAFKA-13258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13258: Affects Version/s: (was: 3.0.0) > AlterClientQuotas response does not include an error when it

[jira] [Updated] (KAFKA-13258) AlterClientQuotas response does not include an error when it failed

[ https://issues.apache.org/jira/browse/KAFKA-13258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13258: Fix Version/s: 2.8.1 > AlterClientQuotas response does not include an error when it failed > -

[jira] [Updated] (KAFKA-13258) AlterClientQuotas response does not include an error when it failed

[ https://issues.apache.org/jira/browse/KAFKA-13258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13258: Priority: Blocker (was: Major) > AlterClientQuotas response does not include an error when it fai

[GitHub] [kafka] ijuma commented on pull request #11300: KAFKA-13258/13259/13260: Fix error response generation

ijuma commented on pull request #11300: URL: https://github.com/apache/kafka/pull/11300#issuecomment-914446506 @mimaison I synced with @kkonstantine and he said he's ok with this being merged to 3.0. He will update the release thread soon, but let's get this in when we're ready to avoid de

[GitHub] [kafka] rajinisivaram opened a new pull request #11308: KAFKA-13277; Fix size calculation for tagged string fields in message generator

rajinisivaram opened a new pull request #11308: URL: https://github.com/apache/kafka/pull/11308 Size calculation for tagged fields is currently incorrect and works only for small strings. This results in BufferOverflowException when serializing requests with large strings in tagged fields.

[jira] [Commented] (KAFKA-13248) Class name mismatch for LoggerFactory.getLogger method in TimeOrderedWindowStoreBuilder.java

[ https://issues.apache.org/jira/browse/KAFKA-13248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411347#comment-17411347 ] Guozhang Wang commented on KAFKA-13248: --- [~sider-bughunter] Thanks for the find. I

[GitHub] [kafka] spena commented on a change in pull request #11252: KAFKA-13216: Use a KV with list serde for the shared store

spena commented on a change in pull request #11252: URL: https://github.com/apache/kafka/pull/11252#discussion_r703675892 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/TimestampedTimestampedKeyAndJoinSideSerializerTest.java ## @@ -24,49 +24,49 @@

[GitHub] [kafka] jeqo commented on a change in pull request #11213: KAFKA-13201: Convert KTable suppress to new PAPI

jeqo commented on a change in pull request #11213: URL: https://github.com/apache/kafka/pull/11213#discussion_r703713785 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/suppress/KTableSuppressProcessorSupplier.java ## @@ -198,7 +201,7 @@ private

[GitHub] [kafka] jeqo commented on a change in pull request #11213: KAFKA-13201: Convert KTable suppress to new PAPI

jeqo commented on a change in pull request #11213: URL: https://github.com/apache/kafka/pull/11213#discussion_r703713785 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/suppress/KTableSuppressProcessorSupplier.java ## @@ -198,7 +201,7 @@ private

[GitHub] [kafka] rhauch commented on pull request #10112: KAFKA-12226: Prevent source task offset failure when producer is overwhelmed

rhauch commented on pull request #10112: URL: https://github.com/apache/kafka/pull/10112#issuecomment-914547745 @C0urante, thanks for the feedback on my suggestion. I like your option 3, because it does allow the iteration to stop on each source partition as soon as it encounters the first

[GitHub] [kafka] ijuma commented on pull request #11307: KAFKA-13262: Remove final from `MockConsumer.close()` and delegate implementation

ijuma commented on pull request #11307: URL: https://github.com/apache/kafka/pull/11307#issuecomment-914551974 Unrelated test failures: > Build / JDK 17 and Scala 2.13 / org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldPrefixAllInternalTopicNamesWithNamedTopolo

[GitHub] [kafka] ijuma merged pull request #11307: KAFKA-13262: Remove final from `MockConsumer.close()` and delegate implementation

ijuma merged pull request #11307: URL: https://github.com/apache/kafka/pull/11307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] ijuma commented on pull request #11307: KAFKA-13262: Remove final from `MockConsumer.close()` and delegate implementation

ijuma commented on pull request #11307: URL: https://github.com/apache/kafka/pull/11307#issuecomment-914552427 Merged to master and cherry-picked to 3.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [kafka] cmccabe merged pull request #11308: KAFKA-13277; Fix size calculation for tagged string fields in message generator

cmccabe merged pull request #11308: URL: https://github.com/apache/kafka/pull/11308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] ccding commented on pull request #11293: MINOR: defineInternal for KIP-405 configs

ccding commented on pull request #11293: URL: https://github.com/apache/kafka/pull/11293#issuecomment-914613398 It failed here https://github.com/apache/kafka/blob/9d107c174bfb23e5ce0daca9a59796f018f627c6/core[…]t/scala/integration/kafka/api/SaslSslAdminIntegrationTest.scala ``` Expec

[GitHub] [kafka] ccding edited a comment on pull request #11293: MINOR: defineInternal for KIP-405 configs

ccding edited a comment on pull request #11293: URL: https://github.com/apache/kafka/pull/11293#issuecomment-914613398 It failed here https://github.com/apache/kafka/blob/9d107c174bfb23e5ce0daca9a59796f018f627c6/core/src/test/scala/integration/kafka/api/SaslSslAdminIntegrationTest.scala#L43

[GitHub] [kafka] junrao commented on a change in pull request #11033: KAFKA-12988 Asynchronous API support for RemoteLogMetadataManager add/update methods.

junrao commented on a change in pull request #11033: URL: https://github.com/apache/kafka/pull/11033#discussion_r703798708 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java ## @@ -129,37 +132,44 @@ p

[GitHub] [kafka] guozhangwang commented on pull request #11297: KAFKA-10038: Supports default client.id for ConsoleConsumer, ProducerPerformance, ConsumerPerformance

guozhangwang commented on pull request #11297: URL: https://github.com/apache/kafka/pull/11297#issuecomment-914619982 Thanks @jasonyanwenl , the PR lgtm, and thank you also for adding the unit tests. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] guozhangwang merged pull request #11297: KAFKA-10038: Supports default client.id for ConsoleConsumer, ProducerPerformance, ConsumerPerformance

guozhangwang merged pull request #11297: URL: https://github.com/apache/kafka/pull/11297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] guozhangwang merged pull request #11304: MINOR: Supplement unit test for KAFKA-13175 : Optimization TopicExis…

guozhangwang merged pull request #11304: URL: https://github.com/apache/kafka/pull/11304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[jira] [Commented] (KAFKA-9366) Upgrade log4j to log4j2

[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411480#comment-17411480 ] Ashish Patil commented on KAFKA-9366: - Thanks, [~dongjin] > Upgrade log4j to log4j2

[GitHub] [kafka] guozhangwang commented on a change in pull request #11302: KAFKA-13243: KIP-773 Differentiate metric latency measured in ms and ns

guozhangwang commented on a change in pull request #11302: URL: https://github.com/apache/kafka/pull/11302#discussion_r703822498 ## File path: docs/upgrade.html ## @@ -22,9 +22,12 @@ Notable changes in 3.1.0 Apache Kafka supports Java 17. +The following metrics hav

[GitHub] [kafka] guozhangwang commented on pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

guozhangwang commented on pull request #10798: URL: https://github.com/apache/kafka/pull/10798#issuecomment-914624644 Okay, let me re-trigger the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] C0urante commented on pull request #10566: KAFKA-12694 Avoid schema mismatch DataException when validating default values

C0urante commented on pull request #10566: URL: https://github.com/apache/kafka/pull/10566#issuecomment-914640232 Hey Gunnar! Sorry for the delay. > Initializing a Struct with a builder rather than a Schema seems to be an odd thing to do, no? Indeed it is rather odd, but it's

[GitHub] [kafka] C0urante edited a comment on pull request #10566: KAFKA-12694 Avoid schema mismatch DataException when validating default values

C0urante edited a comment on pull request #10566: URL: https://github.com/apache/kafka/pull/10566#issuecomment-914640232 Hey Gunnar! Sorry for the delay. > Initializing a Struct with a builder rather than a Schema seems to be an odd thing to do, no? Indeed it is rather odd, bu

[GitHub] [kafka] dejan2609 commented on pull request #10967: KAFKA-12770: CheckStyle team needs this feature (in order to include Kafka into their regression suite)

dejan2609 commented on pull request #10967: URL: https://github.com/apache/kafka/pull/10967#issuecomment-914653605 Adding a comment (just to bring this PR to the surface). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] vvcephei commented on pull request #11213: KAFKA-13201: Convert KTable suppress to new PAPI

vvcephei commented on pull request #11213: URL: https://github.com/apache/kafka/pull/11213#issuecomment-914663785 Java 17 errored out: ``` [2021-09-07T21:03:23.475Z] * What went wrong: [2021-09-07T21:03:23.475Z] Execution failed for task ':core:integrationTest'. [2021

[GitHub] [kafka] vvcephei merged pull request #11213: KAFKA-13201: Convert KTable suppress to new PAPI

vvcephei merged pull request #11213: URL: https://github.com/apache/kafka/pull/11213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr

[jira] [Commented] (KAFKA-13256) Possible NPE in ConfigDef when rendering (enriched) RST or HTML when documentation is not set/NULL

[ https://issues.apache.org/jira/browse/KAFKA-13256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411582#comment-17411582 ] Matthias J. Sax commented on KAFKA-13256: - [~rk3rn3r] Thanks for reporting this

[jira] [Commented] (KAFKA-10493) KTable out-of-order updates are not being ignored

[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411592#comment-17411592 ] Matthias J. Sax commented on KAFKA-10493: - Agreed. The original API only had `bu

[GitHub] [kafka] ableegoldman commented on a change in pull request #11218: MINOR: optimize performAssignment to skip unnecessary check

ableegoldman commented on a change in pull request #11218: URL: https://github.com/apache/kafka/pull/11218#discussion_r703933946 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java ## @@ -48,6 +53,16 @@ public class ConsumerConfig extends

[GitHub] [kafka] hachikuji commented on a change in pull request #11294: KAFKA-13266; `InitialFetchState` should be created after partition is removed from the fetchers

hachikuji commented on a change in pull request #11294: URL: https://github.com/apache/kafka/pull/11294#discussion_r703942630 ## File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala ## @@ -3242,6 +3260,92 @@ class ReplicaManagerTest { } } + @Test

[GitHub] [kafka] ableegoldman commented on a change in pull request #11292: KAFKA-13264: fix inMemoryWindowStore backward fetch not in reversed order

ableegoldman commented on a change in pull request #11292: URL: https://github.com/apache/kafka/pull/11292#discussion_r703945833 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/WindowStoreFetchIntegrationTest.java ## @@ -0,0 +1,229 @@ +/* + * Licensed

[jira] [Commented] (KAFKA-13269) Kafka Streams Aggregation data loss between instance restarts and rebalances

[ https://issues.apache.org/jira/browse/KAFKA-13269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411606#comment-17411606 ] A. Sophie Blee-Goldman commented on KAFKA-13269: Hey [~rohitbobade], tha

[GitHub] [kafka] ableegoldman commented on a change in pull request #11283: KAFKA-13249: Always update changelog offsets before writing the checkpoint file

ableegoldman commented on a change in pull request #11283: URL: https://github.com/apache/kafka/pull/11283#discussion_r703953000 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -565,7 +565,7 @@ public void closeCleanAndRec

[GitHub] [kafka] guozhangwang commented on pull request #11242: [WIP] MINOR: POC for KIP-591: Add config to set default store impl class

guozhangwang commented on pull request #11242: URL: https://github.com/apache/kafka/pull/11242#issuecomment-914789772 Thanks for the POC @showuon ! I made a pass and here are some high-level thoughts: 1) On the PAPI layer, users today can only add stores via Topology#addStateStore i

[jira] [Commented] (KAFKA-13268) Add more integration tests for Table Table FK joins with repartitioning

[ https://issues.apache.org/jira/browse/KAFKA-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411619#comment-17411619 ] A. Sophie Blee-Goldman commented on KAFKA-13268: What's the name of that

[GitHub] [kafka] showuon commented on a change in pull request #11218: MINOR: optimize performAssignment to skip unnecessary check

showuon commented on a change in pull request #11218: URL: https://github.com/apache/kafka/pull/11218#discussion_r703970666 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java ## @@ -48,6 +53,16 @@ public class ConsumerConfig extends Abst

[jira] [Commented] (KAFKA-13248) Class name mismatch for LoggerFactory.getLogger method in TimeOrderedWindowStoreBuilder.java

[ https://issues.apache.org/jira/browse/KAFKA-13248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411631#comment-17411631 ] S. B. Hunter commented on KAFKA-13248: -- No. Go right ahead. Thank you for your hand

[GitHub] [kafka] ableegoldman commented on a change in pull request #11278: KAFKA-12648: Enforce size limits for each task's cache

ableegoldman commented on a change in pull request #11278: URL: https://github.com/apache/kafka/pull/11278#discussion_r703973474 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/ThreadCache.java ## @@ -84,13 +85,34 @@ public synchronized void resize

[GitHub] [kafka] ableegoldman commented on a change in pull request #11218: MINOR: optimize performAssignment to skip unnecessary check

ableegoldman commented on a change in pull request #11218: URL: https://github.com/apache/kafka/pull/11218#discussion_r703978721 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java ## @@ -48,6 +53,16 @@ public class ConsumerConfig extends

[jira] [Commented] (KAFKA-12963) Improve error message for Class cast exception

[ https://issues.apache.org/jira/browse/KAFKA-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411644#comment-17411644 ] A. Sophie Blee-Goldman commented on KAFKA-12963: {quote}I can imagine th

[GitHub] [kafka] ableegoldman merged pull request #11214: KAFKA-12994 Migrate JoinWindowsTest and SessionWindowsTest to new API

ableegoldman merged pull request #11214: URL: https://github.com/apache/kafka/pull/11214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[jira] [Updated] (KAFKA-13267) InvalidPidMappingException: The producer attempted to use a producer id which is not currently assigned to its transactional id

[ https://issues.apache.org/jira/browse/KAFKA-13267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13267: Component/s: streams > InvalidPidMappingException: The producer attempted to use a produce

[jira] [Commented] (KAFKA-13267) InvalidPidMappingException: The producer attempted to use a producer id which is not currently assigned to its transactional id

[ https://issues.apache.org/jira/browse/KAFKA-13267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411666#comment-17411666 ] Matthias J. Sax commented on KAFKA-13267: - [~guozhang] [~hachikuji] – Given the

[jira] [Commented] (KAFKA-10038) ConsumerPerformance.scala supports the setting of client.id

[ https://issues.apache.org/jira/browse/KAFKA-10038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411669#comment-17411669 ] Yanwen Lin commented on KAFKA-10038: Hey [~guozhang], per this wiki: [https://cwiki

[jira] [Commented] (KAFKA-10038) ConsumerPerformance.scala supports the setting of client.id

[ https://issues.apache.org/jira/browse/KAFKA-10038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411674#comment-17411674 ] Guozhang Wang commented on KAFKA-10038: --- Yeah that should happen.. let's wait for

[jira] [Commented] (KAFKA-10038) ConsumerPerformance.scala supports the setting of client.id

[ https://issues.apache.org/jira/browse/KAFKA-10038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411675#comment-17411675 ] Yanwen Lin commented on KAFKA-10038: Sure, thanks for your super fast reply. Let's w

  1   2   >