ijuma opened a new pull request #11307: URL: https://github.com/apache/kafka/pull/11307
I added the final via 2f3600198722 to catch overriding mistakes since the implementation was moved from the deprecated and overloaded `close` with two parameters to the no-arg `close`. I didn't realize then that `MockConsumer` is a public API (seems like a bit of a mistake since we tweak the implementation and sometimes adds methods without a KIP). Given that this is a public API, I have also moved the implementation of `close` to the one arg overload. This makes it easier for a subclass to have specific overriding behavior depending on the timeout. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
