patrickstuedi commented on a change in pull request #10798:
URL: https://github.com/apache/kafka/pull/10798#discussion_r703309462
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##########
@@ -505,6 +506,14 @@ private void closeOpenIterators() {
}
}
+ private ByteBuffer createDirectByteBufferAndPut(byte[] bytes) {
+ ByteBuffer directBuffer = ByteBuffer.allocateDirect(bytes.length);
Review comment:
@vamossagar12 great to see you're about to add direct buffer support, I
was actually also looking into this. Just a few comments: as pointed out
already, one important aspect to keep in mind with direct buffers is that
allocation and disposal is more expensive than with regular heap buffers, so
it's important to re-use them, it's common practice to keep a pool of direct
buffers around and re-use them on a per-call basis (most I/O libraries to this,
e.g., netty, Crail, etc.). You can keep queues of free and used buffers and
move them around during state store operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
