[GitHub] [kafka] dajac commented on a change in pull request #11307: KAFKA-13262: Remove final from `MockConsumer.close()` and delegate implementation

[GitBox]

dajac commented on a change in pull request #11307:
URL: https://github.com/apache/kafka/pull/11307#discussion_r703548948



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java
##########
@@ -446,8 +447,8 @@ public synchronized void resume(Collection<TopicPartition> 
partitions) {
     }
 
     @Override
-    public final synchronized void close() {
-        this.closed = true;
+    public synchronized void close() {

Review comment:
       Should we move the `synchronized` to the other `close` method or add it 
there as well?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org