[GitHub] [kafka] fml2 commented on a change in pull request #9606: [KAFKA-10722] doc: Improve JavaDoc for KGroupedStream.aggregate

fml2 commented on a change in pull request #9606: URL: https://github.com/apache/kafka/pull/9606#discussion_r525882399 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/KGroupedStream.java ## @@ -438,7 +439,8 @@ * query the value of the key on a parall

[GitHub] [kafka] dajac commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

dajac commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r525888208 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -538,14 +542,20 @@ private[kafka] class Acceptor(val endPoint: EndPoint,

[GitHub] [kafka] chia7712 commented on pull request #9501: MINOR: move the test cases which don't need brokers from TopicCommand…

chia7712 commented on pull request #9501: URL: https://github.com/apache/kafka/pull/9501#issuecomment-729521905 @omkreddy Thanks for your reviews! will merge it to trunk This is an automated message from the Apache Git Servic

[GitHub] [kafka] chia7712 merged pull request #9501: MINOR: move the test cases which don't need brokers from TopicCommand…

chia7712 merged pull request #9501: URL: https://github.com/apache/kafka/pull/9501 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] twobeeb commented on pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

twobeeb commented on pull request #9589: URL: https://github.com/apache/kafka/pull/9589#issuecomment-729529865 @hachikuji ready for review, I believe failed CI is unrelated This is an automated message from the Apache Git Ser

[GitHub] [kafka] ijuma merged pull request #9566: KAFKA-10618: Update to Uuid class

ijuma merged pull request #9566: URL: https://github.com/apache/kafka/pull/9566 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] showuon commented on pull request #9507: KAFKA-10628: remove all the unnecessary parameters from the tests which are using TopologyTestDriver

showuon commented on pull request #9507: URL: https://github.com/apache/kafka/pull/9507#issuecomment-729536852 @chia7712 , the test results are: **tests/Build/JDK 11** : pass **tests/Build/JDK 15**: pass **tests/Build/JDK 8**: failed with a unrelated test org.apache.kafka.st

[GitHub] [kafka] chia7712 commented on pull request #9507: KAFKA-10628: remove all the unnecessary parameters from the tests which are using TopologyTestDriver

chia7712 commented on pull request #9507: URL: https://github.com/apache/kafka/pull/9507#issuecomment-729542152 @vvcephei I will merge this PR tomorrow. Would be helpful if you could take one more look before merge. This is

[GitHub] [kafka] dajac commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

dajac commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r525953666 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1476,33 +1650,36 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metrics

[GitHub] [kafka] chia7712 opened a new pull request #9611: KAFKA-10736 Convert transaction coordinator metadata schemas to use g…

chia7712 opened a new pull request #9611: URL: https://github.com/apache/kafka/pull/9611 issue: https://issues.apache.org/jira/browse/KAFKA-10736 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI

[GitHub] [kafka] chia7712 commented on pull request #9516: MINOR: make Send and Receive work with TransportLayer rather than Gat…

chia7712 commented on pull request #9516: URL: https://github.com/apache/kafka/pull/9516#issuecomment-729589011 @ijuma Could you take a look? This PR is according to your comment in https://github.com/apache/kafka/blob/28c57b273a3620c18be0bba6d5f74f981d9ef47d/clients/src/main/java/org/apach

[jira] [Commented] (KAFKA-10728) Mirroring data without decompressing with MirrorMaker 2.0

[ https://issues.apache.org/jira/browse/KAFKA-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234491#comment-17234491 ] Eazhilan Nagarajan commented on KAFKA-10728: Well similarly is there an opti

[GitHub] [kafka] dajac commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

dajac commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r525965065 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java ## @@ -560,13 +562,24 @@ private void handleProduceResponse(Clien

[GitHub] [kafka] chia7712 commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

chia7712 commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r526029843 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java ## @@ -560,13 +562,24 @@ private void handleProduceResponse(Cl

[GitHub] [kafka] chia7712 commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

chia7712 commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r526032716 ## File path: clients/src/test/java/org/apache/kafka/clients/NetworkClientTest.java ## @@ -154,8 +155,11 @@ public void testClose() { client.poll(

[GitHub] [kafka] chia7712 commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

chia7712 commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r526039872 ## File path: clients/src/main/resources/common/message/ProduceRequest.json ## @@ -33,21 +33,21 @@ "validVersions": "0-8", "flexibleVersions": "none"

[GitHub] [kafka] dajac commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

dajac commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r526074777 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java ## @@ -560,13 +562,24 @@ private void handleProduceResponse(Clien

[GitHub] [kafka] lbradstreet commented on pull request #9519: KAFKA-10650: Use Murmur3 instead of MD5 in SkimpyOffsetMap

lbradstreet commented on pull request #9519: URL: https://github.com/apache/kafka/pull/9519#issuecomment-729745702 @viktorsomogyi I think a hash collision for the full sized hash will mean that a message is incorrectly cleaned. Are you measuring the collision rate in the probes? I am less

[GitHub] [kafka] dajac commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

dajac commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r526178616 ## File path: clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java ## @@ -1730,7 +1768,6 @@ private DeleteTopicsResponse createDel

[GitHub] [kafka] ijuma commented on a change in pull request #9516: MINOR: make Send and Receive work with TransportLayer rather than Gat…

ijuma commented on a change in pull request #9516: URL: https://github.com/apache/kafka/pull/9516#discussion_r526178614 ## File path: clients/src/test/java/org/apache/kafka/common/network/TransportLayerUtils.java ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [kafka] dajac commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

dajac commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r526179984 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java ## @@ -580,7 +580,6 @@ synchronized void bumpIdempote

[GitHub] [kafka] C0urante commented on pull request #9599: MINOR: Include connector name in error message

C0urante commented on pull request #9599: URL: https://github.com/apache/kafka/pull/9599#issuecomment-729759979 Thanks @chia7712! This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] chia7712 commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

chia7712 commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r526187166 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java ## @@ -580,7 +580,6 @@ synchronized void bumpIdemp

[GitHub] [kafka] chia7712 commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

chia7712 commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r526190510 ## File path: clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java ## @@ -1730,7 +1768,6 @@ private DeleteTopicsResponse create

[GitHub] [kafka] chia7712 commented on a change in pull request #9516: MINOR: make Send and Receive work with TransportLayer rather than Gat…

chia7712 commented on a change in pull request #9516: URL: https://github.com/apache/kafka/pull/9516#discussion_r526195831 ## File path: clients/src/test/java/org/apache/kafka/common/network/TransportLayerUtils.java ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] ijuma commented on a change in pull request #9516: MINOR: make Send and Receive work with TransportLayer rather than Gat…

ijuma commented on a change in pull request #9516: URL: https://github.com/apache/kafka/pull/9516#discussion_r526203586 ## File path: clients/src/test/java/org/apache/kafka/common/network/TransportLayerUtils.java ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [kafka] dajac commented on a change in pull request #9547: KAFKA-9630; Replace OffsetsForLeaderEpoch request/response with automated protocol

dajac commented on a change in pull request #9547: URL: https://github.com/apache/kafka/pull/9547#discussion_r526204179 ## File path: clients/src/main/java/org/apache/kafka/common/requests/OffsetsForLeaderEpochRequest.java ## @@ -51,169 +47,120 @@ */ public static f

[GitHub] [kafka] dajac commented on a change in pull request #9547: KAFKA-9630; Replace OffsetsForLeaderEpoch request/response with automated protocol

dajac commented on a change in pull request #9547: URL: https://github.com/apache/kafka/pull/9547#discussion_r526207135 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsForLeaderEpochClient.java ## @@ -61,67 +77,76 @@ protected OffsetForEp

[GitHub] [kafka] chia7712 commented on pull request #9610: MINOR: remove "gradle wrapper" from travis.yml

chia7712 commented on pull request #9610: URL: https://github.com/apache/kafka/pull/9610#issuecomment-729778814 @ijuma Thanks for approving! Merge it to trunk. Will file another PR to handle travis error. This is an automate

[GitHub] [kafka] chia7712 merged pull request #9610: MINOR: remove "gradle wrapper" from travis.yml

chia7712 merged pull request #9610: URL: https://github.com/apache/kafka/pull/9610 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 merged pull request #6319: MINOR: Unifies implementations for commitSync in Kafka Consumer

chia7712 merged pull request #6319: URL: https://github.com/apache/kafka/pull/6319 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] dajac commented on a change in pull request #9547: KAFKA-9630; Replace OffsetsForLeaderEpoch request/response with automated protocol

dajac commented on a change in pull request #9547: URL: https://github.com/apache/kafka/pull/9547#discussion_r526207135 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsForLeaderEpochClient.java ## @@ -61,67 +77,76 @@ protected OffsetForEp

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r526211409 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -932,56 +1028,62 @@ public synchronized boolean close(final long time

[GitHub] [kafka] gardnervickers commented on pull request #9601: KAFKA-10729: Bump remaining RPC's to use tagged fields.

gardnervickers commented on pull request #9601: URL: https://github.com/apache/kafka/pull/9601#issuecomment-729796082 I realize now that we have several requests which have not been converted to use the generated RPC's. It appears we need to do that to support tagged fields. ---

[GitHub] [kafka] chia7712 commented on a change in pull request #9516: MINOR: make Send and Receive work with TransportLayer rather than Gat…

chia7712 commented on a change in pull request #9516: URL: https://github.com/apache/kafka/pull/9516#discussion_r526233758 ## File path: clients/src/test/java/org/apache/kafka/common/network/TransportLayerUtils.java ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] chia7712 opened a new pull request #9612: MINOR: add sudo to travis.yml to run ducktape

chia7712 opened a new pull request #9612: URL: https://github.com/apache/kafka/pull/9612 ``` Traceback (most recent call last): 3157 File "/usr/local/bin/ducktape", line 8, in 3158sys.exit(main()) 3159 File "/usr/local/lib/python3.7/dist-packages/ducktape/command_line/mai

[GitHub] [kafka] abbccdda opened a new pull request #9613: Cherry-pick KAFKA-10687 to 2.7

abbccdda opened a new pull request #9613: URL: https://github.com/apache/kafka/pull/9613 …(#9569) Ensures INVALID_PRODUCER_EPOCH recognizable from client side, and ensure the ProduceResponse always uses the old error code as INVALID_PRODUCER_EPOCH. Reviewers: Guozhang Wang

[GitHub] [kafka] hachikuji commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

hachikuji commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r526252595 ## File path: clients/src/main/resources/common/message/ProduceRequest.json ## @@ -33,21 +33,21 @@ "validVersions": "0-8", "flexibleVersions": "none

[GitHub] [kafka] lbradstreet commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

lbradstreet commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r526255450 ## File path: core/src/main/scala/kafka/network/RequestConvertToJson.scala ## @@ -0,0 +1,362 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] dajac commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

dajac commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r526258381 ## File path: core/src/main/scala/kafka/network/RequestConvertToJson.scala ## @@ -0,0 +1,362 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] hachikuji commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

hachikuji commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r526260184 ## File path: clients/src/main/resources/common/message/ProduceRequest.json ## @@ -33,21 +33,21 @@ "validVersions": "0-8", "flexibleVersions": "none

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9539: KAFKA-10634: Adding LeaderId to Voters list in LeaderChangeMessage

vamossagar12 commented on a change in pull request #9539: URL: https://github.com/apache/kafka/pull/9539#discussion_r526264880 ## File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java ## @@ -709,6 +709,9 @@ static void verifyLeaderChangeMessage(

[GitHub] [kafka] lbradstreet commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

lbradstreet commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r526265466 ## File path: core/src/main/scala/kafka/network/RequestConvertToJson.scala ## @@ -0,0 +1,362 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] vamossagar12 commented on pull request #9539: KAFKA-10634: Adding LeaderId to Voters list in LeaderChangeMessage

vamossagar12 commented on pull request #9539: URL: https://github.com/apache/kafka/pull/9539#issuecomment-729826627 > Thanks for the patch. Left a few minor comments. Thanks @hachikuji , i have replied on the comments.. ---

[GitHub] [kafka] chia7712 commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

chia7712 commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r526280042 ## File path: clients/src/main/resources/common/message/ProduceRequest.json ## @@ -33,21 +33,21 @@ "validVersions": "0-8", "flexibleVersions": "none"

[GitHub] [kafka] hachikuji commented on a change in pull request #9547: KAFKA-9630; Replace OffsetsForLeaderEpoch request/response with automated protocol

hachikuji commented on a change in pull request #9547: URL: https://github.com/apache/kafka/pull/9547#discussion_r526281357 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsForLeaderEpochClient.java ## @@ -61,67 +77,76 @@ protected OffsetF

[GitHub] [kafka] chia7712 commented on a change in pull request #9516: MINOR: make Send and Receive work with TransportLayer rather than Gat…

chia7712 commented on a change in pull request #9516: URL: https://github.com/apache/kafka/pull/9516#discussion_r526282918 ## File path: clients/src/test/java/org/apache/kafka/common/network/TransportLayerUtils.java ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hachikuji commented on a change in pull request #9539: KAFKA-10634: Adding LeaderId to Voters list in LeaderChangeMessage

hachikuji commented on a change in pull request #9539: URL: https://github.com/apache/kafka/pull/9539#discussion_r526283540 ## File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java ## @@ -709,6 +709,9 @@ static void verifyLeaderChangeMessage( a

[GitHub] [kafka] hachikuji commented on a change in pull request #9547: KAFKA-9630; Replace OffsetsForLeaderEpoch request/response with automated protocol

hachikuji commented on a change in pull request #9547: URL: https://github.com/apache/kafka/pull/9547#discussion_r526287129 ## File path: clients/src/main/java/org/apache/kafka/common/requests/OffsetsForLeaderEpochRequest.java ## @@ -51,169 +47,120 @@ */ public stat

[GitHub] [kafka] chia7712 commented on a change in pull request #9547: KAFKA-9630; Replace OffsetsForLeaderEpoch request/response with automated protocol

chia7712 commented on a change in pull request #9547: URL: https://github.com/apache/kafka/pull/9547#discussion_r526301121 ## File path: clients/src/main/java/org/apache/kafka/common/requests/OffsetsForLeaderEpochRequest.java ## @@ -51,169 +47,120 @@ */ public stati

[GitHub] [kafka] hachikuji commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

hachikuji commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r526309208 ## File path: clients/src/main/resources/common/message/ProduceRequest.json ## @@ -33,21 +33,21 @@ "validVersions": "0-8", "flexibleVersions": "none

[GitHub] [kafka] chia7712 commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

chia7712 commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r526314648 ## File path: clients/src/main/resources/common/message/ProduceRequest.json ## @@ -33,21 +33,21 @@ "validVersions": "0-8", "flexibleVersions": "none"

[GitHub] [kafka] lct45 opened a new pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

lct45 opened a new pull request #9614: URL: https://github.com/apache/kafka/pull/9614 Per [KIP-663](https://cwiki.apache.org/confluence/display/KAFKA/KIP-663%3A+API+to+Start+and+Shut+Down+Stream+Threads), adding a metric to record the failed streams threads over the life of a client.

[GitHub] [kafka] lct45 commented on pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

lct45 commented on pull request #9614: URL: https://github.com/apache/kafka/pull/9614#issuecomment-729864151 @wcarlson5 @cadonna for initial review This is an automated message from the Apache Git Service. To respond to the m

[jira] [Commented] (KAFKA-10734) Speedup the processing of LeaderAndIsr request

[ https://issues.apache.org/jira/browse/KAFKA-10734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234891#comment-17234891 ] Jun Rao commented on KAFKA-10734: - [~luwang], thanks for the jira. In practice, if n is

[GitHub] [kafka] hachikuji commented on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

hachikuji commented on pull request #9401: URL: https://github.com/apache/kafka/pull/9401#issuecomment-729870471 Great work @chia7712 ! With this and #9547, we have converted all of the protocols, which was a huge community effort! -

[jira] [Created] (KAFKA-10738) kafka version 2.5.0 on Windows Cygwin could not started when using openjdk or corretto 11

Duke Pham created KAFKA-10738: - Summary: kafka version 2.5.0 on Windows Cygwin could not started when using openjdk or corretto 11 Key: KAFKA-10738 URL: https://issues.apache.org/jira/browse/KAFKA-10738 P

[jira] [Updated] (KAFKA-10738) kafka version 2.5.0 on Windows Cygwin could not started when using openjdk or corretto 11

[ https://issues.apache.org/jira/browse/KAFKA-10738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duke Pham updated KAFKA-10738: -- Description: h5. kafka version 2.5.0 on Windows Cygwin could not started when using openjdk or corret

[jira] [Updated] (KAFKA-10738) kafka version 2.5.0 on Windows Cygwin could not started when using openjdk or corretto 11

[ https://issues.apache.org/jira/browse/KAFKA-10738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duke Pham updated KAFKA-10738: -- Description: h5. kafka version 2.5.0 on Windows Cygwin could not started when using openjdk or corret

[jira] [Updated] (KAFKA-10738) kafka version 2.5.0 on Windows Cygwin could not started when using openjdk or corretto 11

[ https://issues.apache.org/jira/browse/KAFKA-10738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duke Pham updated KAFKA-10738: -- Description: h5. kafka version 2.5.0 on Windows Cygwin could not started when using openjdk or corret

[GitHub] [kafka] lct45 commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

lct45 commented on a change in pull request #9614: URL: https://github.com/apache/kafka/pull/9614#discussion_r526331025 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java ## @@ -377,7 +378,7 @@ private void shouldAddMetricsOnAl

[GitHub] [kafka] wcarlson5 opened a new pull request #9615: KAFKA-10500: Add thread option

wcarlson5 opened a new pull request #9615: URL: https://github.com/apache/kafka/pull/9615 Can add stream threads now replace https://github.com/apache/kafka/pull/9581 after rebase ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

[GitHub] [kafka] wcarlson5 closed pull request #9581: KAFKA-10500: Add thread

wcarlson5 closed pull request #9581: URL: https://github.com/apache/kafka/pull/9581 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] wcarlson5 commented on pull request #9581: KAFKA-10500: Add thread

wcarlson5 commented on pull request #9581: URL: https://github.com/apache/kafka/pull/9581#issuecomment-729885913 Moved to https://github.com/apache/kafka/pull/9615 This is an automated message from the Apache Git Service. To

[GitHub] [kafka] gardnervickers removed a comment on pull request #9601: KAFKA-10729: Bump remaining RPC's to use tagged fields.

gardnervickers removed a comment on pull request #9601: URL: https://github.com/apache/kafka/pull/9601#issuecomment-729796082 I realize now that we have several requests which have not been converted to use the generated RPC's. It appears we need to do that to support tagged fields. ---

[GitHub] [kafka] gardnervickers commented on pull request #9601: KAFKA-10729: Bump remaining RPC's to use tagged fields.

gardnervickers commented on pull request #9601: URL: https://github.com/apache/kafka/pull/9601#issuecomment-729887376 OffsetForLeaderEpoch and Produce are not yet versioned RPCs, but will be once #9401 and #9547 are merged. I've removed the taggedFields bump for these RPC's. We can bump th

[GitHub] [kafka] gardnervickers edited a comment on pull request #9601: KAFKA-10729: Bump remaining RPC's to use tagged fields.

gardnervickers edited a comment on pull request #9601: URL: https://github.com/apache/kafka/pull/9601#issuecomment-729887376 OffsetForLeaderEpoch and Produce are not yet generated RPCs, but will be once #9401 and #9547 are merged. I've removed the taggedFields bump for these RPC's. We can

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

wcarlson5 commented on a change in pull request #9614: URL: https://github.com/apache/kafka/pull/9614#discussion_r526347359 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1070,6 +1070,10 @@ private Thread shutdownHelper(final boolean error

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

wcarlson5 commented on a change in pull request #9614: URL: https://github.com/apache/kafka/pull/9614#discussion_r526352796 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java ## @@ -377,7 +378,7 @@ private void shouldAddMetrics

[GitHub] [kafka] lct45 commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

lct45 commented on a change in pull request #9614: URL: https://github.com/apache/kafka/pull/9614#discussion_r526355838 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1070,6 +1070,10 @@ private Thread shutdownHelper(final boolean error) {

[GitHub] [kafka] apovzner commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

apovzner commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r526361289 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1324,7 +1401,59 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metri

[jira] [Commented] (KAFKA-10114) Kafka producer stuck after broker crash

[ https://issues.apache.org/jira/browse/KAFKA-10114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234954#comment-17234954 ] Kshitij Wadhwa commented on KAFKA-10114: We are still seeing this issue with ver

[GitHub] [kafka] vvcephei opened a new pull request #9616: POC: fix task idling

vvcephei opened a new pull request #9616: URL: https://github.com/apache/kafka/pull/9616 POC for: https://issues.apache.org/jira/browse/KAFKA-10091 https://cwiki.apache.org/confluence/x/JSXZCQ Please don't bother reviewing this. I did enough of the implementation to convi

[GitHub] [kafka] dajac commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

dajac commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r526368983 ## File path: clients/src/main/resources/common/message/ProduceRequest.json ## @@ -33,21 +33,21 @@ "validVersions": "0-8", "flexibleVersions": "none",

[jira] [Commented] (KAFKA-10091) Improve task idling

[ https://issues.apache.org/jira/browse/KAFKA-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234967#comment-17234967 ] John Roesler commented on KAFKA-10091: -- FYI to all watchers, I've begun to draft a

[GitHub] [kafka] dajac commented on a change in pull request #9547: KAFKA-9630; Replace OffsetsForLeaderEpoch request/response with automated protocol

dajac commented on a change in pull request #9547: URL: https://github.com/apache/kafka/pull/9547#discussion_r526373121 ## File path: clients/src/main/java/org/apache/kafka/common/requests/OffsetsForLeaderEpochRequest.java ## @@ -51,169 +47,120 @@ */ public static f

[GitHub] [kafka] dajac commented on a change in pull request #9547: KAFKA-9630; Replace OffsetsForLeaderEpoch request/response with automated protocol

dajac commented on a change in pull request #9547: URL: https://github.com/apache/kafka/pull/9547#discussion_r526373445 ## File path: clients/src/main/java/org/apache/kafka/common/requests/OffsetsForLeaderEpochResponse.java ## @@ -51,133 +41,82 @@ * - {@link Errors#UNKNOWN_S

[jira] [Created] (KAFKA-10739) KafkaApis#handleOffsetForLeaderEpochRequest should use OffsetForLeaderPartition directly

David Jacot created KAFKA-10739: --- Summary: KafkaApis#handleOffsetForLeaderEpochRequest should use OffsetForLeaderPartition directly Key: KAFKA-10739 URL: https://issues.apache.org/jira/browse/KAFKA-10739

[GitHub] [kafka] vvcephei commented on a change in pull request #9414: KAFKA-10585: Kafka Streams should clean up the state store directory from cleanup

vvcephei commented on a change in pull request #9414: URL: https://github.com/apache/kafka/pull/9414#discussion_r526377375 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EOSUncleanShutdownIntegrationTest.java ## @@ -140,9 +140,6 @@ public void should

[GitHub] [kafka] dajac commented on a change in pull request #9547: KAFKA-9630; Replace OffsetsForLeaderEpoch request/response with automated protocol

dajac commented on a change in pull request #9547: URL: https://github.com/apache/kafka/pull/9547#discussion_r526377753 ## File path: clients/src/main/java/org/apache/kafka/common/requests/OffsetsForLeaderEpochRequest.java ## @@ -51,169 +47,120 @@ */ public static f

[jira] [Created] (KAFKA-10740) ReplicaFetcherThread should use OffsetForLeaderPartitionResult directly

David Jacot created KAFKA-10740: --- Summary: ReplicaFetcherThread should use OffsetForLeaderPartitionResult directly Key: KAFKA-10740 URL: https://issues.apache.org/jira/browse/KAFKA-10740 Project: Kafka

[GitHub] [kafka] dajac commented on a change in pull request #9547: KAFKA-9630; Replace OffsetsForLeaderEpoch request/response with automated protocol

dajac commented on a change in pull request #9547: URL: https://github.com/apache/kafka/pull/9547#discussion_r526383138 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsForLeaderEpochClient.java ## @@ -61,67 +77,76 @@ protected OffsetForEp

[GitHub] [kafka] dajac commented on pull request #9547: KAFKA-9630; Replace OffsetsForLeaderEpoch request/response with automated protocol

dajac commented on pull request #9547: URL: https://github.com/apache/kafka/pull/9547#issuecomment-729926766 @chia7712 @hachikuji Thanks for your comments. I have addressed them. Could you have another quick look? This is an

[jira] [Created] (KAFKA-10741) Kafka ConsumerProperties.addDeserializerToConfig breaks hirarchical property resolution.

Michael created KAFKA-10741: --- Summary: Kafka ConsumerProperties.addDeserializerToConfig breaks hirarchical property resolution. Key: KAFKA-10741 URL: https://issues.apache.org/jira/browse/KAFKA-10741 Projec

[jira] [Created] (KAFKA-10742) Automated protocol should support java.util.Optional

David Jacot created KAFKA-10742: --- Summary: Automated protocol should support java.util.Optional Key: KAFKA-10742 URL: https://issues.apache.org/jira/browse/KAFKA-10742 Project: Kafka Issue Type

[jira] [Commented] (KAFKA-10741) Kafka ConsumerProperties.addDeserializerToConfig breaks hirarchical property resolution.

[ https://issues.apache.org/jira/browse/KAFKA-10741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234996#comment-17234996 ] Michael commented on KAFKA-10741: - I think, since in the transition from _ConsumerConfig

[jira] [Commented] (KAFKA-10114) Kafka producer stuck after broker crash

[ https://issues.apache.org/jira/browse/KAFKA-10114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234997#comment-17234997 ] Tim Fox commented on KAFKA-10114: - Hi Kshitij - can you get a stack dump for when this o

[GitHub] [kafka] hachikuji opened a new pull request #9617: MINOR: Factor out common response parsing logic

hachikuji opened a new pull request #9617: URL: https://github.com/apache/kafka/pull/9617 This patch factors out some common parsing logic from `NetworkClient.parseResponse` and `AbstractResponse.parseResponse`. As a result of this refactor, we are now verifying the correlationId in forwar

[GitHub] [kafka] mattwong949 commented on a change in pull request #9608: MINOR: Enable testLogCleanerStats

mattwong949 commented on a change in pull request #9608: URL: https://github.com/apache/kafka/pull/9608#discussion_r526412288 ## File path: core/src/test/scala/unit/kafka/log/LogCleanerTest.scala ## @@ -815,9 +815,10 @@ class LogCleanerTest { (0 until leo.toInt

[GitHub] [kafka] hachikuji commented on pull request #9617: MINOR: Factor out common response parsing logic

hachikuji commented on pull request #9617: URL: https://github.com/apache/kafka/pull/9617#issuecomment-729947146 This is a follow-up from #9563. cc @chia7712 @abbccdda While I was working on this patch, I noticed this: https://issues.apache.org/jira/browse/KAFKA-10743. In this patch

[jira] [Created] (KAFKA-10743) Fix NumRequestsForwardingToControllerPerSec metric in ForwardingManager

Jason Gustafson created KAFKA-10743: --- Summary: Fix NumRequestsForwardingToControllerPerSec metric in ForwardingManager Key: KAFKA-10743 URL: https://issues.apache.org/jira/browse/KAFKA-10743 Project

[GitHub] [kafka] mjsax opened a new pull request #9618: MINOR: change default TX timeout only if EOS is enabled

mjsax opened a new pull request #9618: URL: https://github.com/apache/kafka/pull/9618 Call for review @abbccdda This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] hachikuji merged pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

hachikuji merged pull request #9401: URL: https://github.com/apache/kafka/pull/9401 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (KAFKA-9628) Replace Produce request/response with automated protocol

[ https://issues.apache.org/jira/browse/KAFKA-9628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-9628. Fix Version/s: 2.8.0 Resolution: Fixed > Replace Produce request/response with autom

[GitHub] [kafka] bbejeck commented on pull request #9613: Cherry-pick KAFKA-10687 to 2.7

bbejeck commented on pull request #9613: URL: https://github.com/apache/kafka/pull/9613#issuecomment-729985015 Failure in Java 11 is unrelated and a known flaky test. This is an automated message from the Apache Git Service.

[GitHub] [kafka] bbejeck merged pull request #9613: Cherry-pick KAFKA-10687 to 2.7

bbejeck merged pull request #9613: URL: https://github.com/apache/kafka/pull/9613 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] bbejeck commented on pull request #9613: Cherry-pick KAFKA-10687 to 2.7

bbejeck commented on pull request #9613: URL: https://github.com/apache/kafka/pull/9613#issuecomment-729985753 merged #9613 into 2.7 This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Resolved] (KAFKA-10687) Produce request should be bumped for new error code PRODUCE_FENCED

[ https://issues.apache.org/jira/browse/KAFKA-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck resolved KAFKA-10687. - Resolution: Fixed Fixed for 2.7 via https://github.com/apache/kafka/pull/9613 > Produce request

[GitHub] [kafka] bbejeck commented on pull request #9613: Cherry-pick KAFKA-10687 to 2.7

bbejeck commented on pull request #9613: URL: https://github.com/apache/kafka/pull/9613#issuecomment-729986874 Thanks for the separate PR @abbccdda This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] hachikuji opened a new pull request #9619: MINOR: Reduce sends created by `SendBuilder`

hachikuji opened a new pull request #9619: URL: https://github.com/apache/kafka/pull/9619 In #9401, I observed some strange latency behavior when testing locally (on macos). The behavior seemed to be caused by slightly different write behavior as a result of the new `SendBuilder` class. Af

  1   2   >