lct45 commented on a change in pull request #9614:
URL: https://github.com/apache/kafka/pull/9614#discussion_r526331025
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java
##########
@@ -377,7 +378,7 @@ private void shouldAddMetricsOnAllLevels(final String
builtInMetricsVersion) thr
builtInMetricsVersion
);
checkCacheMetrics(builtInMetricsVersion);
-
+ verifyFailedStreamThreadsSensor(0.0);
Review comment:
We also need to verify that the metric works when there is a failed
stream thread. Options are (1) to create a custom processor now and (IIRC) run
the test suite twice, once with failing stream threads and once without to
confirm that the metric works. I'm not sure if the custom processor will let us
just fail one stream thread right before closing the app. Or (2) wait until
add/remove stream threads is implemented and remove threads and test the metric
after removing some threads before closing the app. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
