dajac commented on a change in pull request #9547:
URL: https://github.com/apache/kafka/pull/9547#discussion_r526207135
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsForLeaderEpochClient.java
##########
@@ -61,67 +77,76 @@ protected OffsetForEpochResult handleResponse(
Map<TopicPartition, SubscriptionState.FetchPosition> requestData,
OffsetsForLeaderEpochResponse response) {
+ Set<TopicPartition> missingPartitions = new
HashSet<>(requestData.keySet());
Review comment:
The downside of relying on `partitionsToRetry` is that we can't
differentiate the partitions to be retried due to an error from the missing
partitions in the response. It may not be that important but we can't preserve
the above log otherwise.
```
logger().warn("Missing partition {} from response, retrying.",
topicPartition);
```
I suppose that this log entry is there for a reason so I went with
preserving it. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
