vamossagar12 commented on a change in pull request #9539:
URL: https://github.com/apache/kafka/pull/9539#discussion_r526264880
##########
File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java
##########
@@ -709,6 +709,9 @@ static void verifyLeaderChangeMessage(
assertEquals(leaderId, leaderChangeMessage.leaderId());
assertEquals(voters.stream().map(voterId -> new
Voter().setVoterId(voterId)).collect(Collectors.toList()),
leaderChangeMessage.voters());
+ assertEquals(voters.stream().map(voterId -> new
Voter().setVoterId(voterId)).collect(Collectors.toSet()),
Review comment:
Yeah at least I couldn't find one. This method
`verifyLeaderChangeMessage` is invoked only from 2 methods, one being
`testInitializeAsCandidateAndBecomeLeader` and the other one is
`testLeaderAppendSingleMemberQuorum`. In both these, the full vote is granted.
Plz let me know if you want another test which takes care of the case where not
all votes are received.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
