[GitHub] [kafka] dajac commented on a change in pull request #9374: MINOR: Fix NPE in KafkaAdminClient.describeUserScramCredentials

2020-10-26 Thread GitBox
dajac commented on a change in pull request #9374: URL: https://github.com/apache/kafka/pull/9374#discussion_r511746730 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4166,10 +4167,22 @@ public DescribeUserScramCredentialsResult

[GitHub] [kafka] chia7712 opened a new pull request #9501: MINOR: move the test cases which don't need brokers from TopicCommand…

2020-10-26 Thread GitBox
chia7712 opened a new pull request #9501: URL: https://github.com/apache/kafka/pull/9501 This patch can reduce the elapsed time of testing ```TopicCommandWithAdminClientTest``` (5m19s -> 4m18s on my local) ### Committer Checklist (excluded from commit message) - [ ] Verify des

[GitHub] [kafka] Fleshgrinder commented on a change in pull request #9374: MINOR: Fix NPE in KafkaAdminClient.describeUserScramCredentials

2020-10-26 Thread GitBox
Fleshgrinder commented on a change in pull request #9374: URL: https://github.com/apache/kafka/pull/9374#discussion_r511771687 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -4505,50 +4505,57 @@ public void testDescribeUserSc

[GitHub] [kafka] Fleshgrinder commented on a change in pull request #9374: MINOR: Fix NPE in KafkaAdminClient.describeUserScramCredentials

2020-10-26 Thread GitBox
Fleshgrinder commented on a change in pull request #9374: URL: https://github.com/apache/kafka/pull/9374#discussion_r511774755 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4166,10 +4167,22 @@ public DescribeUserScramCredential

[GitHub] [kafka] Fleshgrinder commented on a change in pull request #9374: MINOR: Fix NPE in KafkaAdminClient.describeUserScramCredentials

2020-10-26 Thread GitBox
Fleshgrinder commented on a change in pull request #9374: URL: https://github.com/apache/kafka/pull/9374#discussion_r511774755 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4166,10 +4167,22 @@ public DescribeUserScramCredential

[GitHub] [kafka] chia7712 opened a new pull request #9502: MINOR: mark StandbyTaskEOSIntegrationTest as an IntegrationTest

2020-10-26 Thread GitBox
chia7712 opened a new pull request #9502: URL: https://github.com/apache/kafka/pull/9502 ```StandbyTaskEOSIntegrationTest ```instantiates a ```EmbeddedKafkaCluster``` so it should be an ```IntegrationTest```. ### Committer Checklist (excluded from commit message) - [ ] Verify desi

[GitHub] [kafka] dajac commented on a change in pull request #9374: MINOR: Fix NPE in KafkaAdminClient.describeUserScramCredentials

2020-10-26 Thread GitBox
dajac commented on a change in pull request #9374: URL: https://github.com/apache/kafka/pull/9374#discussion_r511800360 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -4505,50 +4505,57 @@ public void testDescribeUserScramCred

[GitHub] [kafka] dajac commented on a change in pull request #9374: MINOR: Fix NPE in KafkaAdminClient.describeUserScramCredentials

2020-10-26 Thread GitBox
dajac commented on a change in pull request #9374: URL: https://github.com/apache/kafka/pull/9374#discussion_r511804502 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4166,10 +4167,22 @@ public DescribeUserScramCredentialsResult

[GitHub] [kafka] Fleshgrinder commented on a change in pull request #9374: MINOR: Fix NPE in KafkaAdminClient.describeUserScramCredentials

2020-10-26 Thread GitBox
Fleshgrinder commented on a change in pull request #9374: URL: https://github.com/apache/kafka/pull/9374#discussion_r511806251 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -4505,50 +4505,57 @@ public void testDescribeUserSc

[GitHub] [kafka] Fleshgrinder commented on a change in pull request #9374: MINOR: Fix NPE in KafkaAdminClient.describeUserScramCredentials

2020-10-26 Thread GitBox
Fleshgrinder commented on a change in pull request #9374: URL: https://github.com/apache/kafka/pull/9374#discussion_r511810517 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4166,10 +4167,22 @@ public DescribeUserScramCredential

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9418: KAFKA-10601; Add support for append linger to Raft implementation

2020-10-26 Thread GitBox
rajinisivaram commented on a change in pull request #9418: URL: https://github.com/apache/kafka/pull/9418#discussion_r511842783 ## File path: core/src/main/scala/kafka/common/RecordValidationException.scala ## @@ -23,5 +23,6 @@ import org.apache.kafka.common.requests.ProduceRe

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9103: KAFKA-10181: Use Envelope RPC to do redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-10-26 Thread GitBox
rajinisivaram commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r511872018 ## File path: core/src/main/scala/kafka/network/RequestChannel.scala ## @@ -94,19 +104,63 @@ object RequestChannel extends Logging { @volatile va

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9473: KAFKA-10545: Create topic IDs in ZooKeeper and Controller

2020-10-26 Thread GitBox
rajinisivaram commented on a change in pull request #9473: URL: https://github.com/apache/kafka/pull/9473#discussion_r511882563 ## File path: core/src/main/scala/kafka/controller/ControllerContext.scala ## @@ -295,6 +316,10 @@ class ControllerContext { topicsToBeDeleted -=

[jira] [Assigned] (KAFKA-10644) Fix VotedToUnattached test error

2020-10-26 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming reassigned KAFKA-10644: -- Assignee: dengziming > Fix VotedToUnattached test error > >

[jira] [Created] (KAFKA-10644) Fix VotedToUnattached test error

2020-10-26 Thread dengziming (Jira)
dengziming created KAFKA-10644: -- Summary: Fix VotedToUnattached test error Key: KAFKA-10644 URL: https://issues.apache.org/jira/browse/KAFKA-10644 Project: Kafka Issue Type: Sub-task C

[GitHub] [kafka] dengziming opened a new pull request #9503: KAFKA-10644: Fix VotedToUnattached test error

2020-10-26 Thread GitBox
dengziming opened a new pull request #9503: URL: https://github.com/apache/kafka/pull/9503 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* The method name is

[GitHub] [kafka] dengziming commented on pull request #9503: KAFKA-10644: Fix VotedToUnattached test error

2020-10-26 Thread GitBox
dengziming commented on pull request #9503: URL: https://github.com/apache/kafka/pull/9503#issuecomment-716508314 @hachikuji ,Hi, PTAL. This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] dajac opened a new pull request #9504: MINOR; DescribeUserScramCredentialsRequest API should handle request with users equals to `null`

2020-10-26 Thread GitBox
dajac opened a new pull request #9504: URL: https://github.com/apache/kafka/pull/9504 DescribeUserScramCredentialsRequest states that all users are described when `Users` is empty or `null`. `null` is handled at the moment and throws an NPE. ### Committer Checklist (excluded from co

[GitHub] [kafka] dajac commented on pull request #9374: MINOR: Fix NPE in KafkaAdminClient.describeUserScramCredentials

2020-10-26 Thread GitBox
dajac commented on pull request #9374: URL: https://github.com/apache/kafka/pull/9374#issuecomment-716559206 FYI - I just opened a PR to fix the issue on the broker side: https://github.com/apache/kafka/pull/9504. This is an

[GitHub] [kafka] Fleshgrinder commented on a change in pull request #9374: MINOR: Fix NPE in KafkaAdminClient.describeUserScramCredentials

2020-10-26 Thread GitBox
Fleshgrinder commented on a change in pull request #9374: URL: https://github.com/apache/kafka/pull/9374#discussion_r511810517 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4166,10 +4167,22 @@ public DescribeUserScramCredential

[jira] [Created] (KAFKA-10645) Forwarding a record from a punctuator sometimes it results in a NullPointerException

2020-10-26 Thread Filippo Machi (Jira)
Filippo Machi created KAFKA-10645: - Summary: Forwarding a record from a punctuator sometimes it results in a NullPointerException Key: KAFKA-10645 URL: https://issues.apache.org/jira/browse/KAFKA-10645

[GitHub] [kafka] mumrah closed pull request #7265: Don't merge this, just testing something in the build

2020-10-26 Thread GitBox
mumrah closed pull request #7265: URL: https://github.com/apache/kafka/pull/7265 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mumrah commented on pull request #7265: Don't merge this, just testing something in the build

2020-10-26 Thread GitBox
mumrah commented on pull request #7265: URL: https://github.com/apache/kafka/pull/7265#issuecomment-716590142 @dajac yes, thanks for the ping on this. Closing This is an automated message from the Apache Git Service. To respo

[jira] [Updated] (KAFKA-10645) Forwarding a record from a punctuator sometimes it results in a NullPointerException

2020-10-26 Thread Filippo Machi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Filippo Machi updated KAFKA-10645: -- Description: Hello, I am working on a java kafka stream application (v. 2.5.0) running on a

[GitHub] [kafka] bbejeck commented on pull request #9486: KAFKA-9381: Fix releaseTarGz to publish valid scaladoc files

2020-10-26 Thread GitBox
bbejeck commented on pull request #9486: URL: https://github.com/apache/kafka/pull/9486#issuecomment-716607934 I was able to test this locally by setting the `mavenUrl` variable in `~/.gradle/gradle.properties` file to `/Users/bill/Downloads/testRepo/` on my laptop. Running the `u

[GitHub] [kafka] cmccabe commented on pull request #9504: MINOR; DescribeUserScramCredentialsRequest API should handle request with users equals to `null`

2020-10-26 Thread GitBox
cmccabe commented on pull request #9504: URL: https://github.com/apache/kafka/pull/9504#issuecomment-716610588 LGTM pending Jenkins. Thanks, @dajac . This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kafka] yuzawa-san commented on a change in pull request #9499: KAFKA-10470: Zstd upgrade and buffering

2020-10-26 Thread GitBox
yuzawa-san commented on a change in pull request #9499: URL: https://github.com/apache/kafka/pull/9499#discussion_r512045768 ## File path: clients/src/main/java/org/apache/kafka/common/record/CompressionType.java ## @@ -119,7 +119,9 @@ public InputStream wrapForInput(ByteBuffe

[GitHub] [kafka] yuzawa-san commented on pull request #9499: KAFKA-10470: Zstd upgrade and buffering

2020-10-26 Thread GitBox
yuzawa-san commented on pull request #9499: URL: https://github.com/apache/kafka/pull/9499#issuecomment-716620712 @chia7712 @ijuma The main reason I'm holding off using the BufferSupplier is because of part of the "after" benchmark looks like "before" benchmark: ``` Benchmark

[GitHub] [kafka] ijuma commented on pull request #9486: KAFKA-9381: Fix publishing valid scaladoc for streams-scala

2020-10-26 Thread GitBox
ijuma commented on pull request #9486: URL: https://github.com/apache/kafka/pull/9486#issuecomment-716623972 What's in the following two files? ```text -rw-r--r-- 1 bill staff 9585 Oct 26 10:47 ./org/apache/kafka/kafka_2.12/2.8.0-SNAPSHOT/kafka_2.12-2.8.0-20201026.144723-1-s

[GitHub] [kafka] ijuma commented on a change in pull request #9499: KAFKA-10470: Zstd upgrade and buffering

2020-10-26 Thread GitBox
ijuma commented on a change in pull request #9499: URL: https://github.com/apache/kafka/pull/9499#discussion_r512054037 ## File path: gradle/dependencies.gradle ## @@ -116,7 +116,7 @@ versions += [ testRetryPlugin: "1.1.6", zinc: "1.3.5", zookeeper: "3.5.8", - zstd: "

[GitHub] [kafka] bbejeck commented on pull request #9486: KAFKA-9381: Fix publishing valid scaladoc for streams-scala

2020-10-26 Thread GitBox
bbejeck commented on pull request #9486: URL: https://github.com/apache/kafka/pull/9486#issuecomment-716627691 > What's in the following two files? Just the manifest and the license ``` jar tf ./org/apache/kafka/kafka_2.13/2.8.0-SNAPSHOT/kafka_2.13-2.8.0-20201026.145017-1-

[GitHub] [kafka] jolshan commented on a change in pull request #9473: KAFKA-10545: Create topic IDs in ZooKeeper and Controller

2020-10-26 Thread GitBox
jolshan commented on a change in pull request #9473: URL: https://github.com/apache/kafka/pull/9473#discussion_r512054701 ## File path: core/src/main/scala/kafka/controller/ControllerContext.scala ## @@ -126,6 +130,23 @@ class ControllerContext { replicaStates.clear() }

[GitHub] [kafka] ijuma commented on a change in pull request #9499: KAFKA-10470: Zstd upgrade and buffering

2020-10-26 Thread GitBox
ijuma commented on a change in pull request #9499: URL: https://github.com/apache/kafka/pull/9499#discussion_r512056003 ## File path: gradle/dependencies.gradle ## @@ -116,7 +116,7 @@ versions += [ testRetryPlugin: "1.1.6", zinc: "1.3.5", zookeeper: "3.5.8", - zstd: "

[GitHub] [kafka] jolshan commented on a change in pull request #9473: KAFKA-10545: Create topic IDs in ZooKeeper and Controller

2020-10-26 Thread GitBox
jolshan commented on a change in pull request #9473: URL: https://github.com/apache/kafka/pull/9473#discussion_r512056578 ## File path: core/src/main/scala/kafka/zk/KafkaZkClient.scala ## @@ -481,43 +482,70 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient,

[GitHub] [kafka] jolshan commented on a change in pull request #9473: KAFKA-10545: Create topic IDs in ZooKeeper and Controller

2020-10-26 Thread GitBox
jolshan commented on a change in pull request #9473: URL: https://github.com/apache/kafka/pull/9473#discussion_r512068125 ## File path: core/src/main/scala/kafka/zk/KafkaZkClient.scala ## @@ -577,6 +605,27 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient, i

[GitHub] [kafka] jolshan commented on a change in pull request #9473: KAFKA-10545: Create topic IDs in ZooKeeper and Controller

2020-10-26 Thread GitBox
jolshan commented on a change in pull request #9473: URL: https://github.com/apache/kafka/pull/9473#discussion_r512069339 ## File path: core/src/main/scala/kafka/zk/KafkaZkClient.scala ## @@ -616,7 +683,7 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient, is

[GitHub] [kafka] bbejeck commented on pull request #9486: KAFKA-9381: Fix publishing valid scaladoc for streams-scala

2020-10-26 Thread GitBox
bbejeck commented on pull request #9486: URL: https://github.com/apache/kafka/pull/9486#issuecomment-716650023 @ijuma This latest change gets us where I think want to be. Using the same test procedure from before, we only have scaladoc files for streams-scala ```

[GitHub] [kafka] jolshan commented on a change in pull request #9473: KAFKA-10545: Create topic IDs in ZooKeeper and Controller

2020-10-26 Thread GitBox
jolshan commented on a change in pull request #9473: URL: https://github.com/apache/kafka/pull/9473#discussion_r512081744 ## File path: core/src/main/scala/kafka/controller/ControllerContext.scala ## @@ -295,6 +316,10 @@ class ControllerContext { topicsToBeDeleted -= topic

[GitHub] [kafka] bbejeck edited a comment on pull request #9486: KAFKA-9381: Fix publishing valid scaladoc for streams-scala

2020-10-26 Thread GitBox
bbejeck edited a comment on pull request #9486: URL: https://github.com/apache/kafka/pull/9486#issuecomment-716627691 > What's in the following two files? Just the manifest and the license ``` jar tf ./org/apache/kafka/kafka_2.13/2.8.0-SNAPSHOT/kafka_2.13-2.8.0-20201026.14

[GitHub] [kafka] bbejeck edited a comment on pull request #9486: KAFKA-9381: Fix publishing valid scaladoc for streams-scala

2020-10-26 Thread GitBox
bbejeck edited a comment on pull request #9486: URL: https://github.com/apache/kafka/pull/9486#issuecomment-716650023 @ijuma This latest change gets us where I think we want to be. Using the same test procedure from before, we only have scaladoc files for streams-scala.

[GitHub] [kafka] dajac commented on pull request #9374: MINOR: Fix NPE in KafkaAdminClient.describeUserScramCredentials

2020-10-26 Thread GitBox
dajac commented on pull request #9374: URL: https://github.com/apache/kafka/pull/9374#issuecomment-716659252 Test failures not related. Merging to trunk and 2.7. This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] dajac merged pull request #9374: MINOR: Fix NPE in KafkaAdminClient.describeUserScramCredentials

2020-10-26 Thread GitBox
dajac merged pull request #9374: URL: https://github.com/apache/kafka/pull/9374 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] dajac commented on pull request #9504: MINOR; DescribeUserScramCredentialsRequest API should handle request with users equals to `null`

2020-10-26 Thread GitBox
dajac commented on pull request #9504: URL: https://github.com/apache/kafka/pull/9504#issuecomment-716664276 Test failures not related. Merging to trunk and 2.7. This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] dajac merged pull request #9504: MINOR; DescribeUserScramCredentialsRequest API should handle request with users equals to `null`

2020-10-26 Thread GitBox
dajac merged pull request #9504: URL: https://github.com/apache/kafka/pull/9504 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] jsancio opened a new pull request #9505: KAFKA-10393: messages for fetch snapshot and fetch

2020-10-26 Thread GitBox
jsancio opened a new pull request #9505: URL: https://github.com/apache/kafka/pull/9505 Adds the changes to Fetch and FetchSnapshot as describe in KIP-630. *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so

[GitHub] [kafka] ijuma commented on a change in pull request #9486: KAFKA-9381: Fix publishing valid scaladoc for streams-scala

2020-10-26 Thread GitBox
ijuma commented on a change in pull request #9486: URL: https://github.com/apache/kafka/pull/9486#discussion_r512140251 ## File path: build.gradle ## @@ -731,6 +728,9 @@ project(':core') { println "Building project 'core' with Scala version ${versions.scala}" apply plug

[jira] [Commented] (KAFKA-10645) Forwarding a record from a punctuator sometimes it results in a NullPointerException

2020-10-26 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220853#comment-17220853 ] Matthias J. Sax commented on KAFKA-10645: - `null` headers are actually not allow

[GitHub] [kafka] bbejeck commented on a change in pull request #9486: KAFKA-9381: Fix publishing valid scaladoc for streams-scala

2020-10-26 Thread GitBox
bbejeck commented on a change in pull request #9486: URL: https://github.com/apache/kafka/pull/9486#discussion_r512145762 ## File path: build.gradle ## @@ -731,6 +728,9 @@ project(':core') { println "Building project 'core' with Scala version ${versions.scala}" apply pl

[jira] [Created] (KAFKA-10646) Support dynamic config for "delete.topic.enable"

2020-10-26 Thread Prateek Agarwal (Jira)
Prateek Agarwal created KAFKA-10646: --- Summary: Support dynamic config for "delete.topic.enable" Key: KAFKA-10646 URL: https://issues.apache.org/jira/browse/KAFKA-10646 Project: Kafka Issue

[jira] [Updated] (KAFKA-10646) Support dynamic config for "delete.topic.enable"

2020-10-26 Thread Prateek Agarwal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prateek Agarwal updated KAFKA-10646: Description: Topic deletion in Kafka removes data and the operation is not reversible (i.e

[jira] [Updated] (KAFKA-10646) Support dynamic config for "delete.topic.enable"

2020-10-26 Thread Prateek Agarwal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prateek Agarwal updated KAFKA-10646: Description: Topic deletion in Kafka removes data and the operation is not reversible (i.e

[GitHub] [kafka] bbejeck commented on pull request #9486: KAFKA-9381: Fix publishing valid scaladoc for streams-scala

2020-10-26 Thread GitBox
bbejeck commented on pull request #9486: URL: https://github.com/apache/kafka/pull/9486#issuecomment-716723668 updated this \cc @ijuma This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Assigned] (KAFKA-10646) Support dynamic config for "delete.topic.enable"

2020-10-26 Thread Harsha (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsha reassigned KAFKA-10646: -- Assignee: Harsha > Support dynamic config for "delete.topic.enable" > ---

[jira] [Updated] (KAFKA-10635) Streams application fails with OutOfOrderSequenceException after rolling restarts of brokers

2020-10-26 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-10635: -- Component/s: (was: streams) producer core > Streams app

[GitHub] [kafka] ijuma commented on a change in pull request #9486: KAFKA-9381: Fix publishing valid scaladoc for streams-scala

2020-10-26 Thread GitBox
ijuma commented on a change in pull request #9486: URL: https://github.com/apache/kafka/pull/9486#discussion_r512178349 ## File path: build.gradle ## @@ -731,6 +728,9 @@ project(':core') { println "Building project 'core' with Scala version ${versions.scala}" apply plug

[GitHub] [kafka] hachikuji commented on a change in pull request #9418: KAFKA-10601; Add support for append linger to Raft implementation

2020-10-26 Thread GitBox
hachikuji commented on a change in pull request #9418: URL: https://github.com/apache/kafka/pull/9418#discussion_r512189731 ## File path: core/src/main/scala/kafka/raft/KafkaNetworkChannel.scala ## @@ -216,11 +216,9 @@ class KafkaNetworkChannel(time: Time, endpoints.put(id

[GitHub] [kafka] jsancio commented on a change in pull request #9418: KAFKA-10601; Add support for append linger to Raft implementation

2020-10-26 Thread GitBox
jsancio commented on a change in pull request #9418: URL: https://github.com/apache/kafka/pull/9418#discussion_r512195616 ## File path: core/src/main/scala/kafka/raft/KafkaNetworkChannel.scala ## @@ -216,11 +216,9 @@ class KafkaNetworkChannel(time: Time, endpoints.put(id,

[GitHub] [kafka] hachikuji commented on a change in pull request #9418: KAFKA-10601; Add support for append linger to Raft implementation

2020-10-26 Thread GitBox
hachikuji commented on a change in pull request #9418: URL: https://github.com/apache/kafka/pull/9418#discussion_r512196964 ## File path: core/src/main/scala/kafka/raft/KafkaNetworkChannel.scala ## @@ -216,11 +216,9 @@ class KafkaNetworkChannel(time: Time, endpoints.put(id

[GitHub] [kafka] jsancio commented on a change in pull request #9418: KAFKA-10601; Add support for append linger to Raft implementation

2020-10-26 Thread GitBox
jsancio commented on a change in pull request #9418: URL: https://github.com/apache/kafka/pull/9418#discussion_r512195616 ## File path: core/src/main/scala/kafka/raft/KafkaNetworkChannel.scala ## @@ -216,11 +216,9 @@ class KafkaNetworkChannel(time: Time, endpoints.put(id,

[GitHub] [kafka] hachikuji commented on a change in pull request #9418: KAFKA-10601; Add support for append linger to Raft implementation

2020-10-26 Thread GitBox
hachikuji commented on a change in pull request #9418: URL: https://github.com/apache/kafka/pull/9418#discussion_r512217218 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] hachikuji commented on a change in pull request #9418: KAFKA-10601; Add support for append linger to Raft implementation

2020-10-26 Thread GitBox
hachikuji commented on a change in pull request #9418: URL: https://github.com/apache/kafka/pull/9418#discussion_r512224767 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchBuilder.java ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] bbejeck commented on a change in pull request #9486: KAFKA-9381: Fix publishing valid scaladoc for streams-scala

2020-10-26 Thread GitBox
bbejeck commented on a change in pull request #9486: URL: https://github.com/apache/kafka/pull/9486#discussion_r512231724 ## File path: build.gradle ## @@ -731,6 +728,9 @@ project(':core') { println "Building project 'core' with Scala version ${versions.scala}" apply pl

[GitHub] [kafka] bbejeck commented on pull request #9486: KAFKA-9381: Fix publishing valid scaladoc for streams-scala

2020-10-26 Thread GitBox
bbejeck commented on pull request #9486: URL: https://github.com/apache/kafka/pull/9486#issuecomment-716789180 updated this PR \cc @ijuma This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [kafka] ijuma commented on a change in pull request #9486: KAFKA-9381: Fix publishing valid scaladoc for streams-scala

2020-10-26 Thread GitBox
ijuma commented on a change in pull request #9486: URL: https://github.com/apache/kafka/pull/9486#discussion_r512244515 ## File path: build.gradle ## @@ -731,6 +728,9 @@ project(':core') { println "Building project 'core' with Scala version ${versions.scala}" apply plug

[jira] [Created] (KAFKA-10647) Only serialize owned partition when consumer protocol version >= 0

2020-10-26 Thread David Jacot (Jira)
David Jacot created KAFKA-10647: --- Summary: Only serialize owned partition when consumer protocol version >= 0 Key: KAFKA-10647 URL: https://issues.apache.org/jira/browse/KAFKA-10647 Project: Kafka

[GitHub] [kafka] dajac opened a new pull request #9506: KAFKA-10647; Only serialize owned partition when consumer protocol version >= 0

2020-10-26 Thread GitBox
dajac opened a new pull request #9506: URL: https://github.com/apache/kafka/pull/9506 A regression got introduced by https://github.com/apache/kafka/pull/8897. The owned partition field must be ignored for version < 1 otherwise the serialization fails with an unsupported version exception.

[jira] [Updated] (KAFKA-10647) Only serialize owned partition when consumer protocol version >= 0

2020-10-26 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-10647: Priority: Blocker (was: Major) > Only serialize owned partition when consumer protocol version >=

[jira] [Closed] (KAFKA-10597) Still dealing issue with KAFKA-9066

2020-10-26 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton closed KAFKA-10597. - > Still dealing issue with KAFKA-9066 > --- > > Key:

[jira] [Updated] (KAFKA-10647) Only serialize owned partition when consumer protocol version >= 0

2020-10-26 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-10647: Fix Version/s: 2.7.0 > Only serialize owned partition when consumer protocol version >= 0 > -

[GitHub] [kafka] guozhangwang merged pull request #9464: KAFKA-10616: Always call prepare-commit before suspending for active tasks

2020-10-26 Thread GitBox
guozhangwang merged pull request #9464: URL: https://github.com/apache/kafka/pull/9464 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] guozhangwang commented on pull request #9464: KAFKA-10616: Always call prepare-commit before suspending for active tasks

2020-10-26 Thread GitBox
guozhangwang commented on pull request #9464: URL: https://github.com/apache/kafka/pull/9464#issuecomment-716859719 Cherry-picked to 2.7, cc @bbejeck This is an automated message from the Apache Git Service. To respond to th

[jira] [Resolved] (KAFKA-10616) StreamThread killed by "IllegalStateException: The processor is already closed"

2020-10-26 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-10616. --- Resolution: Fixed > StreamThread killed by "IllegalStateException: The processor is already

[GitHub] [kafka] junrao commented on a change in pull request #9364: KAFKA-10471 Mark broker crash during log loading as unclean shutdown

2020-10-26 Thread GitBox
junrao commented on a change in pull request #9364: URL: https://github.com/apache/kafka/pull/9364#discussion_r512317288 ## File path: core/src/test/scala/unit/kafka/log/LogTest.scala ## @@ -978,10 +1051,10 @@ class LogTest { producerIdExpirationCheckIntervalMs = 3,

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331 add a streams handler

2020-10-26 Thread GitBox
wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r512320447 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -659,7 +727,6 @@ private KafkaStreams(final InternalTopologyBuilder

[GitHub] [kafka] senthilm-ms commented on pull request #9495: KAFKA-10642: Expose the real stack trace if any exception occurred during SSL Client Trust Verification in extension

2020-10-26 Thread GitBox
senthilm-ms commented on pull request #9495: URL: https://github.com/apache/kafka/pull/9495#issuecomment-716884640 > @senthilm-ms : Thanks for the PR. When we log an exception, the cause of the exception is logged too, right? Yes, however as it is rethrowing new exception with generi

[GitHub] [kafka] hachikuji commented on a change in pull request #9506: KAFKA-10647; Only serialize owned partitions when consumer protocol version >= 1

2020-10-26 Thread GitBox
hachikuji commented on a change in pull request #9506: URL: https://github.com/apache/kafka/pull/9506#discussion_r512344373 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerProtocolTest.java ## @@ -46,6 +46,30 @@ private final TopicP

[jira] [Updated] (KAFKA-10642) Expose the real stack trace if any exception occurred during SSL Client Trust Verification in extension

2020-10-26 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-10642: Fix Version/s: (was: 2.7.0) 2.8.0 > Expose the real stack trace if any exce

[jira] [Commented] (KAFKA-10642) Expose the real stack trace if any exception occurred during SSL Client Trust Verification in extension

2020-10-26 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221051#comment-17221051 ] Bill Bejeck commented on KAFKA-10642: - Hi [~senthilm-ms], since this is not a blocke

[jira] [Updated] (KAFKA-10641) ACL Command hangs with SSL as not existing with proper error code

2020-10-26 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-10641: Fix Version/s: (was: 2.7.0) 2.8.0 > ACL Command hangs with SSL as not exist

[jira] [Commented] (KAFKA-10641) ACL Command hangs with SSL as not existing with proper error code

2020-10-26 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221052#comment-17221052 ] Bill Bejeck commented on KAFKA-10641: - Hi [~senthilm-ms], since this is not a blocke

[GitHub] [kafka] bbejeck commented on pull request #9486: KAFKA-9381: Fix publishing valid scaladoc for streams-scala

2020-10-26 Thread GitBox
bbejeck commented on pull request #9486: URL: https://github.com/apache/kafka/pull/9486#issuecomment-716904467 test failure unrelated and is a known flaky test `org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]` ---

[GitHub] [kafka] bbejeck commented on pull request #9486: KAFKA-9381: Fix publishing valid scaladoc for streams-scala

2020-10-26 Thread GitBox
bbejeck commented on pull request #9486: URL: https://github.com/apache/kafka/pull/9486#issuecomment-716904890 Merged #9486 into trunk This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] bbejeck merged pull request #9486: KAFKA-9381: Fix publishing valid scaladoc for streams-scala

2020-10-26 Thread GitBox
bbejeck merged pull request #9486: URL: https://github.com/apache/kafka/pull/9486 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] bbejeck commented on pull request #9486: KAFKA-9381: Fix publishing valid scaladoc for streams-scala

2020-10-26 Thread GitBox
bbejeck commented on pull request #9486: URL: https://github.com/apache/kafka/pull/9486#issuecomment-716905485 cherry-picked to 2.7 This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Resolved] (KAFKA-9381) Javadocs + Scaladocs not published on maven central

2020-10-26 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck resolved KAFKA-9381. Resolution: Fixed Resolved via [https://github.com/apache/kafka/pull/9486.]   Merged to trunk and

[GitHub] [kafka] jiameixie commented on pull request #8446: KAFKA-9804:Extract consumer configs out of PerfConfig

2020-10-26 Thread GitBox
jiameixie commented on pull request #8446: URL: https://github.com/apache/kafka/pull/8446#issuecomment-716921348 Call for review @huxihx This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] chia7712 edited a comment on pull request #9499: KAFKA-10470: Zstd upgrade and buffering

2020-10-26 Thread GitBox
chia7712 edited a comment on pull request #9499: URL: https://github.com/apache/kafka/pull/9499#issuecomment-716935467 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kafka] chia7712 commented on pull request #9499: KAFKA-10470: Zstd upgrade and buffering

2020-10-26 Thread GitBox
chia7712 commented on pull request #9499: URL: https://github.com/apache/kafka/pull/9499#issuecomment-716935467 @yuzawa-san Thanks for great profile and explanation. I'm eager (too) to see this patch to be merged since it not only improves the memory usage but also brings better performanc

[GitHub] [kafka] guozhangwang commented on a change in pull request #9418: KAFKA-10601; Add support for append linger to Raft implementation

2020-10-26 Thread GitBox
guozhangwang commented on a change in pull request #9418: URL: https://github.com/apache/kafka/pull/9418#discussion_r512389580 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1605,100 +1708,18 @@ public void poll() throws IOException {

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9292: KAFKA-8238: adding number of messages/bytes read

2020-10-26 Thread GitBox
vamossagar12 commented on a change in pull request #9292: URL: https://github.com/apache/kafka/pull/9292#discussion_r512396470 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -670,12 +675,16 @@ class GroupMetadataManager(brokerId: Int

[GitHub] [kafka] guozhangwang commented on a change in pull request #9418: KAFKA-10601; Add support for append linger to Raft implementation

2020-10-26 Thread GitBox
guozhangwang commented on a change in pull request #9418: URL: https://github.com/apache/kafka/pull/9418#discussion_r512390308 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchBuilder.java ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] chia7712 commented on a change in pull request #9506: KAFKA-10647; Only serialize owned partitions when consumer protocol version >= 1

2020-10-26 Thread GitBox
chia7712 commented on a change in pull request #9506: URL: https://github.com/apache/kafka/pull/9506#discussion_r512397607 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerProtocolTest.java ## @@ -137,6 +161,19 @@ public void deserializeF

[jira] [Assigned] (KAFKA-10628) Follow-up: Remove all unnecessary dummy TopologyTestDriver configs

2020-10-26 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-10628: - Assignee: Luke Chen > Follow-up: Remove all unnecessary dummy TopologyTestDriver configs >

[jira] [Commented] (KAFKA-7870) Error sending fetch request (sessionId=1578860481, epoch=INITIAL) to node 2: java.io.IOException: Connection to 2 was disconnected before the response was read.

2020-10-26 Thread Leonardo Vasconcellos (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221144#comment-17221144 ] Leonardo Vasconcellos commented on KAFKA-7870: -- Same thing here.  2020-10-2

[GitHub] [kafka] showuon opened a new pull request #9507: KAFKA-10628: remove unneeded javadoc for TopologyTestDriver and some refactor

2020-10-26 Thread GitBox
showuon opened a new pull request #9507: URL: https://github.com/apache/kafka/pull/9507 1. remove unneeded javadoc content. 2. Replace containsKey/setProperty with `putIfAbsent` (good refactor) 3. refactor the constructor of `TopologyTestDriverTest` ### Committer Checklist (excl

[GitHub] [kafka] showuon commented on pull request #9507: KAFKA-10628: remove unneeded javadoc for TopologyTestDriver and some refactor

2020-10-26 Thread GitBox
showuon commented on pull request #9507: URL: https://github.com/apache/kafka/pull/9507#issuecomment-716985696 @chia7712 @vvcephei , could you review this PR? Thanks. This is an automated message from the Apache Git Service.

[jira] [Comment Edited] (KAFKA-7870) Error sending fetch request (sessionId=1578860481, epoch=INITIAL) to node 2: java.io.IOException: Connection to 2 was disconnected before the response was read.

2020-10-26 Thread Leonardo Vasconcellos (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221144#comment-17221144 ] Leonardo Vasconcellos edited comment on KAFKA-7870 at 10/27/20, 5:10 AM: --

[jira] [Comment Edited] (KAFKA-7870) Error sending fetch request (sessionId=1578860481, epoch=INITIAL) to node 2: java.io.IOException: Connection to 2 was disconnected before the response was read.

2020-10-26 Thread Leonardo Vasconcellos (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221144#comment-17221144 ] Leonardo Vasconcellos edited comment on KAFKA-7870 at 10/27/20, 5:13 AM: --

[jira] [Created] (KAFKA-10648) Add Prefix Scan support to State Stores

2020-10-26 Thread Sagar Rao (Jira)
Sagar Rao created KAFKA-10648: - Summary: Add Prefix Scan support to State Stores Key: KAFKA-10648 URL: https://issues.apache.org/jira/browse/KAFKA-10648 Project: Kafka Issue Type: Improvement

[jira] [Comment Edited] (KAFKA-7870) Error sending fetch request (sessionId=1578860481, epoch=INITIAL) to node 2: java.io.IOException: Connection to 2 was disconnected before the response was read.

2020-10-26 Thread Leonardo Vasconcellos (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221144#comment-17221144 ] Leonardo Vasconcellos edited comment on KAFKA-7870 at 10/27/20, 5:17 AM: --

  1   2   >