bbejeck commented on pull request #9486: URL: https://github.com/apache/kafka/pull/9486#issuecomment-716607934
I was able to test this locally by setting the `mavenUrl` variable in `~/.gradle/gradle.properties` file to `/Users/bill/Downloads/testRepo/` on my laptop. Running the `uploadArchives` task locally produced these scaladoc jar files. ``` find . -name '*scaladoc.jar' | xargs ls -la -rw-r--r-- 1 bill staff 1334323 Oct 26 10:48 ./org/apache/kafka/kafka-streams-scala_2.12/2.8.0-SNAPSHOT/kafka-streams-scala_2.12-2.8.0-20201026.144817-1-scaladoc.jar -rw-r--r-- 1 bill staff 1326180 Oct 26 10:50 ./org/apache/kafka/kafka-streams-scala_2.13/2.8.0-SNAPSHOT/kafka-streams-scala_2.13-2.8.0-20201026.145048-1-scaladoc.jar -rw-r--r-- 1 bill staff 9585 Oct 26 10:47 ./org/apache/kafka/kafka_2.12/2.8.0-SNAPSHOT/kafka_2.12-2.8.0-20201026.144723-1-scaladoc.jar -rw-r--r-- 1 bill staff 9585 Oct 26 10:50 ./org/apache/kafka/kafka_2.13/2.8.0-SNAPSHOT/kafka_2.13-2.8.0-20201026.145017-1-scaladoc.jar ``` So the changes in this PR will produce a valid scaladoc jar file `streams-scala`, which has a public Scala API, but not for core, which is what we want. So I think this PR is good now. ping @ijuma, @mjsax for another review ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
