bbejeck commented on a change in pull request #9486:
URL: https://github.com/apache/kafka/pull/9486#discussion_r512145762



##########
File path: build.gradle
##########
@@ -731,6 +728,9 @@ project(':core') {
   println "Building project 'core' with Scala version ${versions.scala}"
 
   apply plugin: 'scala'
+  scaladoc {
+      enabled = false
+  }

Review comment:
       >Do we still need this with your latest change?
   
   I thought about taking it out, but I left it in as a fail-safe, thinking 
that if the build file changes somehow enabling scaladoc for all submodules, 
`core` will only provide the scaladoc jar file with the license and manifest.
   
   I don't have a strong opinion on this, so I can remove if you want me to.
   
   Ack on the indenting




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to