hachikuji commented on a change in pull request #9418: URL: https://github.com/apache/kafka/pull/9418#discussion_r512196964
########## File path: core/src/main/scala/kafka/raft/KafkaNetworkChannel.scala ########## @@ -216,11 +216,9 @@ class KafkaNetworkChannel(time: Time, endpoints.put(id, node) } - def postInboundRequest(header: RequestHeader, - request: AbstractRequest, - onResponseReceived: ResponseHandler): Unit = { + def postInboundRequest(request: AbstractRequest, onResponseReceived: ResponseHandler): Unit = { Review comment: My mistake. This _was_ being used for both inbound requests and responses. Let me change the name and add some docs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org