[GitHub] [kafka] chia7712 commented on pull request #9262: MINOR: Fix log message when tasks directory is cleaned manually

2020-09-23 Thread GitBox
chia7712 commented on pull request #9262: URL: https://github.com/apache/kafka/pull/9262#issuecomment-697177819 @cadonna ``` org.apache.kafka.streams.processor.internals.StateDirectoryTest.shouldLogStateDirCleanerMessage failed, log available in /home/chia7712/kafka/streams/bui

[jira] [Commented] (KAFKA-10514) failed test StateDirectoryTest.shouldLogStateDirCleanerMessage

2020-09-23 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200617#comment-17200617 ] Chia-Ping Tsai commented on KAFKA-10514: more details: https://github.com/apache

[jira] [Assigned] (KAFKA-10514) failed test StateDirectoryTest.shouldLogStateDirCleanerMessage

2020-09-23 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reassigned KAFKA-10514: - Assignee: Bruno Cadonna > failed test StateDirectoryTest.shouldLogStateDirCleanerMessag

[jira] [Commented] (KAFKA-10514) failed test StateDirectoryTest.shouldLogStateDirCleanerMessage

2020-09-23 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200647#comment-17200647 ] Bruno Cadonna commented on KAFKA-10514: --- Thank you for catching this! This test se

[GitHub] [kafka] tombentley commented on pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-09-23 Thread GitBox
tombentley commented on pull request #9266: URL: https://github.com/apache/kafka/pull/9266#issuecomment-697220456 @ijuma sorry about that. Now fixed. This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-09-23 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-697223860 ``` Build / JDK 8 / org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true] ``` It is flaky on my local so it should b

[jira] [Created] (KAFKA-10515) NPE: Foreign key join serde may not be initialized with default serde if application is distributed

2020-09-23 Thread Thorsten Hake (Jira)
Thorsten Hake created KAFKA-10515: - Summary: NPE: Foreign key join serde may not be initialized with default serde if application is distributed Key: KAFKA-10515 URL: https://issues.apache.org/jira/browse/KAFKA-10

[GitHub] [kafka] cadonna opened a new pull request #9323: KAFKA-10514: Fix unit test for state directory cleanup

2020-09-23 Thread GitBox
cadonna opened a new pull request #9323: URL: https://github.com/apache/kafka/pull/9323 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] cadonna commented on pull request #9323: KAFKA-10514: Fix unit test for state directory cleanup

2020-09-23 Thread GitBox
cadonna commented on pull request #9323: URL: https://github.com/apache/kafka/pull/9323#issuecomment-697269502 Call for review: @chia7712 @vvcephei @mjsax @guozhangwang @abbccdda This is an automated message from the Apache

[GitHub] [kafka] chia7712 opened a new pull request #9324: MINOR: Install "iproute2" explicitly in Dockerfile

2020-09-23 Thread GitBox
chia7712 opened a new pull request #9324: URL: https://github.com/apache/kafka/pull/9324 this patch is similar to https://github.com/apache/kafka/commit/ee68b999c49cbbf514940a81282ff894e6cf50d9 the tool "iproute2" is required by ```round_trip_fault_test.py``` and it is not in openjd

[GitHub] [kafka] ankit-kumar-25 closed pull request #9314: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric

2020-09-23 Thread GitBox
ankit-kumar-25 closed pull request #9314: URL: https://github.com/apache/kafka/pull/9314 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [kafka] ankit-kumar-25 opened a new pull request #9325: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric

2020-09-23 Thread GitBox
ankit-kumar-25 opened a new pull request #9325: URL: https://github.com/apache/kafka/pull/9325 What? :: Mentioning "Request Queue Size" under Monitoring tab. RequestQueueSize is an important metric to monitor the number of requests in the queue. As a crowded queue might face issue processi

[GitHub] [kafka] nizhikov commented on pull request #9196: [DO NOT MERGE] KAFKA-10402: Upgrade system tests to python3

2020-09-23 Thread GitBox
nizhikov commented on pull request #9196: URL: https://github.com/apache/kafka/pull/9196#issuecomment-697300763 Hello, @guozhangwang Do you have system tests run results? Can you, please, show me it. This is an aut

[jira] [Commented] (KAFKA-8360) Docs do not mention RequestQueueSize JMX metric

2020-09-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200748#comment-17200748 ] ASF GitHub Bot commented on KAFKA-8360: --- ankit-kumar-25 closed pull request #220: U

[jira] [Commented] (KAFKA-8360) Docs do not mention RequestQueueSize JMX metric

2020-09-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200749#comment-17200749 ] ASF GitHub Bot commented on KAFKA-8360: --- ankit-kumar-25 edited a comment on pull re

[GitHub] [kafka] rajinisivaram merged pull request #9301: KAFKA-10482: Fix flaky testDynamicListenerConnectionCreationRateQuota

2020-09-23 Thread GitBox
rajinisivaram merged pull request #9301: URL: https://github.com/apache/kafka/pull/9301 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] edenhill commented on pull request #9196: [DO NOT MERGE] KAFKA-10402: Upgrade system tests to python3

2020-09-23 Thread GitBox
edenhill commented on pull request #9196: URL: https://github.com/apache/kafka/pull/9196#issuecomment-697307919 Excerpt from the Jenkins test run: ``` SESSION REPORT (ALL TESTS) ducktape version: 0.7.9 session_id: 2020-09-20--001 run time: 400 minutes 59.682 seco

[GitHub] [kafka] ankit-kumar-25 opened a new pull request #9326: KAFKA-10460: ReplicaListValidator format checking is incomplete

2020-09-23 Thread GitBox
ankit-kumar-25 opened a new pull request #9326: URL: https://github.com/apache/kafka/pull/9326 What? :: See https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/ConfigHandler.scala#L220 . The logic is supposed to accept only two cases: list of k:v pairs a s

[GitHub] [kafka] nizhikov commented on pull request #9196: [DO NOT MERGE] KAFKA-10402: Upgrade system tests to python3

2020-09-23 Thread GitBox
nizhikov commented on pull request #9196: URL: https://github.com/apache/kafka/pull/9196#issuecomment-697311299 > kafkatest.tests.streams.streams_static_membership_test.StreamsStaticMembershipTest.test_rolling_bounces_will_not_trigger_rebalance_under_static_membership > kafkatest.tests.

[GitHub] [kafka] nizhikov commented on pull request #9196: [DO NOT MERGE] KAFKA-10402: Upgrade system tests to python3

2020-09-23 Thread GitBox
nizhikov commented on pull request #9196: URL: https://github.com/apache/kafka/pull/9196#issuecomment-697311780 @edenhill > The IGNORED tests seems to be mostly kafkatest.tests.streams.streams_upgrade_test.StreamsUpgradeTest.test_upgrade_downgrade_brokers.. Are they ignored i

[jira] [Assigned] (KAFKA-10484) Reduce Metrics Exposed by Streams

2020-09-23 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reassigned KAFKA-10484: - Assignee: Bruno Cadonna > Reduce Metrics Exposed by Streams > -

[GitHub] [kafka] C0urante commented on pull request #8844: KAFKA-9887 fix failed task or connector count on startup failure

2020-09-23 Thread GitBox
C0urante commented on pull request #8844: URL: https://github.com/apache/kafka/pull/8844#issuecomment-697324142 Hi @michael-carter-instaclustr--unfortunately, it can take some time. Usually I tag @rhauch and @kkonstantine on GitHub since they're the committers that work most closely with t

[jira] [Created] (KAFKA-10516) Implement Topic Command changes

2020-09-23 Thread David Jacot (Jira)
David Jacot created KAFKA-10516: --- Summary: Implement Topic Command changes Key: KAFKA-10516 URL: https://issues.apache.org/jira/browse/KAFKA-10516 Project: Kafka Issue Type: Sub-task

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9103: KAFKA-10181: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-09-23 Thread GitBox
rajinisivaram commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r493520165 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -331,6 +334,50 @@ class DynamicBrokerConfig(private val kafkaConfig: K

[GitHub] [kafka] vvcephei commented on pull request #9323: KAFKA-10514: Fix unit test for state directory cleanup

2020-09-23 Thread GitBox
vvcephei commented on pull request #9323: URL: https://github.com/apache/kafka/pull/9323#issuecomment-697497868 Test failure was unrelated: ``` Build / JDK 11 / org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true] ``` ---

[GitHub] [kafka] vvcephei merged pull request #9323: KAFKA-10514: Fix unit test for state directory cleanup

2020-09-23 Thread GitBox
vvcephei merged pull request #9323: URL: https://github.com/apache/kafka/pull/9323 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 commented on pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-23 Thread GitBox
chia7712 commented on pull request #9318: URL: https://github.com/apache/kafka/pull/9318#issuecomment-697504023 rebase to fix conflicting This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] chia7712 commented on pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-09-23 Thread GitBox
chia7712 commented on pull request #9206: URL: https://github.com/apache/kafka/pull/9206#issuecomment-697508626 rebase to include the fixes of flaky. This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (KAFKA-8318) Session Window Aggregations generate an extra tombstone

2020-09-23 Thread Ilia Pasynkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200880#comment-17200880 ] Ilia Pasynkov commented on KAFKA-8318: -- Hello, can I pick this issue? > Session Win

[GitHub] [kafka] mumrah opened a new pull request #9327: Backport Jenkinsfile to 2.5

2020-09-23 Thread GitBox
mumrah opened a new pull request #9327: URL: https://github.com/apache/kafka/pull/9327 Add Jenkinsfile to 2.5 branch so we can use the PR builder job This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] mumrah opened a new pull request #9328: Minor: Add deleteDir for streams quickstart test

2020-09-23 Thread GitBox
mumrah opened a new pull request #9328: URL: https://github.com/apache/kafka/pull/9328 Add a `deleteDir` directive to the temporary dir we create during the streams/quickstart archetype test in the Jenkinsfile This is an aut

[GitHub] [kafka] viktorsomogyi commented on pull request #4090: [KAFKA-6084] Propagate JSON parsing errors in ReassignPartitionsCommand

2020-09-23 Thread GitBox
viktorsomogyi commented on pull request #4090: URL: https://github.com/apache/kafka/pull/4090#issuecomment-697538096 Rebased the PR This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] viktorsomogyi edited a comment on pull request #4090: [KAFKA-6084] Propagate JSON parsing errors in ReassignPartitionsCommand

2020-09-23 Thread GitBox
viktorsomogyi edited a comment on pull request #4090: URL: https://github.com/apache/kafka/pull/4090#issuecomment-697538096 Rebased the PR and addressed your comment This is an automated message from the Apache Git Service. T

[GitHub] [kafka] mumrah opened a new pull request #9329: Backport Jenkinsfile to 2.4 branch

2020-09-23 Thread GitBox
mumrah opened a new pull request #9329: URL: https://github.com/apache/kafka/pull/9329 This is a backport of the Jenkinsfile for 2.4 so we can use the PR builder job This is an automated message from the Apache Git Service.

[GitHub] [kafka] zhaohaidao commented on a change in pull request #9311: KAFKA-9910: Implement new transaction timed out error

2020-09-23 Thread GitBox
zhaohaidao commented on a change in pull request #9311: URL: https://github.com/apache/kafka/pull/9311#discussion_r493695444 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java ## @@ -1072,7 +1076,11 @@ private void transitio

[GitHub] [kafka] zhaohaidao commented on a change in pull request #9311: KAFKA-9910: Implement new transaction timed out error

2020-09-23 Thread GitBox
zhaohaidao commented on a change in pull request #9311: URL: https://github.com/apache/kafka/pull/9311#discussion_r493708455 ## File path: core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala ## @@ -381,24 +385,35 @@ class TransactionCoordinator(broke

[GitHub] [kafka] hachikuji opened a new pull request #9330: MINOR: Remove unneeded FIXME

2020-09-23 Thread GitBox
hachikuji opened a new pull request #9330: URL: https://github.com/apache/kafka/pull/9330 A previous iteration of the Raft patch had a broken check for disconnects. We had fixed the problem, but forgotten to remove the FIXME. ### Committer Checklist (excluded from commit message)

[GitHub] [kafka] hachikuji merged pull request #9330: MINOR: Remove unneeded FIXME

2020-09-23 Thread GitBox
hachikuji merged pull request #9330: URL: https://github.com/apache/kafka/pull/9330 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] hachikuji commented on a change in pull request #9103: KAFKA-10181: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-09-23 Thread GitBox
hachikuji commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r493742677 ## File path: core/src/main/scala/kafka/api/ApiVersion.scala ## @@ -103,6 +103,9 @@ object ApiVersion { KAFKA_2_7_IV0, // Bup Fetch protocol for

[GitHub] [kafka] abbccdda commented on a change in pull request #9103: KAFKA-10181: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-09-23 Thread GitBox
abbccdda commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r493751026 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -513,15 +513,21 @@ class AdminManager(val config: KafkaConfig, resource -> Api

[GitHub] [kafka] abbccdda commented on a change in pull request #9103: KAFKA-10181: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-09-23 Thread GitBox
abbccdda commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r493752855 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -547,7 +553,8 @@ class AdminManager(val config: KafkaConfig, None else

[jira] [Updated] (KAFKA-10477) Sink Connector fails with DataException when trying to convert Kafka record with empty key to Connect Record

2020-09-23 Thread Shaik Zakir Hussain (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaik Zakir Hussain updated KAFKA-10477: Affects Version/s: 2.3.1 > Sink Connector fails with DataException when trying to

[GitHub] [kafka] piotrrzysko commented on pull request #9315: KAFKA-10496: Removed relying on external DNS servers in tests

2020-09-23 Thread GitBox
piotrrzysko commented on pull request #9315: URL: https://github.com/apache/kafka/pull/9315#issuecomment-697717628 @jolshan @mumrah Thanks for the review! Of course, I agree with you that it would be nice to use the mock in all tests, but after rethinking the solution suggested in this PR

[GitHub] [kafka] abbccdda commented on a change in pull request #9103: KAFKA-10181: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-09-23 Thread GitBox
abbccdda commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r493771144 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -331,6 +334,50 @@ class DynamicBrokerConfig(private val kafkaConfig: KafkaC

[GitHub] [kafka] abbccdda commented on a change in pull request #9103: KAFKA-10181: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-09-23 Thread GitBox
abbccdda commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r493771267 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -331,6 +334,50 @@ class DynamicBrokerConfig(private val kafkaConfig: KafkaC

[GitHub] [kafka] abbccdda commented on a change in pull request #9103: KAFKA-10181: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-09-23 Thread GitBox
abbccdda commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r493773324 ## File path: core/src/main/scala/kafka/server/ConfigHandler.scala ## @@ -203,7 +203,13 @@ class BrokerConfigHandler(private val brokerConfig: KafkaConfig

[GitHub] [kafka] abbccdda commented on a change in pull request #9103: KAFKA-10181: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-09-23 Thread GitBox
abbccdda commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r493782410 ## File path: clients/src/main/java/org/apache/kafka/common/requests/IncrementalAlterConfigsResponse.java ## @@ -25,23 +25,35 @@ import org.apache.kafka.

[GitHub] [kafka] hachikuji commented on pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-23 Thread GitBox
hachikuji commented on pull request #9284: URL: https://github.com/apache/kafka/pull/9284#issuecomment-697805395 @chia7712 Mentioning the fix in the upgrade notes seems the best we can do. The old (unintended) behavior does not seem worth keeping for the sake of compatibility. @rajinisivar

[GitHub] [kafka] abbccdda commented on a change in pull request #9103: KAFKA-10181: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-09-23 Thread GitBox
abbccdda commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r493795436 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -117,6 +117,89 @@ class KafkaApis(val requestChannel: RequestChannel, val adminZkCl

[jira] [Commented] (KAFKA-10477) Sink Connector fails with DataException when trying to convert Kafka record with empty key to Connect Record

2020-09-23 Thread Shaik Zakir Hussain (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201019#comment-17201019 ] Shaik Zakir Hussain commented on KAFKA-10477: - All versions up and above *v2

[GitHub] [kafka] mimaison commented on pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-09-23 Thread GitBox
mimaison commented on pull request #8295: URL: https://github.com/apache/kafka/pull/8295#issuecomment-697868544 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] mimaison commented on pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-09-23 Thread GitBox
mimaison commented on pull request #8295: URL: https://github.com/apache/kafka/pull/8295#issuecomment-697885454 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] hachikuji commented on a change in pull request #9103: KAFKA-10181: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-09-23 Thread GitBox
hachikuji commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r493823776 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -117,6 +117,89 @@ class KafkaApis(val requestChannel: RequestChannel, val adminZkC

[GitHub] [kafka] apovzner commented on a change in pull request #9317: KAFKA-10509: Added throttle connection accept rate metric (KIP-612)

2020-09-23 Thread GitBox
apovzner commented on a change in pull request #9317: URL: https://github.com/apache/kafka/pull/9317#discussion_r493869256 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1414,7 +1420,8 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metric

[GitHub] [kafka] apovzner commented on a change in pull request #9317: KAFKA-10509: Added throttle connection accept rate metric (KIP-612)

2020-09-23 Thread GitBox
apovzner commented on a change in pull request #9317: URL: https://github.com/apache/kafka/pull/9317#discussion_r493869256 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1414,7 +1420,8 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metric

[GitHub] [kafka] mumrah commented on pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-23 Thread GitBox
mumrah commented on pull request #9100: URL: https://github.com/apache/kafka/pull/9100#issuecomment-697953307 @hachikuji yea, good catch. This works today using a ZK watch on the partition "/state" znode which is still getting triggered with this PR. We can modify the new ISR update path t

[GitHub] [kafka] scanterog commented on pull request #9313: [mm2] Fix consumer/producer properties override

2020-09-23 Thread GitBox
scanterog commented on pull request #9313: URL: https://github.com/apache/kafka/pull/9313#issuecomment-697968761 @hachikuji is there any chance you can review this? Thanks! This is an automated message from the Apache Git Ser

[GitHub] [kafka] guozhangwang commented on pull request #9312: KAFKA-10505: Fix parsing of generation log string.

2020-09-23 Thread GitBox
guozhangwang commented on pull request #9312: URL: https://github.com/apache/kafka/pull/9312#issuecomment-697980115 https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4182/ passed now. I'm going to merge this one.

[GitHub] [kafka] guozhangwang merged pull request #9312: KAFKA-10505: Fix parsing of generation log string.

2020-09-23 Thread GitBox
guozhangwang merged pull request #9312: URL: https://github.com/apache/kafka/pull/9312 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] guozhangwang commented on pull request #9196: [DO NOT MERGE] KAFKA-10402: Upgrade system tests to python3

2020-09-23 Thread GitBox
guozhangwang commented on pull request #9196: URL: https://github.com/apache/kafka/pull/9196#issuecomment-697981040 https://github.com/apache/kafka/pull/9312 has been merged it. Could you rebase this PR so I can re-trigger the system test suite? As for the ignored test cases, they ar

[GitHub] [kafka] guozhangwang merged pull request #9083: KAFKA-9450: Follow-up; Forbid process after closed

2020-09-23 Thread GitBox
guozhangwang merged pull request #9083: URL: https://github.com/apache/kafka/pull/9083 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] nizhikov commented on pull request #9312: KAFKA-10505: Fix parsing of generation log string.

2020-09-23 Thread GitBox
nizhikov commented on pull request #9312: URL: https://github.com/apache/kafka/pull/9312#issuecomment-697986003 Thanks for the review and merge! This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [kafka] nizhikov commented on pull request #9196: [DO NOT MERGE] KAFKA-10402: Upgrade system tests to python3

2020-09-23 Thread GitBox
nizhikov commented on pull request #9196: URL: https://github.com/apache/kafka/pull/9196#issuecomment-697987563 @guozhangwang > Could you rebase this PR done. This is an automated message from the Apache Git Se

[GitHub] [kafka] wushujames commented on pull request #9276: KAFKA-10473: Add docs on partition size-on-disk, and other log-related metrics

2020-09-23 Thread GitBox
wushujames commented on pull request #9276: URL: https://github.com/apache/kafka/pull/9276#issuecomment-697994325 The pull request lists lots of failed checks. However, this pull request only changed an HTML file, and it seems unrelated to the test failures in those checks. -

[jira] [Created] (KAFKA-10517) Inefficient consumer processing with fetch sessions

2020-09-23 Thread Dhruvil Shah (Jira)
Dhruvil Shah created KAFKA-10517: Summary: Inefficient consumer processing with fetch sessions Key: KAFKA-10517 URL: https://issues.apache.org/jira/browse/KAFKA-10517 Project: Kafka Issue Typ

[jira] [Updated] (KAFKA-10517) Inefficient consumer processing with fetch sessions

2020-09-23 Thread Dhruvil Shah (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dhruvil Shah updated KAFKA-10517: - Description: With the introduction of fetch sessions, the consumer and the broker share a unifi

[jira] [Created] (KAFKA-10518) Consumer fetches could be inefficient when lags are unbalanced

2020-09-23 Thread Dhruvil Shah (Jira)
Dhruvil Shah created KAFKA-10518: Summary: Consumer fetches could be inefficient when lags are unbalanced Key: KAFKA-10518 URL: https://issues.apache.org/jira/browse/KAFKA-10518 Project: Kafka

[GitHub] [kafka] ijuma opened a new pull request #9331: MINOR: Use JUnit 5 in raft module

2020-09-23 Thread GitBox
ijuma opened a new pull request #9331: URL: https://github.com/apache/kafka/pull/9331 I also removed a test class with no tests currently. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build statu

[GitHub] [kafka] hachikuji opened a new pull request #9332: KAFKA-10511; Ensure monotonic start epoch/offset updates in `MockLog`

2020-09-23 Thread GitBox
hachikuji opened a new pull request #9332: URL: https://github.com/apache/kafka/pull/9332 There is a minor difference in behavior between the epoch caching logic in `MockLog` from the behavior in `LeaderEpochFileCache`. The latter ensures that every new epoch/start offset entry added to th

[jira] [Created] (KAFKA-10519) Unit tests for VotedState

2020-09-23 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10519: --- Summary: Unit tests for VotedState Key: KAFKA-10519 URL: https://issues.apache.org/jira/browse/KAFKA-10519 Project: Kafka Issue Type: Sub-task

[GitHub] [kafka] hachikuji commented on a change in pull request #9331: MINOR: Use JUnit 5 in raft module

2020-09-23 Thread GitBox
hachikuji commented on a change in pull request #9331: URL: https://github.com/apache/kafka/pull/9331#discussion_r493968673 ## File path: raft/src/test/java/org/apache/kafka/raft/VotedStateTest.java ## @@ -1,28 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] ijuma commented on a change in pull request #9331: MINOR: Use JUnit 5 in raft module

2020-09-23 Thread GitBox
ijuma commented on a change in pull request #9331: URL: https://github.com/apache/kafka/pull/9331#discussion_r493969248 ## File path: raft/src/test/java/org/apache/kafka/raft/VotedStateTest.java ## @@ -1,28 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] mjsax opened a new pull request #9333: KAFKA-9274: Revert deprecation of `retries` for producer and admin clients

2020-09-23 Thread GitBox
mjsax opened a new pull request #9333: URL: https://github.com/apache/kafka/pull/9333 Partially reverts #8864 Call for review @vvcephei @hachikuji @cmccabe @ijuma This is an automated message from the Apache Git Serv

[GitHub] [kafka] mjsax commented on a change in pull request #8864: KAFKA-9274: Mark `retries` config as deprecated and add new `task.timeout.ms` config

2020-09-23 Thread GitBox
mjsax commented on a change in pull request #8864: URL: https://github.com/apache/kafka/pull/8864#discussion_r493976743 ## File path: streams/src/test/java/org/apache/kafka/streams/tests/StreamsBrokerDownResilienceTest.java ## @@ -45,6 +45,7 @@ private static final Stri

[jira] [Resolved] (KAFKA-10297) Don't use deprecated producer config `retries`

2020-09-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-10297. - Resolution: Invalid We change the KIP to not deprecate `retries`. Hence, this ticket is

[GitHub] [kafka] chia7712 commented on pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-23 Thread GitBox
chia7712 commented on pull request #9284: URL: https://github.com/apache/kafka/pull/9284#issuecomment-698083970 ``` Build / JDK 11 / kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup ``` it is flaky on trunk branch also so it is unr

[jira] [Assigned] (KAFKA-9075) Extend documentation for usage of GlobalKTable vs KTable

2020-09-23 Thread Ankit Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Kumar reassigned KAFKA-9075: -- Assignee: Ankit Kumar > Extend documentation for usage of GlobalKTable vs KTable > ---

[GitHub] [kafka] apovzner commented on a change in pull request #9317: KAFKA-10509: Added throttle connection accept rate metric (KIP-612)

2020-09-23 Thread GitBox
apovzner commented on a change in pull request #9317: URL: https://github.com/apache/kafka/pull/9317#discussion_r494034591 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1447,13 +1454,33 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metr

[GitHub] [kafka] dielhennr edited a comment on pull request #9101: KAFKA-10325: KIP-649 implementation

2020-09-23 Thread GitBox
dielhennr edited a comment on pull request #9101: URL: https://github.com/apache/kafka/pull/9101#issuecomment-683076305 Hey @jsancio , I added some work in progress to this branch including new APIs for this feature. Fitting user and client-id into the `DescribeConfigs` API was awkw

[GitHub] [kafka] dielhennr edited a comment on pull request #9101: KAFKA-10325: KIP-649 implementation

2020-09-23 Thread GitBox
dielhennr edited a comment on pull request #9101: URL: https://github.com/apache/kafka/pull/9101#issuecomment-683076305 Hey @jsancio , I added some work in progress to this branch including new APIs for this feature. Fitting user and client-id into the `DescribeConfigs` API was awkw

[GitHub] [kafka] apovzner commented on a change in pull request #9317: KAFKA-10509: Added throttle connection accept rate metric (KIP-612)

2020-09-23 Thread GitBox
apovzner commented on a change in pull request #9317: URL: https://github.com/apache/kafka/pull/9317#discussion_r494053882 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1292,6 +1292,12 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metri

[GitHub] [kafka] apovzner commented on pull request #9317: KAFKA-10509: Added throttle connection accept rate metric (KIP-612)

2020-09-23 Thread GitBox
apovzner commented on pull request #9317: URL: https://github.com/apache/kafka/pull/9317#issuecomment-698128538 @dajac Thanks for the review, I addressed your comments. This is an automated message from the Apache Git Service

[GitHub] [kafka] abbccdda commented on a change in pull request #9332: KAFKA-10511; Ensure monotonic start epoch/offset updates in `MockLog`

2020-09-23 Thread GitBox
abbccdda commented on a change in pull request #9332: URL: https://github.com/apache/kafka/pull/9332#discussion_r494062676 ## File path: raft/src/test/java/org/apache/kafka/raft/MockLogTest.java ## @@ -370,6 +365,23 @@ public void testReadOutOfRangeOffset() { Isola

[GitHub] [kafka] cadonna commented on pull request #9328: Minor: Add deleteDir for streams quickstart test

2020-09-23 Thread GitBox
cadonna commented on pull request #9328: URL: https://github.com/apache/kafka/pull/9328#issuecomment-698151176 @mumrah, error message ``` [2020-09-24T01:46:33.204Z] Cleaning up test-streams-archetype No such property: deleteDir for class: groovy.lang.Binding ``` in build