abbccdda commented on a change in pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#discussion_r493782410
##########
File path:
clients/src/main/java/org/apache/kafka/common/requests/IncrementalAlterConfigsResponse.java
##########
@@ -25,23 +25,35 @@
import org.apache.kafka.common.protocol.types.Struct;
import java.nio.ByteBuffer;
+import java.util.ArrayList;
import java.util.HashMap;
+import java.util.List;
import java.util.Map;
public class IncrementalAlterConfigsResponse extends AbstractResponse {
- public static IncrementalAlterConfigsResponseData toResponseData(final int
requestThrottleMs,
- final
Map<ConfigResource, ApiError> results) {
- IncrementalAlterConfigsResponseData responseData = new
IncrementalAlterConfigsResponseData();
- responseData.setThrottleTimeMs(requestThrottleMs);
- for (Map.Entry<ConfigResource, ApiError> entry : results.entrySet()) {
- responseData.responses().add(new AlterConfigsResourceResponse().
- setResourceName(entry.getKey().name()).
- setResourceType(entry.getKey().type().id()).
- setErrorCode(entry.getValue().error().code()).
- setErrorMessage(entry.getValue().message()));
- }
- return responseData;
+ public IncrementalAlterConfigsResponse(final int requestThrottleMs,
+ final Map<ConfigResource, ApiError>
results) {
+ this.data = new IncrementalAlterConfigsResponseData()
+ .setThrottleTimeMs(requestThrottleMs);
+
+ addResults(results);
+ }
+
+ public IncrementalAlterConfigsResponse addResults(final
Map<ConfigResource, ApiError> results) {
Review comment:
I guess we could get rid of it and do the merge in caller level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
