abbccdda commented on a change in pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#discussion_r493773324
##########
File path: core/src/main/scala/kafka/server/ConfigHandler.scala
##########
@@ -203,7 +203,13 @@ class BrokerConfigHandler(private val brokerConfig:
KafkaConfig,
if (brokerId == ConfigEntityName.Default)
brokerConfig.dynamicConfig.updateDefaultConfig(properties)
else if (brokerConfig.brokerId == brokerId.trim.toInt) {
- brokerConfig.dynamicConfig.updateBrokerConfig(brokerConfig.brokerId,
properties)
+ val persistentProps =
brokerConfig.dynamicConfig.fromPersistentProps(properties, perBrokerConfig =
true)
+ // The filepath was changed for equivalent replacement, which means we
should reload
+ if (brokerConfig.dynamicConfig.trimSSLStorePaths(persistentProps)) {
+
brokerConfig.dynamicConfig.reloadUpdatedFilesWithoutConfigChange(persistentProps)
+ }
Review comment:
I feel it's more explicit to do it in here, as zk notification is the
only target case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
