abbccdda commented on a change in pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#discussion_r493771267
##########
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##########
@@ -331,6 +334,50 @@ class DynamicBrokerConfig(private val kafkaConfig:
KafkaConfig) extends Logging
}
}
+ private[server] def maybeAugmentSSLStorePaths(configProps: Properties,
previousConfigProps: Map[String, String]): Unit ={
+ val processedFiles = new mutable.HashSet[String]
+ reconfigurables
+ .filter(reconfigurable =>
ReloadableFileConfigs.exists(reconfigurable.reconfigurableConfigs.contains))
+ .foreach({
+ case reconfigurable: ListenerReconfigurable =>
+ ReloadableFileConfigs.foreach(configName => {
+ val prefixedName = reconfigurable.listenerName.configPrefix +
configName
+ if (!processedFiles.contains(prefixedName) &&
configProps.containsKey(prefixedName) &&
+
configProps.get(prefixedName).equals(previousConfigProps.getOrElse(prefixedName,
""))) {
+ val equivalentFileName =
configProps.getProperty(prefixedName).replace("/", "//")
+ configProps.setProperty(prefixedName, equivalentFileName)
+ processedFiles.add(prefixedName)
+ }
+ })
+ })
+ }
+
+ private[server] def trimSSLStorePaths(configProps: Properties): Boolean = {
+ var fileChanged = false
+ val processedFiles = new mutable.HashSet[String]
+
+ reconfigurables
+ .filter(reconfigurable =>
ReloadableFileConfigs.exists(reconfigurable.reconfigurableConfigs.contains))
+ .foreach {
+ case reconfigurable: ListenerReconfigurable =>
+ ReloadableFileConfigs.foreach(configName => {
+ val prefixedName = reconfigurable.listenerName.configPrefix +
configName
+ if (!processedFiles.contains(prefixedName) &&
configProps.containsKey(prefixedName)) {
+ val configFileName = configProps.getProperty(prefixedName)
+ val equivalentFileName = configFileName.replace("//", "/")
+ if (!configFileName.equals(equivalentFileName)) {
+ fileChanged = true
Review comment:
Yea
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
