[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

2020-08-04 Thread Jerry Wei (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170601#comment-17170601 ] Jerry Wei commented on KAFKA-10134: --- The long time joining group is related to *max.po

[GitHub] [kafka] johnthotekat opened a new pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

2020-08-04 Thread GitBox
johnthotekat opened a new pull request #9120: URL: https://github.com/apache/kafka/pull/9120 *Deprecated the existing getters and added new getters `activeHost()`, `standbyHosts()`, and `partition()` in KeyQueryMetadata.java. *Updated the existing Tests to use the new getters of KeyQ

[jira] [Commented] (KAFKA-10316) Consider renaming getter method for Interactive Queries

2020-08-04 Thread John Thomas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170636#comment-17170636 ] John Thomas commented on KAFKA-10316: - Thanks Matt. We've got 3 binding+1 , 3 non-bi

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-08-04 Thread GitBox
mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r464884697 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3973,25 +3977,38 @@ void handleResponse(AbstractResponse a

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-08-04 Thread GitBox
mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r464886489 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ListOffsetRequest.java ## @@ -47,96 +42,11 @@ public static final int CONSUMER_R

[GitHub] [kafka] dajac commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-08-04 Thread GitBox
dajac commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r464911676 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -892,136 +894,175 @@ class KafkaApis(val requestChannel: RequestChannel, def handleLis

[jira] [Comment Edited] (KAFKA-10316) Consider renaming getter method for Interactive Queries

2020-08-04 Thread John Thomas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170636#comment-17170636 ] John Thomas edited comment on KAFKA-10316 at 8/4/20, 9:26 AM:

[jira] [Updated] (KAFKA-10316) Consider renaming getter method for Interactive Queries

2020-08-04 Thread John Thomas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Thomas updated KAFKA-10316: Remaining Estimate: 0h (was: 3h) > Consider renaming getter method for Interactive Queries >

[GitHub] [kafka] showuon commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

2020-08-04 Thread GitBox
showuon commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-668507540 @mjsax , could you review this PR to add tests? Thanks. This is an automated message from the Apache Git Service.

[GitHub] [kafka] showuon opened a new pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl

2020-08-04 Thread GitBox
showuon opened a new pull request #9121: URL: https://github.com/apache/kafka/pull/9121 add 2 tests for IOExceptions cases: 1 for `OffsetCheckpoint` and 1 for `GlobalStateManagerImpl` ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

[jira] [Created] (KAFKA-10354) Kafka Bug

2020-08-04 Thread Eeranna Kuruva (Jira)
Eeranna Kuruva created KAFKA-10354: -- Summary: Kafka Bug Key: KAFKA-10354 URL: https://issues.apache.org/jira/browse/KAFKA-10354 Project: Kafka Issue Type: Bug Reporter: Eeranna K

[GitHub] [kafka] nresare opened a new pull request #9122: KAFKA-10314: KafkaStorageException on reassignment when offline log d…

2020-08-04 Thread GitBox
nresare opened a new pull request #9122: URL: https://github.com/apache/kafka/pull/9122 …irectories exist Make sure that we set the isNew field in LeaderAndIsrRequest correctly for brokers that gets added to the replica set on reassignment. This is tested by creating a vari

[jira] [Commented] (KAFKA-10314) KafkaStorageException on reassignment when offline log directories exist

2020-08-04 Thread Noa Resare (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170776#comment-17170776 ] Noa Resare commented on KAFKA-10314: I just opened https://github.com/apache/kafka/p

[jira] [Updated] (KAFKA-10314) KafkaStorageException on reassignment when offline log directories exist

2020-08-04 Thread Noa Resare (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noa Resare updated KAFKA-10314: --- Flags: Patch > KafkaStorageException on reassignment when offline log directories exist > --

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-04 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465029352 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1771,6 +1775,127 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

2020-08-04 Thread GitBox
dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465038411 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

2020-08-04 Thread GitBox
dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465038614 ## File path: core/src/main/scala/kafka/server/ControllerMutationQuotaManager.scala ## @@ -131,6 +133,16 @@ class PermissiveControllerMutationQuota(private va

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

2020-08-04 Thread GitBox
dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465040672 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

2020-08-04 Thread GitBox
dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465040813 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java ## @@ -223,8 +229,14 @@ public void checkQuotas(long timeMs) {

[GitHub] [kafka] dajac commented on pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

2020-08-04 Thread GitBox
dajac commented on pull request #9114: URL: https://github.com/apache/kafka/pull/9114#issuecomment-668593472 @junrao @apovzner I have updated the PR to address your comments. I have also refactored the code a bit and updated all the tests of the controller quota manager to work with the To

[GitHub] [kafka] rhauch commented on pull request #9116: KAFKA-10341: Add 2.6.0 to system tests and streams upgrade tests

2020-08-04 Thread GitBox
rhauch commented on pull request #9116: URL: https://github.com/apache/kafka/pull/9116#issuecomment-668606283 Green builds on JDK 11 and 14, and two unrelated failures (known flaky integration tests, not system tests) on JDK 8: ``` Test Result (2 failures / +1) org.apache.kafk

[GitHub] [kafka] rhauch edited a comment on pull request #9116: KAFKA-10341: Add 2.6.0 to system tests and streams upgrade tests

2020-08-04 Thread GitBox
rhauch edited a comment on pull request #9116: URL: https://github.com/apache/kafka/pull/9116#issuecomment-668606283 Green builds on JDK 11 and 14, and two unrelated failures (known flaky integration tests, not system tests) on JDK 8: ``` Test Result (2 failures / +1) org.apac

[jira] [Commented] (KAFKA-10353) Trogdor - Fix RoundTripWorker to not fail when the topic it's trying to create already exists

2020-08-04 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170805#comment-17170805 ] Ismael Juma commented on KAFKA-10353: - Looks like a duplicate of KAFKA-10308. > Tro

[GitHub] [kafka] ijuma commented on pull request #9079: KAFKA-10308 fix flaky core/round_trip_fault_test.py

2020-08-04 Thread GitBox
ijuma commented on pull request #9079: URL: https://github.com/apache/kafka/pull/9079#issuecomment-668607739 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] rhauch commented on pull request #9115: Bump dev version to 2.6.1-SNAPSHOT

2020-08-04 Thread GitBox
rhauch commented on pull request #9115: URL: https://github.com/apache/kafka/pull/9115#issuecomment-668608342 Successful build on JDK 11. JDK 8 build timed out, and several test failures on JDK 14. Retest this please.

[GitHub] [kafka] ijuma merged pull request #9079: KAFKA-10308 fix flaky core/round_trip_fault_test.py

2020-08-04 Thread GitBox
ijuma merged pull request #9079: URL: https://github.com/apache/kafka/pull/9079 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-04 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465073439 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java ## @@ -132,16 +135,19 @@

[jira] [Resolved] (KAFKA-10353) Trogdor - Fix RoundTripWorker to not fail when the topic it's trying to create already exists

2020-08-04 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski resolved KAFKA-10353. - Resolution: Duplicate > Trogdor - Fix RoundTripWorker to not fail when the topic

[jira] [Commented] (KAFKA-10353) Trogdor - Fix RoundTripWorker to not fail when the topic it's trying to create already exists

2020-08-04 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170819#comment-17170819 ] Stanislav Kozlovski commented on KAFKA-10353: - Should be fixed as of KAFKA-1

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-04 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465079294 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImpl.java ## @@ -0,0 +1,234 @@ +/* + * Licensed to the A

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-04 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465094963 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java ## @@ -459,6 +460,95 @@ public void shouldGro

[GitHub] [kafka] mjsax commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-04 Thread GitBox
mjsax commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465097558 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java ## @@ -132,16 +135,19 @@

[GitHub] [kafka] mjsax commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-04 Thread GitBox
mjsax commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465099913 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImpl.java ## @@ -0,0 +1,234 @@ +/* + * Licensed to the A

[GitHub] [kafka] mjsax commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-04 Thread GitBox
mjsax commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465101059 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImpl.java ## @@ -0,0 +1,234 @@ +/* + * Licensed to the A

[GitHub] [kafka] mjsax commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

2020-08-04 Thread GitBox
mjsax commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-668639088 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] badaiaqrandista commented on a change in pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

2020-08-04 Thread GitBox
badaiaqrandista commented on a change in pull request #9099: URL: https://github.com/apache/kafka/pull/9099#discussion_r465105476 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -459,48 +466,32 @@ class DefaultMessageFormatter extends MessageFormatter

[GitHub] [kafka] badaiaqrandista commented on a change in pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

2020-08-04 Thread GitBox
badaiaqrandista commented on a change in pull request #9099: URL: https://github.com/apache/kafka/pull/9099#discussion_r465105897 ## File path: core/src/test/scala/kafka/tools/DefaultMessageFormatterTest.scala ## @@ -0,0 +1,235 @@ +/** + * Licensed to the Apache Software Found

[GitHub] [kafka] mjsax commented on pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

2020-08-04 Thread GitBox
mjsax commented on pull request #9120: URL: https://github.com/apache/kafka/pull/9120#issuecomment-668643155 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

2020-08-04 Thread GitBox
mjsax commented on a change in pull request #9120: URL: https://github.com/apache/kafka/pull/9120#discussion_r465106657 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -71,11 +75,40 @@ public HostInfo getActiveHost() { * Get the St

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-04 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465111665 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImpl.java ## @@ -0,0 +1,234 @@ +/* + * Licensed to the A

[jira] [Updated] (KAFKA-10316) Consider renaming getter method for Interactive Queries

2020-08-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10316: Description: In the 2.5 release, we introduce new classes for Interactive Queries via KIP

[jira] [Updated] (KAFKA-10316) Consider renaming getter method for Interactive Queries

2020-08-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10316: Labels: beginner kip newbie (was: beginner need-kip newbie) > Consider renaming getter me

[jira] [Updated] (KAFKA-10316) Consider renaming getter method for Interactive Queries

2020-08-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10316: Description: In the 2.5 release, we introduce new classes for Interactive Queries via KIP

[GitHub] [kafka] junrao commented on a change in pull request #8936: KAFKA-10207: Fixed padded timeindex causing premature data deletion

2020-08-04 Thread GitBox
junrao commented on a change in pull request #8936: URL: https://github.com/apache/kafka/pull/8936#discussion_r465151900 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -652,6 +653,12 @@ class Log(@volatile private var _dir: File, bytesTruncated } + def s

[GitHub] [kafka] johnthotekat commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

2020-08-04 Thread GitBox
johnthotekat commented on a change in pull request #9120: URL: https://github.com/apache/kafka/pull/9120#discussion_r465163841 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -71,11 +75,40 @@ public HostInfo getActiveHost() { * Get

[GitHub] [kafka] johnthotekat commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

2020-08-04 Thread GitBox
johnthotekat commented on a change in pull request #9120: URL: https://github.com/apache/kafka/pull/9120#discussion_r465164586 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -71,11 +75,40 @@ public HostInfo getActiveHost() { * Get

[GitHub] [kafka] johnthotekat commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

2020-08-04 Thread GitBox
johnthotekat commented on a change in pull request #9120: URL: https://github.com/apache/kafka/pull/9120#discussion_r465164267 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -71,11 +75,40 @@ public HostInfo getActiveHost() { * Get

[GitHub] [kafka] brary commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

2020-08-04 Thread GitBox
brary commented on a change in pull request #9120: URL: https://github.com/apache/kafka/pull/9120#discussion_r465176121 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo activeHost, f

[GitHub] [kafka] junrao commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-08-04 Thread GitBox
junrao commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r465179335 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -369,6 +370,32 @@ class GroupCoordinator(val brokerId: Int, }

[GitHub] [kafka] johnthotekat commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

2020-08-04 Thread GitBox
johnthotekat commented on a change in pull request #9120: URL: https://github.com/apache/kafka/pull/9120#discussion_r465190512 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo active

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-04 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465191505 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java ## @@ -459,6 +460,95 @@ public void shouldGro

[GitHub] [kafka] johnthotekat commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

2020-08-04 Thread GitBox
johnthotekat commented on a change in pull request #9120: URL: https://github.com/apache/kafka/pull/9120#discussion_r465192381 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo active

[GitHub] [kafka] johnthotekat commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

2020-08-04 Thread GitBox
johnthotekat commented on a change in pull request #9120: URL: https://github.com/apache/kafka/pull/9120#discussion_r465193230 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo active

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-04 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465193735 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/SlidingWindowsTest.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] lbradstreet opened a new pull request #9123: MINOR: optimize fetchablePartitions check by performing cheap check first

2020-08-04 Thread GitBox
lbradstreet opened a new pull request #9123: URL: https://github.com/apache/kafka/pull/9123 When the consumer fetches a lot of partitions at once the isAvailable check can become expensive due to a high number of contains check. We might as well perform the isFetchable check first as t

[GitHub] [kafka] johnthotekat commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

2020-08-04 Thread GitBox
johnthotekat commented on a change in pull request #9120: URL: https://github.com/apache/kafka/pull/9120#discussion_r465190512 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo active

[GitHub] [kafka] lbradstreet commented on pull request #9123: MINOR: optimize fetchablePartitions check by performing cheap check first

2020-08-04 Thread GitBox
lbradstreet commented on pull request #9123: URL: https://github.com/apache/kafka/pull/9123#issuecomment-668711747 ![image](https://user-images.githubusercontent.com/252189/89322318-ecf1be80-d638-11ea-9d5b-4ea11124201c.png) From a profile fetching from 2500 partitions. This section o

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-04 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465194845 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/SlidingWindowsTest.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] lbradstreet edited a comment on pull request #9123: MINOR: optimize fetchablePartitions check by performing cheap check first

2020-08-04 Thread GitBox
lbradstreet edited a comment on pull request #9123: URL: https://github.com/apache/kafka/pull/9123#issuecomment-668711747 ![image](https://user-images.githubusercontent.com/252189/89322318-ecf1be80-d638-11ea-9d5b-4ea11124201c.png) From a profile fetching from 2500 partitions. This se

[GitHub] [kafka] Johnny-Malizia commented on a change in pull request #8936: KAFKA-10207: Fixed padded timeindex causing premature data deletion

2020-08-04 Thread GitBox
Johnny-Malizia commented on a change in pull request #8936: URL: https://github.com/apache/kafka/pull/8936#discussion_r465197854 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -652,6 +653,12 @@ class Log(@volatile private var _dir: File, bytesTruncated }

[GitHub] [kafka] chia7712 commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-08-04 Thread GitBox
chia7712 commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r465200508 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -369,6 +370,32 @@ class GroupCoordinator(val brokerId: Int, }

[jira] [Commented] (KAFKA-10186) Aborting transaction with pending data should throw non-fatal exception

2020-08-04 Thread Gokul Srinivas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170970#comment-17170970 ] Gokul Srinivas commented on KAFKA-10186: [~ableegoldman], [~johnthotekat] Can I

[GitHub] [kafka] brary commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

2020-08-04 Thread GitBox
brary commented on a change in pull request #9120: URL: https://github.com/apache/kafka/pull/9120#discussion_r465201600 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo activeHost, f

[jira] [Commented] (KAFKA-4587) Rethink Unification of Caching with Dedupping

2020-08-04 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170971#comment-17170971 ] Boyang Chen commented on KAFKA-4587: What's the status of this ticket? Do we still wa

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-04 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465205088 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStreamThreadTest.java ## @@ -221,7 +221,6 @@ public void shouldTransit

[GitHub] [kafka] chia7712 commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-08-04 Thread GitBox
chia7712 commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r465206257 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -369,6 +370,32 @@ class GroupCoordinator(val brokerId: Int, }

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-08-04 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r465215487 ## File path: docs/streams/developer-guide/config-streams.html ## @@ -326,13 +321,18 @@ bootstrap.serversstate.cleanup.delay.ms Low

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-04 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465219522 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java ## @@ -459,6 +460,95 @@ public void shouldGro

[GitHub] [kafka] chia7712 commented on pull request #9102: KAFKA-10326 Both serializer and deserializer should be able to see th…

2020-08-04 Thread GitBox
chia7712 commented on pull request #9102: URL: https://github.com/apache/kafka/pull/9102#issuecomment-668732926 ```org.apache.kafka.clients.admin.KafkaAdminClientTest.testMetadataRetries``` is traced by #9091 and ```EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]```

[GitHub] [kafka] hachikuji commented on a change in pull request #9110: MINOR: Ensure a reason is logged for all segment deletion operations

2020-08-04 Thread GitBox
hachikuji commented on a change in pull request #9110: URL: https://github.com/apache/kafka/pull/9110#discussion_r465221060 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2227,14 +2210,17 @@ class Log(@volatile private var _dir: File, * @param segments The log

[GitHub] [kafka] chia7712 commented on a change in pull request #8852: MINOR: code cleanup for Kafka Streams task classes

2020-08-04 Thread GitBox
chia7712 commented on a change in pull request #8852: URL: https://github.com/apache/kafka/pull/8852#discussion_r465229314 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java ## @@ -116,89 +112,100 @@ public boolean isValidTransition(fina

[jira] [Commented] (KAFKA-10186) Aborting transaction with pending data should throw non-fatal exception

2020-08-04 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171026#comment-17171026 ] Sophie Blee-Goldman commented on KAFKA-10186: - I was suggesting to throw a n

[GitHub] [kafka] ableegoldman commented on pull request #9024: [DO NOT MERGE (yet)] MINOR: bump Streams integration test log level to DEBUG

2020-08-04 Thread GitBox
ableegoldman commented on pull request #9024: URL: https://github.com/apache/kafka/pull/9024#issuecomment-668756679 1 unrelated failure: `SaslPlaintextConsumerTest.testCoordinatorFailover` This is an automated message from th

[GitHub] [kafka] abbccdda commented on a change in pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

2020-08-04 Thread GitBox
abbccdda commented on a change in pull request #9060: URL: https://github.com/apache/kafka/pull/9060#discussion_r465243578 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -91,18 +100,20 @@ public InternalTopicMan

[GitHub] [kafka] mjsax merged pull request #9024: MINOR: change Streams integration test log levels

2020-08-04 Thread GitBox
mjsax merged pull request #9024: URL: https://github.com/apache/kafka/pull/9024 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-10354) Kafka Bug

2020-08-04 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171040#comment-17171040 ] Boyang Chen commented on KAFKA-10354: - What's this ticket about? > Kafka Bug >

[GitHub] [kafka] dielhennr commented on a change in pull request #9101: KAFKA-10325: KIP-649 implementation

2020-08-04 Thread GitBox
dielhennr commented on a change in pull request #9101: URL: https://github.com/apache/kafka/pull/9101#discussion_r465257558 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -431,6 +433,26 @@ class AdminManager(val config: KafkaConfig, (na

[GitHub] [kafka] dielhennr commented on a change in pull request #9101: KAFKA-10325: KIP-649 implementation

2020-08-04 Thread GitBox
dielhennr commented on a change in pull request #9101: URL: https://github.com/apache/kafka/pull/9101#discussion_r465257558 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -431,6 +433,26 @@ class AdminManager(val config: KafkaConfig, (na

[jira] [Created] (KAFKA-10355) Handle accidental deletion of source-topics as exceptional failure

2020-08-04 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-10355: - Summary: Handle accidental deletion of source-topics as exceptional failure Key: KAFKA-10355 URL: https://issues.apache.org/jira/browse/KAFKA-10355 Project: Kafka

[jira] [Commented] (KAFKA-10186) Aborting transaction with pending data should throw non-fatal exception

2020-08-04 Thread Gokul Srinivas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171047#comment-17171047 ] Gokul Srinivas commented on KAFKA-10186: [~ableegoldman] Thank you, I'll keep ch

[jira] [Created] (KAFKA-10356) Handle accidental deletion of sink-topics as exceptional failure

2020-08-04 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-10356: - Summary: Handle accidental deletion of sink-topics as exceptional failure Key: KAFKA-10356 URL: https://issues.apache.org/jira/browse/KAFKA-10356 Project: Kafka

[GitHub] [kafka] junrao commented on a change in pull request #8936: KAFKA-10207: Fixed padded timeindex causing premature data deletion

2020-08-04 Thread GitBox
junrao commented on a change in pull request #8936: URL: https://github.com/apache/kafka/pull/8936#discussion_r465260977 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -652,6 +653,12 @@ class Log(@volatile private var _dir: File, bytesTruncated } + def s

[jira] [Commented] (KAFKA-10186) Aborting transaction with pending data should throw non-fatal exception

2020-08-04 Thread John Thomas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171051#comment-17171051 ] John Thomas commented on KAFKA-10186: - Thanks Sophie. I'll let Gokul work on it. [~

[jira] [Created] (KAFKA-10357) Handle accidental deletion of repartition-topics as exceptional failure

2020-08-04 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-10357: - Summary: Handle accidental deletion of repartition-topics as exceptional failure Key: KAFKA-10357 URL: https://issues.apache.org/jira/browse/KAFKA-10357 Project: Ka

[jira] [Created] (KAFKA-10358) Remove the 2.12 sitedocs

2020-08-04 Thread Randall Hauch (Jira)
Randall Hauch created KAFKA-10358: - Summary: Remove the 2.12 sitedocs Key: KAFKA-10358 URL: https://issues.apache.org/jira/browse/KAFKA-10358 Project: Kafka Issue Type: Task Compone

[GitHub] [kafka] abbccdda opened a new pull request #9124: MINOR: add additional shutdown log info

2020-08-04 Thread GitBox
abbccdda opened a new pull request #9124: URL: https://github.com/apache/kafka/pull/9124 The purpose of this PR is to both enhance the visibility of shutdown progress for Kafka, as well as for the debugging purpose of a delayed process in between socket server close and eventually kafka se

[GitHub] [kafka] dajac closed pull request #9072: KAFKA-10162; Make the rate based quota behave more like a Token Bucket (KIP-599, Part III)

2020-08-04 Thread GitBox
dajac closed pull request #9072: URL: https://github.com/apache/kafka/pull/9072 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (KAFKA-10359) AgentTest unit test failure during verification build of AK 2.6.0 RC2

2020-08-04 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10359: -- Summary: AgentTest unit test failure during verification build of AK 2.6.0 RC2 (was: Test fai

[jira] [Created] (KAFKA-10359) Test failure during verification build of AK 2.6.0 RC2

2020-08-04 Thread Randall Hauch (Jira)
Randall Hauch created KAFKA-10359: - Summary: Test failure during verification build of AK 2.6.0 RC2 Key: KAFKA-10359 URL: https://issues.apache.org/jira/browse/KAFKA-10359 Project: Kafka Issu

[GitHub] [kafka] dajac commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig

2020-08-04 Thread GitBox
dajac commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r465272340 ## File path: clients/src/main/resources/common/message/RequestHeader.json ## @@ -37,6 +37,12 @@ // Since the client is sending the ApiVersionsRequest in

[GitHub] [kafka] dajac commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig

2020-08-04 Thread GitBox
dajac commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r465274018 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2599,13 +2664,57 @@ class KafkaApis(val requestChannel: RequestChannel, } }

[GitHub] [kafka] dajac commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig

2020-08-04 Thread GitBox
dajac commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r465273597 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2453,34 +2455,98 @@ class KafkaApis(val requestChannel: RequestChannel, def handleA

[GitHub] [kafka] dajac commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig

2020-08-04 Thread GitBox
dajac commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r465273903 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2599,13 +2664,57 @@ class KafkaApis(val requestChannel: RequestChannel, } }

[GitHub] [kafka] ijuma merged pull request #9058: MINOR: Update jackson to latest 2.10.5

2020-08-04 Thread GitBox
ijuma merged pull request #9058: URL: https://github.com/apache/kafka/pull/9058 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #9058: MINOR: Update jackson to latest 2.10.5

2020-08-04 Thread GitBox
ijuma commented on pull request #9058: URL: https://github.com/apache/kafka/pull/9058#issuecomment-668778840 Merged to trunk. Is there a reason to backport it to older branches? This is an automated message from the Apache Gi

[GitHub] [kafka] dajac commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig

2020-08-04 Thread GitBox
dajac commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r465275440 ## File path: clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java ## @@ -37,11 +37,22 @@ public RequestHeader(Struct struct, short head

[GitHub] [kafka] dhruvilshah3 commented on a change in pull request #9110: MINOR: Ensure a reason is logged for all segment deletion operations

2020-08-04 Thread GitBox
dhruvilshah3 commented on a change in pull request #9110: URL: https://github.com/apache/kafka/pull/9110#discussion_r464100823 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2227,14 +2210,17 @@ class Log(@volatile private var _dir: File, * @param segments The

[jira] [Commented] (KAFKA-10186) Aborting transaction with pending data should throw non-fatal exception

2020-08-04 Thread Gokul Srinivas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171077#comment-17171077 ] Gokul Srinivas commented on KAFKA-10186: Thank you [~johnthotekat]. Please assig

[jira] [Commented] (KAFKA-10186) Aborting transaction with pending data should throw non-fatal exception

2020-08-04 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171078#comment-17171078 ] Sophie Blee-Goldman commented on KAFKA-10186: - [~nym3r0s] You need to send a

[GitHub] [kafka] niteshmor commented on pull request #9058: MINOR: Update jackson to latest 2.10.5

2020-08-04 Thread GitBox
niteshmor commented on pull request #9058: URL: https://github.com/apache/kafka/pull/9058#issuecomment-668789671 > Merged to trunk. Is there a reason to backport it to older branches? Thank you. I was under the impression that the older versions are bringing in a vulnerable jackso

  1   2   >