[GitHub] [kafka] highluck commented on a change in pull request #9105: MINOR: closable object Memory leak prevention

2020-08-03 Thread GitBox
highluck commented on a change in pull request #9105: URL: https://github.com/apache/kafka/pull/9105#discussion_r464215307 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -197,8 +197,8 @@ synchronized boolean lock(fina

[GitHub] [kafka] highluck commented on pull request #9105: MINOR: closable object Memory leak prevention

2020-08-03 Thread GitBox
highluck commented on pull request #9105: URL: https://github.com/apache/kafka/pull/9105#issuecomment-667844194 @abbccdda Please review again thank you :) This is an automated message from the Apache Git Service. To r

[GitHub] [kafka] albert02lowis commented on pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

2020-08-03 Thread GitBox
albert02lowis commented on pull request #9108: URL: https://github.com/apache/kafka/pull/9108#issuecomment-667850415 Hi @abbccdda sure thing, I have added 2 more commits to this PR and the unit + integration tests also looks good in my local ---

[GitHub] [kafka] highluck commented on a change in pull request #9105: MINOR: closable object Memory leak prevention

2020-08-03 Thread GitBox
highluck commented on a change in pull request #9105: URL: https://github.com/apache/kafka/pull/9105#discussion_r464215307 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -197,8 +197,8 @@ synchronized boolean lock(fina

[jira] [Commented] (KAFKA-7540) Flaky Test ConsumerBounceTest#testClose

2020-08-03 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169776#comment-17169776 ] Chia-Ping Tsai commented on KAFKA-7540: --- [~hachikuji] Could I take over this issue?

[GitHub] [kafka] highluck removed a comment on pull request #9105: MINOR: closable object Memory leak prevention

2020-08-03 Thread GitBox
highluck removed a comment on pull request #9105: URL: https://github.com/apache/kafka/pull/9105#issuecomment-667844194 @abbccdda Please review again thank you :) This is an automated message from the Apache Git Servi

[GitHub] [kafka] highluck commented on a change in pull request #9105: MINOR: closable object Memory leak prevention

2020-08-03 Thread GitBox
highluck commented on a change in pull request #9105: URL: https://github.com/apache/kafka/pull/9105#discussion_r464215307 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -197,8 +197,8 @@ synchronized boolean lock(fina

[GitHub] [kafka] highluck closed pull request #9105: MINOR: closable object Memory leak prevention

2020-08-03 Thread GitBox
highluck closed pull request #9105: URL: https://github.com/apache/kafka/pull/9105 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] highluck commented on pull request #9105: MINOR: closable object Memory leak prevention

2020-08-03 Thread GitBox
highluck commented on pull request #9105: URL: https://github.com/apache/kafka/pull/9105#issuecomment-667867206 @abbccdda thanks for review I was mistaken and wrong close issue This is an automated message from

[GitHub] [kafka] dajac commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig

2020-08-03 Thread GitBox
dajac commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r464241946 ## File path: clients/src/main/java/org/apache/kafka/clients/ClientRequest.java ## @@ -34,6 +34,8 @@ private final boolean expectResponse; private f

[jira] [Updated] (KAFKA-10334) Transactions not working properly

2020-08-03 Thread Luis Araujo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luis Araujo updated KAFKA-10334: Component/s: clients > Transactions not working properly > - > >

[jira] [Updated] (KAFKA-10334) Transactions not working properly

2020-08-03 Thread Luis Araujo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luis Araujo updated KAFKA-10334: Component/s: documentation > Transactions not working properly > -

[jira] [Updated] (KAFKA-10334) Transactions not working properly

2020-08-03 Thread Luis Araujo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luis Araujo updated KAFKA-10334: Component/s: (was: documentation) > Transactions not working properly > --

[GitHub] [kafka] rajinisivaram merged pull request #9092: KAFKA-10163; Define `controller_mutation_rate` as a Double instead of a Long

2020-08-03 Thread GitBox
rajinisivaram merged pull request #9092: URL: https://github.com/apache/kafka/pull/9092 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] rajinisivaram commented on pull request #9092: KAFKA-10163; Define `controller_mutation_rate` as a Double instead of a Long

2020-08-03 Thread GitBox
rajinisivaram commented on pull request #9092: URL: https://github.com/apache/kafka/pull/9092#issuecomment-667923327 @dajac Thanks for the PR, test failures not related, merging to trunk. This is an automated message from the

[jira] [Created] (KAFKA-10338) Support PEM format for SSL certificates and private key

2020-08-03 Thread Rajini Sivaram (Jira)
Rajini Sivaram created KAFKA-10338: -- Summary: Support PEM format for SSL certificates and private key Key: KAFKA-10338 URL: https://issues.apache.org/jira/browse/KAFKA-10338 Project: Kafka I

[GitHub] [kafka] amitbhoraniya opened a new pull request #9113: Fix trogdor coordinator client

2020-08-03 Thread GitBox
amitbhoraniya opened a new pull request #9113: URL: https://github.com/apache/kafka/pull/9113 Trogdor coordinator client is not able to shutdown remote coordinator, so fixed that issue. ### Committer Checklist (excluded from commit message) - [x] Verify design and implementation

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2020-08-03 Thread GitBox
dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-668034540 Finally, it is finished! :congratulations: All features and tests are now successfully migrated into log4j2 API and passes clearly! I changed the PR title and preparing

[GitHub] [kafka] kowshik commented on a change in pull request #9110: MINOR: Ensure a reason is logged for every segment deletion

2020-08-03 Thread GitBox
kowshik commented on a change in pull request #9110: URL: https://github.com/apache/kafka/pull/9110#discussion_r464012842 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2227,14 +2210,17 @@ class Log(@volatile private var _dir: File, * @param segments The log s

[GitHub] [kafka] abbccdda commented on pull request #9096: MINOR: Add comments to constrainedAssign and generalAssign method

2020-08-03 Thread GitBox
abbccdda commented on pull request #9096: URL: https://github.com/apache/kafka/pull/9096#issuecomment-668113921 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] junrao commented on a change in pull request #8936: KAFKA-10207: Fixed padded timeindex causing premature data deletion

2020-08-03 Thread GitBox
junrao commented on a change in pull request #8936: URL: https://github.com/apache/kafka/pull/8936#discussion_r463885952 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -60,11 +60,34 @@ class LogSegment private[log] (val log: FileRecords,

[GitHub] [kafka] hachikuji commented on a change in pull request #9110: MINOR: Ensure a reason is logged for all segment deletion operations

2020-08-03 Thread GitBox
hachikuji commented on a change in pull request #9110: URL: https://github.com/apache/kafka/pull/9110#discussion_r464545190 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2227,13 +2210,16 @@ class Log(@volatile private var _dir: File, * @param segments The log

[GitHub] [kafka] dajac opened a new pull request #9114: KAFKA-10162; Make the rate based quota behave more like a Token Bucket (KIP-599, Part III)

2020-08-03 Thread GitBox
dajac opened a new pull request #9114: URL: https://github.com/apache/kafka/pull/9114 Based on the discussion in https://github.com/apache/kafka/pull/9072, I have put together an alternative way. This one does the following: * Instead of changing the implementation of the Rate to behave

[jira] [Created] (KAFKA-10339) MirrorMaker2 Exactly-once Semantics

2020-08-03 Thread Ning Zhang (Jira)
Ning Zhang created KAFKA-10339: -- Summary: MirrorMaker2 Exactly-once Semantics Key: KAFKA-10339 URL: https://issues.apache.org/jira/browse/KAFKA-10339 Project: Kafka Issue Type: New Feature

[GitHub] [kafka] dhruvilshah3 commented on pull request #9110: MINOR: Ensure a reason is logged for all segment deletion operations

2020-08-03 Thread GitBox
dhruvilshah3 commented on pull request #9110: URL: https://github.com/apache/kafka/pull/9110#issuecomment-668151967 Thanks for the reviews @kowshik, @hachikuji, @ijuma. I have addressed the comments. This is an automated mes

[jira] [Updated] (KAFKA-10339) MirrorMaker2 Exactly-once Semantics

2020-08-03 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Zhang updated KAFKA-10339: --- Labels: needs-kip (was: ) > MirrorMaker2 Exactly-once Semantics > -

[GitHub] [kafka] dhruvilshah3 edited a comment on pull request #9110: MINOR: Ensure a reason is logged for all segment deletion operations

2020-08-03 Thread GitBox
dhruvilshah3 edited a comment on pull request #9110: URL: https://github.com/apache/kafka/pull/9110#issuecomment-668151967 Thanks for the reviews @kowshik, @hachikuji, @ijuma. I have addressed the comments. Let me know what you think. --

[jira] [Commented] (KAFKA-10339) MirrorMaker2 Exactly-once Semantics

2020-08-03 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170231#comment-17170231 ] Ning Zhang commented on KAFKA-10339: [~ryannedolan] [~mimaison] Here is the KIP I wo

[GitHub] [kafka] ijuma commented on pull request #9110: MINOR: Ensure a reason is logged for all segment deletion operations

2020-08-03 Thread GitBox
ijuma commented on pull request #9110: URL: https://github.com/apache/kafka/pull/9110#issuecomment-668162389 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] abbccdda commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig

2020-08-03 Thread GitBox
abbccdda commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r464567004 ## File path: clients/src/main/java/org/apache/kafka/clients/ClientRequest.java ## @@ -34,6 +34,8 @@ private final boolean expectResponse; privat

[jira] [Created] (KAFKA-10340) Source connectors should report error when trying to producer records to non-existent topics instead of hanging forever

2020-08-03 Thread Arjun Satish (Jira)
Arjun Satish created KAFKA-10340: Summary: Source connectors should report error when trying to producer records to non-existent topics instead of hanging forever Key: KAFKA-10340 URL: https://issues.apache.org/ji

[jira] [Updated] (KAFKA-10340) Source connectors should report error when trying to producer records to non-existent topics instead of hanging forever

2020-08-03 Thread Arjun Satish (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arjun Satish updated KAFKA-10340: - Description: Currently, a source connector will blindly attempt to write a record to a Kafka to

[jira] [Updated] (KAFKA-10340) Source connectors should report error when trying to producer records to non-existent topics instead of hanging forever

2020-08-03 Thread Arjun Satish (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arjun Satish updated KAFKA-10340: - Description: Currently, a source connector will blindly attempt to write a record to a Kafka to

[GitHub] [kafka] abbccdda commented on pull request #9096: MINOR: Add comments to constrainedAssign and generalAssign method

2020-08-03 Thread GitBox
abbccdda commented on pull request #9096: URL: https://github.com/apache/kafka/pull/9096#issuecomment-668181513 Only flaky test failures. This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] abbccdda merged pull request #9096: MINOR: Add comments to constrainedAssign and generalAssign method

2020-08-03 Thread GitBox
abbccdda merged pull request #9096: URL: https://github.com/apache/kafka/pull/9096 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Updated] (KAFKA-10340) Source connectors should report error when trying to produce records to non-existent topics instead of hanging forever

2020-08-03 Thread Arjun Satish (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arjun Satish updated KAFKA-10340: - Summary: Source connectors should report error when trying to produce records to non-existent to

[GitHub] [kafka] rhauch opened a new pull request #9115: Bump dev version to 2.6.1-SNAPSHOT

2020-08-03 Thread GitBox
rhauch opened a new pull request #9115: URL: https://github.com/apache/kafka/pull/9115 As part of the 2.6.0 release, we need to bump the dev version of the `2.6` branch to 2.6.1. This is an automated message from the Apache

[jira] [Commented] (KAFKA-10339) MirrorMaker2 Exactly-once Semantics

2020-08-03 Thread Ryanne Dolan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170377#comment-17170377 ] Ryanne Dolan commented on KAFKA-10339: -- [~yangguo1220] this is awesome, thanks! My

[jira] [Commented] (KAFKA-10339) MirrorMaker2 Exactly-once Semantics

2020-08-03 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170409#comment-17170409 ] Ning Zhang commented on KAFKA-10339: Thanks [~ryannedolan] for your quick feedback :

[jira] [Commented] (KAFKA-10339) MirrorMaker2 Exactly-once Semantics

2020-08-03 Thread Ryanne Dolan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170425#comment-17170425 ] Ryanne Dolan commented on KAFKA-10339: -- Yeah, I guess it would be possible to switc

[jira] [Commented] (KAFKA-10316) Consider renaming getter method for Interactive Queries

2020-08-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170429#comment-17170429 ] Matthias J. Sax commented on KAFKA-10316: - Correct. For a KIP you need 3 binding

[jira] [Updated] (KAFKA-10321) shouldDieOnInvalidOffsetExceptionDuringStartup would block forever on JDK11

2020-08-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10321: Component/s: streams > shouldDieOnInvalidOffsetExceptionDuringStartup would block forever

[jira] [Resolved] (KAFKA-10321) shouldDieOnInvalidOffsetExceptionDuringStartup would block forever on JDK11

2020-08-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-10321. - Fix Version/s: 2.7.0 Resolution: Fixed > shouldDieOnInvalidOffsetExceptionDuringS

[jira] [Updated] (KAFKA-10255) Fix flaky testOneWayReplicationWithAutorOffsetSync1 test

2020-08-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10255: Fix Version/s: (was: 2.7) 2.7.0 > Fix flaky testOneWayReplicationWi

[jira] [Updated] (KAFKA-10120) DescribeLogDirsResult exposes internal classes

2020-08-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10120: Fix Version/s: (was: 2.7) 2.7.0 > DescribeLogDirsResult exposes int

[GitHub] [kafka] ableegoldman commented on pull request #9094: KAFKA-10054: KIP-613, add TRACE-level e2e latency metrics

2020-08-03 Thread GitBox
ableegoldman commented on pull request #9094: URL: https://github.com/apache/kafka/pull/9094#issuecomment-668252969 cc @guozhangwang for 2nd review & merge This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] mjsax commented on pull request #9024: [DO NOT MERGE (yet)] MINOR: bump Streams integration test log level to DEBUG

2020-08-03 Thread GitBox
mjsax commented on pull request #9024: URL: https://github.com/apache/kafka/pull/9024#issuecomment-668255117 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] guozhangwang commented on pull request #9024: [DO NOT MERGE (yet)] MINOR: bump Streams integration test log level to DEBUG

2020-08-03 Thread GitBox
guozhangwang commented on pull request #9024: URL: https://github.com/apache/kafka/pull/9024#issuecomment-668258427 SG. +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] guozhangwang commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

2020-08-03 Thread GitBox
guozhangwang commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r464683179 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -461,6 +463,42 @@ public void flush(

[GitHub] [kafka] guozhangwang commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

2020-08-03 Thread GitBox
guozhangwang commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r464683987 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java ## @@ -38,13 +41,39 @@ */ final class StateM

[jira] [Created] (KAFKA-10341) Add version 2.6 to streams and systems tests

2020-08-03 Thread Randall Hauch (Jira)
Randall Hauch created KAFKA-10341: - Summary: Add version 2.6 to streams and systems tests Key: KAFKA-10341 URL: https://issues.apache.org/jira/browse/KAFKA-10341 Project: Kafka Issue Type: Ta

[GitHub] [kafka] guozhangwang commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

2020-08-03 Thread GitBox
guozhangwang commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r464684660 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -267,80 +266,26 @@ public void handleAssignmen

[GitHub] [kafka] rhauch opened a new pull request #9116: KAFKA-10341: Add 2.6.0 to system tests and streams upgrade tests

2020-08-03 Thread GitBox
rhauch opened a new pull request #9116: URL: https://github.com/apache/kafka/pull/9116 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] rhauch commented on pull request #9116: KAFKA-10341: Add 2.6.0 to system tests and streams upgrade tests

2020-08-03 Thread GitBox
rhauch commented on pull request #9116: URL: https://github.com/apache/kafka/pull/9116#issuecomment-668281025 Just kicked off a build of the Streams system tests (e.g., `TC_PATHS=tests/kafkatest/tests/streams/streams_upgrade_test.py`) using this PR: https://jenkins.confluent.io/job/sys

[jira] [Updated] (KAFKA-10341) Add version 2.6 to streams and systems tests

2020-08-03 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10341: -- Fix Version/s: 2.7.0 > Add version 2.6 to streams and systems tests >

[jira] [Updated] (KAFKA-10341) Add version 2.6 to streams and systems tests

2020-08-03 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10341: -- Description: Part of the [2.6.0 release process|https://cwiki.apache.org/confluence/display/K

[GitHub] [kafka] hachikuji commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-03 Thread GitBox
hachikuji commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r464705276 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2956,6 +2956,22 @@ class KafkaApis(val requestChannel: RequestChannel, } }

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-03 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r464716040 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,121 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-03 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r464717171 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1771,6 +1775,127 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] junrao commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-08-03 Thread GitBox
junrao commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r464697840 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -1240,26 +1298,30 @@ class GroupCoordinator(val brokerId: Int, }

[GitHub] [kafka] hachikuji commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-03 Thread GitBox
hachikuji commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r464718819 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1771,6 +1775,127 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] mjsax commented on a change in pull request #5374: MINOR: update release.py

2020-08-03 Thread GitBox
mjsax commented on a change in pull request #5374: URL: https://github.com/apache/kafka/pull/5374#discussion_r464727207 ## File path: release.py ## @@ -479,16 +479,16 @@ def select_gpg_key(): for root, dirs, files in os.walk(artifacts_dir): assert root.startswith(artifact

[GitHub] [kafka] guozhangwang commented on pull request #8964: KAFKA-9450: Decouple flushing state from commiting

2020-08-03 Thread GitBox
guozhangwang commented on pull request #8964: URL: https://github.com/apache/kafka/pull/8964#issuecomment-668301971 cc @mjsax please take a final look. This is an automated message from the Apache Git Service. To respond to t

[GitHub] [kafka] mjsax commented on pull request #9107: KAFKA-5488: KIP-418 implementation

2020-08-03 Thread GitBox
mjsax commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-668302357 I'll put it into my backlog. But I am the main reviewer for two other KIPs (216 and 466) that I should review first as they got approve earlier and PRs are open for longer already.

[GitHub] [kafka] mjsax commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-03 Thread GitBox
mjsax commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r464728426 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/TimeWindowedKStreamImpl.java ## @@ -19,7 +19,16 @@ import org.apache.kafka.co

[GitHub] [kafka] mjsax commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-03 Thread GitBox
mjsax commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r464728901 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/CogroupedKStream.java ## @@ -275,6 +275,15 @@ */ TimeWindowedCogroupedKStrea

[GitHub] [kafka] Johnny-Malizia commented on a change in pull request #8936: KAFKA-10207: Fixed padded timeindex causing premature data deletion

2020-08-03 Thread GitBox
Johnny-Malizia commented on a change in pull request #8936: URL: https://github.com/apache/kafka/pull/8936#discussion_r464731245 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -652,6 +653,12 @@ class Log(@volatile private var _dir: File, bytesTruncated }

[GitHub] [kafka] junrao commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

2020-08-03 Thread GitBox
junrao commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r464724281 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Found

[jira] [Created] (KAFKA-10346) Redirect CreatePartition to the controller

2020-08-03 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-10346: --- Summary: Redirect CreatePartition to the controller Key: KAFKA-10346 URL: https://issues.apache.org/jira/browse/KAFKA-10346 Project: Kafka Issue Type: Sub-task

[jira] [Assigned] (KAFKA-10036) Improve error message if user violates `Supplier` pattern

2020-08-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-10036: --- Assignee: Igor Soarez (was: Alex Sun) > Improve error message if user violates `Su

[jira] [Created] (KAFKA-10345) Redirect AlterPartitionReassignment to the controller

2020-08-03 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-10345: --- Summary: Redirect AlterPartitionReassignment to the controller Key: KAFKA-10345 URL: https://issues.apache.org/jira/browse/KAFKA-10345 Project: Kafka Issue Ty

[jira] [Commented] (KAFKA-10036) Improve error message if user violates `Supplier` pattern

2020-08-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170493#comment-17170493 ] Matthias J. Sax commented on KAFKA-10036: - [~soarez] – in general, before you ta

[jira] [Created] (KAFKA-10347) Redirect Create/DeleteTopics to the controller

2020-08-03 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-10347: --- Summary: Redirect Create/DeleteTopics to the controller Key: KAFKA-10347 URL: https://issues.apache.org/jira/browse/KAFKA-10347 Project: Kafka Issue Type: Sub-

[jira] [Created] (KAFKA-10348) Redirect UpdateFeatures to the controller

2020-08-03 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-10348: --- Summary: Redirect UpdateFeatures to the controller Key: KAFKA-10348 URL: https://issues.apache.org/jira/browse/KAFKA-10348 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-10350) Add redirect request monitoring metrics

2020-08-03 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-10350: --- Summary: Add redirect request monitoring metrics Key: KAFKA-10350 URL: https://issues.apache.org/jira/browse/KAFKA-10350 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-10349) Deprecate client side controller access

2020-08-03 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-10349: --- Summary: Deprecate client side controller access Key: KAFKA-10349 URL: https://issues.apache.org/jira/browse/KAFKA-10349 Project: Kafka Issue Type: Sub-task

[GitHub] [kafka] mjsax commented on a change in pull request #9000: KAFKA-10036 Improve handling and documentation of Suppliers

2020-08-03 Thread GitBox
mjsax commented on a change in pull request #9000: URL: https://github.com/apache/kafka/pull/9000#discussion_r464749727 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamUtil.java ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software F

[GitHub] [kafka] abbccdda commented on pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

2020-08-03 Thread GitBox
abbccdda commented on pull request #9060: URL: https://github.com/apache/kafka/pull/9060#issuecomment-668324185 Also, do we have new unit test coverage for the changes? This is an automated message from the Apache Git Service

[GitHub] [kafka] mjsax commented on pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-03 Thread GitBox
mjsax commented on pull request #9039: URL: https://github.com/apache/kafka/pull/9039#issuecomment-668325203 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on a change in pull request #9064: KAFKA-10205: Documentation and handling of non deterministic Topologies

2020-08-03 Thread GitBox
mjsax commented on a change in pull request #9064: URL: https://github.com/apache/kafka/pull/9064#discussion_r464752987 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java ## @@ -50,6 +50,14 @@ /** * {@code StreamsBuilder} provide the high-level

[GitHub] [kafka] mjsax closed pull request #8752: KAFKA-10036 early check singleton ProcessorSupplier and improve docs

2020-08-03 Thread GitBox
mjsax closed pull request #8752: URL: https://github.com/apache/kafka/pull/8752 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #8752: KAFKA-10036 early check singleton ProcessorSupplier and improve docs

2020-08-03 Thread GitBox
mjsax commented on pull request #8752: URL: https://github.com/apache/kafka/pull/8752#issuecomment-668326105 Closing this PR in favor of #9000 This is an automated message from the Apache Git Service. To respond to the messa

[jira] [Updated] (KAFKA-9751) Internal topic creation should go to controller

2020-08-03 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-9751: --- Summary: Internal topic creation should go to controller (was: Admin `FindCoordinator` call should g

[jira] [Updated] (KAFKA-9751) Internal topic creation should go to controller

2020-08-03 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-9751: --- Description: For use cases to create internal topics through FindCoordinator or Metadata request, rec

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-08-03 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r464756646 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -274,30 +252,74 @@ private void restoreSta

[jira] [Updated] (KAFKA-10351) Add missing tests for IOExceptions for GlobalStateManagerImpl

2020-08-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10351: Issue Type: Test (was: Improvement) > Add missing tests for IOExceptions for GlobalStateM

[jira] [Created] (KAFKA-10351) Add missing tests for IOExceptions for GlobalStateManagerImpl

2020-08-03 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-10351: --- Summary: Add missing tests for IOExceptions for GlobalStateManagerImpl Key: KAFKA-10351 URL: https://issues.apache.org/jira/browse/KAFKA-10351 Project: Kafka

[jira] [Created] (KAFKA-10342) Redirect CreateAcls/DeleteAcls to the controller

2020-08-03 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-10342: --- Summary: Redirect CreateAcls/DeleteAcls to the controller Key: KAFKA-10342 URL: https://issues.apache.org/jira/browse/KAFKA-10342 Project: Kafka Issue Type: Su

[jira] [Created] (KAFKA-10343) Redirect AlterClientQuotas to the controller

2020-08-03 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-10343: --- Summary: Redirect AlterClientQuotas to the controller Key: KAFKA-10343 URL: https://issues.apache.org/jira/browse/KAFKA-10343 Project: Kafka Issue Type: Sub-ta

[GitHub] [kafka] mjsax commented on a change in pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

2020-08-03 Thread GitBox
mjsax commented on a change in pull request #9060: URL: https://github.com/apache/kafka/pull/9060#discussion_r464759130 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java ## @@ -71,21 +73,20 @@ private final Stri

[jira] [Created] (KAFKA-10344) Redirect Create/Renew/ExpireDelegationToken to the controller

2020-08-03 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-10344: --- Summary: Redirect Create/Renew/ExpireDelegationToken to the controller Key: KAFKA-10344 URL: https://issues.apache.org/jira/browse/KAFKA-10344 Project: Kafka

[jira] [Updated] (KAFKA-10342) Redirect Create/DeleteAcls to the controller

2020-08-03 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-10342: Summary: Redirect Create/DeleteAcls to the controller (was: Redirect CreateAcls/DeleteAcls to the

[jira] [Updated] (KAFKA-10342) Redirect Create/DeleteAcls to the controller

2020-08-03 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-10342: Description: In the new Admin client, the CreateAcls/DeleteAcls request should be redirected to t

[GitHub] [kafka] mjsax commented on a change in pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

2020-08-03 Thread GitBox
mjsax commented on a change in pull request #9060: URL: https://github.com/apache/kafka/pull/9060#discussion_r464759130 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java ## @@ -71,21 +73,20 @@ private final Stri

[jira] [Updated] (KAFKA-10181) Redirect AlterConfig/IncrementalAlterConfig to the controller

2020-08-03 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-10181: Description: In the bridge release broker, AlterConfig/IncrementalAlterConfig should be redirected

[jira] [Updated] (KAFKA-10343) Redirect AlterClientQuotas to the controller

2020-08-03 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-10343: Description: In the bridge release broker, AlterClientQuotas should be redirected to the active co

[jira] [Updated] (KAFKA-10342) Redirect Create/DeleteAcls to the controller

2020-08-03 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-10342: Description: In the bridge release broker,Create/DeleteAcls should be redirected to the active con

[jira] [Updated] (KAFKA-9705) Zookeeper mutation protocols should be redirected to Controller only

2020-08-03 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-9705: --- Fix Version/s: 2.7.0 > Zookeeper mutation protocols should be redirected to Controller only > ---

[GitHub] [kafka] mjsax commented on pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-08-03 Thread GitBox
mjsax commented on pull request #9047: URL: https://github.com/apache/kafka/pull/9047#issuecomment-668338125 > btw, it would be good to add test for IOException cases, such as Seems out of scope for this PR. We should rather to a new PR. I created https://issues.apache.org/jira/brows

[GitHub] [kafka] junrao commented on a change in pull request #8936: KAFKA-10207: Fixed padded timeindex causing premature data deletion

2020-08-03 Thread GitBox
junrao commented on a change in pull request #8936: URL: https://github.com/apache/kafka/pull/8936#discussion_r464735038 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -652,6 +653,12 @@ class Log(@volatile private var _dir: File, bytesTruncated } + def s

  1   2   >