[
https://issues.apache.org/jira/browse/KAFKA-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164760#comment-17164760
]
Boyang Chen commented on KAFKA-10307:
-
[~vvcephei] Could you take a look? [~feyman]
[
https://issues.apache.org/jira/browse/KAFKA-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen updated KAFKA-10307:
Component/s: streams
> Topology cycles in
> KTableKTableForeignKeyInnerJoinMultiIntegrationTest#s
[
https://issues.apache.org/jira/browse/KAFKA-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen updated KAFKA-10307:
Affects Version/s: 2.6.0
2.4.0
2.5.0
> Topology cycl
[
https://issues.apache.org/jira/browse/KAFKA-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen updated KAFKA-10307:
Priority: Major (was: Minor)
> Topology cycles in
> KTableKTableForeignKeyInnerJoinMultiIntegrat
abbccdda commented on pull request #8907:
URL: https://github.com/apache/kafka/pull/8907#issuecomment-663817294
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
chia7712 commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-663818439
@junrao
I have rebased this PR to include fix of ```group_mode_transactions_test```.
Could you run system tests again? Except for ```streams_eos_test``` and
transaction t
chia7712 edited a comment on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-663818439
@junrao
I have rebased this PR to include fix of ```group_mode_transactions_test```.
Could you run system tests again? Except for ```streams_eos_test```,
```stream
chia7712 edited a comment on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-663818439
@junrao
I have rebased this PR to include fix of ```group_mode_transactions_test```.
Could you run system tests again? Except for ```streams_eos_test```,
```stream
mjsax commented on pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#issuecomment-663383364
@vvcephei I updated the PR and needed to do quite some changes to get it
into reasonable shape. Instead of throwing a new `RetryableException` that we
catch in the outer layer, I ju
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r459890602
##
File path:
streams/src/main/java/org/apache/kafka/streams/internals/QuietStreamsConfig.java
##
@@ -1,33 +0,0 @@
-/*
- * Licensed to the Apache Software Fo
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r459891762
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -275,31 +259,70 @@ private void restoreSta
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r459892544
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -275,31 +259,70 @@ private void restoreSta
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r459892977
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -299,7 +318,17 @@ private void restoreStat
huxihx commented on pull request #9071:
URL: https://github.com/apache/kafka/pull/9071#issuecomment-663404582
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164290#comment-17164290
]
Jerry Wei commented on KAFKA-10134:
---
[~guozhang] I'm using logback and PR: https://git
dajac opened a new pull request #9072:
URL: https://github.com/apache/kafka/pull/9072
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes
dajac commented on pull request #8977:
URL: https://github.com/apache/kafka/pull/8977#issuecomment-663462152
I have opened a new proper PR: https://github.com/apache/kafka/pull/9072
This is an automated message from the Apach
[
https://issues.apache.org/jira/browse/KAFKA-6764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164370#comment-17164370
]
Pardhu Madipalli commented on KAFKA-6764:
-
I am observing this behavior with kafk
[
https://issues.apache.org/jira/browse/KAFKA-9924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164402#comment-17164402
]
Bruno Cadonna commented on KAFKA-9924:
--
The scope of this ticket was extended to not
cadonna commented on pull request #9066:
URL: https://github.com/apache/kafka/pull/9066#issuecomment-663512173
I started a run of Streams system tests:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4077/
---
cadonna commented on pull request #9066:
URL: https://github.com/apache/kafka/pull/9066#issuecomment-663512735
@mjsax I thought this fix is most urgently needed on 2.6 to unblock the
release. I will open a new PR for trunk.
cadonna commented on pull request #9066:
URL: https://github.com/apache/kafka/pull/9066#issuecomment-663512974
@ableegoldman I agree it should be a blocker.
This is an automated message from the Apache Git Service.
To respond
cadonna edited a comment on pull request #9066:
URL: https://github.com/apache/kafka/pull/9066#issuecomment-663513384
@ableegoldman I agree that having the extra protection you propose makes
sense. I will open a follow-up PR on trunk.
--
cadonna commented on pull request #9066:
URL: https://github.com/apache/kafka/pull/9066#issuecomment-663513384
@ableegoldman I agree that having the extra protection you propose makes
sense. I will open a follow-up PR.
This
ijuma commented on pull request #9065:
URL: https://github.com/apache/kafka/pull/9065#issuecomment-663532890
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log o
ijuma commented on pull request #9065:
URL: https://github.com/apache/kafka/pull/9065#issuecomment-663534471
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
ijuma commented on pull request #9065:
URL: https://github.com/apache/kafka/pull/9065#issuecomment-663534611
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log o
ijuma commented on pull request #9065:
URL: https://github.com/apache/kafka/pull/9065#issuecomment-663537187
One PR build was started here:
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3515/
This is an automat
ijuma commented on pull request #9065:
URL: https://github.com/apache/kafka/pull/9065#issuecomment-663537509
Looks like the last message somehow made Jenkins start working again.
This is an automated message from the Apache G
ijuma edited a comment on pull request #9065:
URL: https://github.com/apache/kafka/pull/9065#issuecomment-663537509
Looks like the last message somehow made the Jenkins status to be updated in
the PR again.
This is an automa
dajac commented on a change in pull request #9060:
URL: https://github.com/apache/kafka/pull/9060#discussion_r460053049
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java
##
@@ -96,13 +104,15 @@ public InternalTopicManage
ijuma commented on pull request #9051:
URL: https://github.com/apache/kafka/pull/9051#issuecomment-663547862
@huxihx Note that we usually include the reviewer(s) in the commit message.
For example:
https://github.com/apache/kafka/commit/0d5c967073e78e2a50ffa5bb860bff9ff43086d5
---
vvcephei commented on pull request #9066:
URL: https://github.com/apache/kafka/pull/9066#issuecomment-663587201
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
vvcephei commented on pull request #9066:
URL: https://github.com/apache/kafka/pull/9066#issuecomment-663587337
Test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
junrao commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-663597341
3 system test failures with trunk.
http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2020-07-23--001.1595551051--apache--trunk--0b181fdde/report.html
-
vvcephei commented on pull request #9067:
URL: https://github.com/apache/kafka/pull/9067#issuecomment-663599523
Hey @mjsax ,
I double-checked, and it does seem to be the right fix. I confirmed that no
matter whether you run the test with IDEA or gradle, there's nothing to
automatica
chia7712 commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-663618045
@junrao thanks for the reports.
Unfortunately, the failed tests are totally different in both results :(
This PR has been rebased so the fix for ```group_mode_transac
vvcephei commented on pull request #9067:
URL: https://github.com/apache/kafka/pull/9067#issuecomment-663631102
Hey @mjsax ,
Since Streams accounted for almost all of the `System.exit` calls, and since
`Exit.exit` is available almost everywhere in AK, I'm proposing to add a
checksty
[
https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164531#comment-17164531
]
Sophie Blee-Goldman commented on KAFKA-10284:
-
Nope, it just spun in a loop
vvcephei opened a new pull request #9073:
URL: https://github.com/apache/kafka/pull/9073
Adds a new task to Streams to run all the tests for all sub-projects.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverag
[
https://issues.apache.org/jira/browse/KAFKA-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-10306:
---
Assignee: Matthias J. Sax
> GlobalThread might loop forever
> -
Matthias J. Sax created KAFKA-10306:
---
Summary: GlobalThread might loop forever
Key: KAFKA-10306
URL: https://issues.apache.org/jira/browse/KAFKA-10306
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-8359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164538#comment-17164538
]
Romain Hardouin commented on KAFKA-8359:
{quote}[...] there is no major downside
ableegoldman commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r460194062
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -243,18 +242,24 @@ public void handleAssignmen
abbccdda commented on pull request #9073:
URL: https://github.com/apache/kafka/pull/9073#issuecomment-663652859
One more thought, it might be useful to add this to the repo `README` if a
user is only doing stream side changes and want to test it out on local
@vvcephei.
--
heritamas commented on a change in pull request #8730:
URL: https://github.com/apache/kafka/pull/8730#discussion_r460197007
##
File path:
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java
##
@@ -132,7 +132,7 @@ public String version() {
ableegoldman commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r460211291
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java
##
@@ -38,13 +41,39 @@
*/
final class StateM
ableegoldman commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r460212084
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##
@@ -454,6 +456,41 @@ public void flush(
ableegoldman commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r460212719
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java
##
@@ -49,6 +61,31 @@
this.stateDirectory
ableegoldman commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r460214147
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java
##
@@ -93,8 +93,8 @@ public boolean isActive() {
[
https://issues.apache.org/jira/browse/KAFKA-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164585#comment-17164585
]
Matthias J. Sax commented on KAFKA-10260:
-
Note: this issue applies for global t
ijuma commented on pull request #9065:
URL: https://github.com/apache/kafka/pull/9065#issuecomment-663687037
One build passed, one failed due to environmental reasons, one had a single
flaky failure:
`org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testOneWayReplicat
ijuma merged pull request #9065:
URL: https://github.com/apache/kafka/pull/9065
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lbradstreet commented on pull request #9067:
URL: https://github.com/apache/kafka/pull/9067#issuecomment-663689440
> Hey @mjsax ,
>
> I double-checked, and it does seem to be the right fix. I confirmed that
no matter whether you run the test with IDEA or gradle, there's nothing to
a
abbccdda commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r460165601
##
File path: docs/streams/developer-guide/config-streams.html
##
@@ -326,13 +321,18 @@ bootstrap.serversstate.cleanup.delay.ms
Low
ableegoldman commented on pull request #9066:
URL: https://github.com/apache/kafka/pull/9066#issuecomment-663701977
@vvcephei I don't think there should be any issue there, since the
checkpointed `OFFSET_UNKNOWN` is just ignored on read (or should be) and will
never make it into the subsc
cadonna commented on pull request #9066:
URL: https://github.com/apache/kafka/pull/9066#issuecomment-663702921
@vvcephei Thanks for checking! Given your finding, I will change
`UNKNOWN_OFFSET` to `-4L`. Actually, we do not to change `UNKNOWN_OFFSET` at
all, because we now never write it in
vvcephei commented on pull request #9066:
URL: https://github.com/apache/kafka/pull/9066#issuecomment-663710405
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
vvcephei commented on pull request #9066:
URL: https://github.com/apache/kafka/pull/9066#issuecomment-663710503
Test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
vvcephei opened a new pull request #9074:
URL: https://github.com/apache/kafka/pull/9074
This PR should be targeted to trunk, but it's not a trivial task. I just
wanted to propose this approach.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and impleme
vvcephei commented on pull request #9074:
URL: https://github.com/apache/kafka/pull/9074#issuecomment-663719873
Hey @cadonna , I was reflecting on your fix for KAFKA-10287, and it seems
like dealing with those sentinel values is quite risky. We've had several bugs
in the past, I don't feel
vvcephei commented on pull request #9073:
URL: https://github.com/apache/kafka/pull/9073#issuecomment-663721003
Thanks @abbccdda ! There was only one flaky test, and the last change was
only to the README, so I'll merge now.
vvcephei merged pull request #9073:
URL: https://github.com/apache/kafka/pull/9073
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
vvcephei merged pull request #9070:
URL: https://github.com/apache/kafka/pull/9070
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
vvcephei commented on pull request #9052:
URL: https://github.com/apache/kafka/pull/9052#issuecomment-663728382
Thanks @mjsax . Your suggestions sound good to me. I'll circle back on this
PR in a bit.
This is an automated me
mjsax commented on a change in pull request #9073:
URL: https://github.com/apache/kafka/pull/9073#discussion_r460282456
##
File path: build.gradle
##
@@ -1266,6 +1266,27 @@ project(':streams') {
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOu
mjsax commented on a change in pull request #9073:
URL: https://github.com/apache/kafka/pull/9073#discussion_r460282610
##
File path: build.gradle
##
@@ -1266,6 +1266,27 @@ project(':streams') {
if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
standardOu
mjsax commented on a change in pull request #9067:
URL: https://github.com/apache/kafka/pull/9067#discussion_r460282952
##
File path: checkstyle/checkstyle.xml
##
@@ -103,6 +103,13 @@
+
+
+
+
+
Review comment:
Nice one!
--
mjsax opened a new pull request #9075:
URL: https://github.com/apache/kafka/pull/9075
Fix for `2.6` blocker bug.
Call for review @guozhangwang @vvcephei (\cc @rhauch)
This is an automated message from the Apache Git Se
mjsax commented on a change in pull request #9075:
URL: https://github.com/apache/kafka/pull/9075#discussion_r460300664
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -291,27 +290,17 @@ private void restoreSta
vvcephei commented on pull request #9067:
URL: https://github.com/apache/kafka/pull/9067#issuecomment-663746926
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
mjsax commented on a change in pull request #9075:
URL: https://github.com/apache/kafka/pull/9075#discussion_r460302228
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateMaintainer.java
##
@@ -31,7 +31,7 @@
void flushState();
mjsax commented on a change in pull request #9075:
URL: https://github.com/apache/kafka/pull/9075#discussion_r460302576
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java
##
@@ -234,24 +234,18 @@ void initialize() {
mjsax commented on a change in pull request #9075:
URL: https://github.com/apache/kafka/pull/9075#discussion_r460303342
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java
##
@@ -323,21 +322,6 @@ public void shouldRe
mjsax commented on a change in pull request #9075:
URL: https://github.com/apache/kafka/pull/9075#discussion_r460303491
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStreamThreadTest.java
##
@@ -128,10 +130,9 @@ public void
shouldThrow
vvcephei commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r460287991
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -275,31 +259,70 @@ private void restore
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r460304324
##
File path:
streams/src/main/java/org/apache/kafka/streams/internals/QuietStreamsConfig.java
##
@@ -1,33 +0,0 @@
-/*
- * Licensed to the Apache Software Fo
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r460305033
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -185,32 +200,16 @@ public void registerSto
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r460305945
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -275,31 +259,70 @@ private void restoreSta
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r460307083
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -275,31 +259,70 @@ private void restoreSta
ijuma commented on pull request #9054:
URL: https://github.com/apache/kafka/pull/9054#issuecomment-663753175
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r460308601
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -299,7 +318,17 @@ private void restoreStat
[
https://issues.apache.org/jira/browse/KAFKA-9731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163061#comment-17163061
]
Shane edited comment on KAFKA-9731 at 7/24/20, 10:07 PM:
-
Hey Kaf
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r460308959
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -318,6 +341,72 @@ private void restoreStat
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r460308797
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -275,31 +259,70 @@ private void restoreSta
vvcephei commented on a change in pull request #9075:
URL: https://github.com/apache/kafka/pull/9075#discussion_r460307479
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateUpdateTask.java
##
@@ -114,8 +118,16 @@ public void flushState
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r460309750
##
File path: streams/src/test/java/org/apache/kafka/test/NoOpReadOnlyStore.java
##
@@ -78,6 +78,7 @@ public void init(final ProcessorContext context, final
vvcephei commented on pull request #9075:
URL: https://github.com/apache/kafka/pull/9075#issuecomment-663754855
Otherwise, it LGTM. Feel free to merge whether or not you like my
suggestions ;)
This is an automated message f
mjsax commented on a change in pull request #9075:
URL: https://github.com/apache/kafka/pull/9075#discussion_r460315914
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java
##
@@ -331,17 +336,36 @@ private StateConsumer initi
dhruvilshah3 commented on a change in pull request #9054:
URL: https://github.com/apache/kafka/pull/9054#discussion_r460317793
##
File path: core/src/main/scala/kafka/log/LogManager.scala
##
@@ -932,6 +927,7 @@ class LogManager(logDirs: Seq[File],
val logsToCheckpoint
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r460319742
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -275,31 +259,70 @@ private void restoreSta
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r460308959
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -318,6 +341,72 @@ private void restoreStat
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r460320303
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -275,31 +259,70 @@ private void restoreSta
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r460320506
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -299,7 +318,17 @@ private void restoreStat
lbradstreet commented on a change in pull request #9067:
URL: https://github.com/apache/kafka/pull/9067#discussion_r460322318
##
File path: checkstyle/checkstyle.xml
##
@@ -103,6 +103,13 @@
+
+
+
+
+
Review comment:
Thank you
mjsax commented on pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#issuecomment-663766278
Thanks for the review @abbccdda @vvcephei -- updated the PR.
This is an automated message from the Apache Git Servic
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r460324591
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -275,31 +259,70 @@ private void restoreSta
mjsax merged pull request #9061:
URL: https://github.com/apache/kafka/pull/9061
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vvcephei commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r460338414
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -275,31 +259,70 @@ private void restore
vvcephei commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r460338747
##
File path:
streams/src/main/java/org/apache/kafka/streams/internals/QuietStreamsConfig.java
##
@@ -1,33 +0,0 @@
-/*
- * Licensed to the Apache Software
1 - 100 of 108 matches
Mail list logo
