mjsax commented on a change in pull request #9075: URL: https://github.com/apache/kafka/pull/9075#discussion_r460303342
########## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java ########## @@ -323,21 +322,6 @@ public void shouldRestoreRecordsUpToHighwatermark() { assertEquals(2, stateRestoreCallback.restored.size()); } - @Test - public void shouldRecoverFromInvalidOffsetExceptionAndRestoreRecords() { Review comment: This test was broken: it throw the `InvalidOffsetException` only once and thus the second `poll()` succeeds -- however, this is not how a real consumer behalves. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org