dhruvilshah3 commented on a change in pull request #9054:
URL: https://github.com/apache/kafka/pull/9054#discussion_r460317793
##########
File path: core/src/main/scala/kafka/log/LogManager.scala
##########
@@ -932,6 +927,7 @@ class LogManager(logDirs: Seq[File],
val logsToCheckpoint = logsInDir(logDir)
checkpointRecoveryOffsetsAndCleanSnapshotsInDir(logDir,
logsToCheckpoint, ArrayBuffer.empty)
checkpointLogStartOffsetsInDir(logDir, logsToCheckpoint)
+ sourceLog.removeLogMetrics()
Review comment:
This seems a bit odd but looks like an existing issue. We are removing
metrics for the `current` log but we leave the metrics for the `future` log as
is, which means it will retain the `is-future` tag. Maybe worth filing a JIRA
if you think it is a problem too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
