mjsax commented on a change in pull request #9075:
URL: https://github.com/apache/kafka/pull/9075#discussion_r460302228
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateMaintainer.java
##########
@@ -31,7 +31,7 @@
void flushState();
- void close() throws IOException;
+ void close(final boolean wipeStateStore) throws IOException;
Review comment:
We could also not wipe out the store and let the user do it manually. A
manual cleanup is actually required nowadays, thus, it's actually a small side
"improvement".
Note that we wipe out the whole global task dir here -- in contrast, users
could do a manual per-store wipe out... But as we do the same coarse grained
wipe out for all tasks and we have already a ticket for "per store cleanup" I
though it would be ok for now.
Let me know what you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
