[GitHub] [kafka] mimaison commented on pull request #8921: KAFKA-10160: Kafka MM2 consumer configuration

2020-07-16 Thread GitBox
mimaison commented on pull request #8921: URL: https://github.com/apache/kafka/pull/8921#issuecomment-659272353 Test failure is unrelated: - org.apache.kafka.streams.integration.BranchedMultiLevelRepartitionConnectedTopologyTest.testTopologyBuild ---

[GitHub] [kafka] mimaison merged pull request #8921: KAFKA-10160: Kafka MM2 consumer configuration

2020-07-16 Thread GitBox
mimaison merged pull request #8921: URL: https://github.com/apache/kafka/pull/8921 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Resolved] (KAFKA-10160) Kafka MM2 consumer configuration

2020-07-16 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-10160. Fix Version/s: 2.7.0 Resolution: Fixed > Kafka MM2 consumer configuration > ---

[GitHub] [kafka] rajinisivaram commented on a change in pull request #8979: KAFKA-10223; Use NOT_LEADER_OR_FOLLOWER instead of non-retriable REPLICA_NOT_AVAILABLE for consumers

2020-07-16 Thread GitBox
rajinisivaram commented on a change in pull request #8979: URL: https://github.com/apache/kafka/pull/8979#discussion_r455644987 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -712,10 +708,13 @@ class ReplicaManager(val config: KafkaConfig, }

[GitHub] [kafka] rajinisivaram commented on a change in pull request #8979: KAFKA-10223; Use NOT_LEADER_OR_FOLLOWER instead of non-retriable REPLICA_NOT_AVAILABLE for consumers

2020-07-16 Thread GitBox
rajinisivaram commented on a change in pull request #8979: URL: https://github.com/apache/kafka/pull/8979#discussion_r455645402 ## File path: clients/src/main/java/org/apache/kafka/common/errors/NotLeaderOrFollowerException.java ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apac

[GitHub] [kafka] rajinisivaram commented on pull request #8979: KAFKA-10223; Use NOT_LEADER_OR_FOLLOWER instead of non-retriable REPLICA_NOT_AVAILABLE for consumers

2020-07-16 Thread GitBox
rajinisivaram commented on pull request #8979: URL: https://github.com/apache/kafka/pull/8979#issuecomment-659288156 @hachikuji @ijuma Thanks for the reviews, have addressed the comments so far. This is an automated message f

[jira] [Commented] (KAFKA-9973) __consumer_offsets record is invalid lead to log clean failed and __consumer_offsets grows too big

2020-07-16 Thread zhangzhisheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159059#comment-17159059 ] zhangzhisheng commented on KAFKA-9973: -- __consumer_offsets can not clean kafka vers

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-07-16 Thread GitBox
mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r455669663 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -892,136 +895,162 @@ class KafkaApis(val requestChannel: RequestChannel, def handle

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-07-16 Thread GitBox
mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r455671140 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -994,30 +1023,29 @@ public void onSuccess(ClientRespons

[GitHub] [kafka] showuon opened a new pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-16 Thread GitBox
showuon opened a new pull request #9029: URL: https://github.com/apache/kafka/pull/9029 In the original test, we will sleep for static 5 seconds to ensure the automated group offset sync is complete. It sometimes synced fast (less than 1 sec), and sometimes slow (~ 20 seconds). I rewrite t

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-07-16 Thread GitBox
mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r455671951 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1077,7 +1077,7 @@ class ReplicaManager(val config: KafkaConfig, // Tr

[GitHub] [kafka] showuon commented on a change in pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-16 Thread GitBox
showuon commented on a change in pull request #9029: URL: https://github.com/apache/kafka/pull/9029#discussion_r455672187 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -315,9 +319,34 @@ public void testRep

[GitHub] [kafka] showuon commented on pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-16 Thread GitBox
showuon commented on pull request #9029: URL: https://github.com/apache/kafka/pull/9029#issuecomment-659310965 @ning2008wisc @mimaison , could you help review this PR to fix the flaky test? Thanks. This is an automated messa

[GitHub] [kafka] cadonna commented on a change in pull request #9027: KAFKA-9161: add docs for KIP-441 and KIP-613 and other configs that need fixing

2020-07-16 Thread GitBox
cadonna commented on a change in pull request #9027: URL: https://github.com/apache/kafka/pull/9027#discussion_r455681362 ## File path: docs/streams/developer-guide/config-streams.html ## @@ -181,6 +193,7 @@ bootstrap.serverscache.max.bytes.buffering Medium

[jira] [Created] (KAFKA-10278) kafka-configs does not show the current properties of running kafka broker upon describe.

2020-07-16 Thread kaushik srinivas (Jira)
kaushik srinivas created KAFKA-10278: Summary: kafka-configs does not show the current properties of running kafka broker upon describe. Key: KAFKA-10278 URL: https://issues.apache.org/jira/browse/KAFKA-10278

[jira] [Commented] (KAFKA-10278) kafka-configs does not show the current properties of running kafka broker upon describe.

2020-07-16 Thread kaushik srinivas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159129#comment-17159129 ] kaushik srinivas commented on KAFKA-10278: -- Hi [~rajinisiva...@gmail.com] [~r

[GitHub] [kafka] mimaison commented on pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-07-16 Thread GitBox
mimaison commented on pull request #8295: URL: https://github.com/apache/kafka/pull/8295#issuecomment-659347339 Thanks @dajac for your comments, I've pushed an update. @abbccdda Can you take a look? This is an automate

[GitHub] [kafka] rajinisivaram opened a new pull request #9030: MINOR: Filter out quota configs for ConfigCommand using --bootstrap-server

2020-07-16 Thread GitBox
rajinisivaram opened a new pull request #9030: URL: https://github.com/apache/kafka/pull/9030 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including u

[jira] [Commented] (KAFKA-5488) KStream.branch should not return a Array of streams we have to access by known index

2020-07-16 Thread Ivan Ponomarev (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159164#comment-17159164 ] Ivan Ponomarev commented on KAFKA-5488: --- Hi everyone, {quote}I think there are som

[jira] [Assigned] (KAFKA-5488) KStream.branch should not return a Array of streams we have to access by known index

2020-07-16 Thread Ivan Ponomarev (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Ponomarev reassigned KAFKA-5488: - Assignee: Ivan Ponomarev (was: highluck) > KStream.branch should not return a Array of

[jira] [Assigned] (KAFKA-8296) Kafka Streams branch method raises type warnings

2020-07-16 Thread Ivan Ponomarev (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Ponomarev reassigned KAFKA-8296: - Assignee: Ivan Ponomarev > Kafka Streams branch method raises type warnings > --

[jira] [Comment Edited] (KAFKA-5488) KStream.branch should not return a Array of streams we have to access by known index

2020-07-16 Thread Ivan Ponomarev (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159164#comment-17159164 ] Ivan Ponomarev edited comment on KAFKA-5488 at 7/16/20, 12:38 PM: -

[GitHub] [kafka] dajac commented on a change in pull request #9030: MINOR: Filter out quota configs for ConfigCommand using --bootstrap-server

2020-07-16 Thread GitBox
dajac commented on a change in pull request #9030: URL: https://github.com/apache/kafka/pull/9030#discussion_r455745104 ## File path: clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java ## @@ -197,18 +197,20 @@ public class RequestResponseTest {

[GitHub] [kafka] dajac commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-07-16 Thread GitBox
dajac commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r455763010 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -892,136 +895,162 @@ class KafkaApis(val requestChannel: RequestChannel, def handleLis

[GitHub] [kafka] dajac commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-07-16 Thread GitBox
dajac commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r455765374 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1077,7 +1077,7 @@ class ReplicaManager(val config: KafkaConfig, // Try t

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-07-16 Thread GitBox
mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r455782710 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1077,7 +1077,7 @@ class ReplicaManager(val config: KafkaConfig, // Tr

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-07-16 Thread GitBox
mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r455791789 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -892,136 +895,162 @@ class KafkaApis(val requestChannel: RequestChannel, def handle

[GitHub] [kafka] rondagostino commented on a change in pull request #9030: MINOR: Filter out quota configs for ConfigCommand using --bootstrap-server

2020-07-16 Thread GitBox
rondagostino commented on a change in pull request #9030: URL: https://github.com/apache/kafka/pull/9030#discussion_r455792482 ## File path: clients/src/main/java/org/apache/kafka/common/requests/DescribeClientQuotasResponse.java ## @@ -66,10 +66,11 @@ public DescribeClientQuo

[GitHub] [kafka] lbradstreet commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

2020-07-16 Thread GitBox
lbradstreet commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r455828890 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -273,6 +99,28 @@ public boolean equals(Object o) {

[GitHub] [kafka] lbradstreet commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

2020-07-16 Thread GitBox
lbradstreet commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r455835380 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -273,6 +99,28 @@ public boolean equals(Object o) {

[GitHub] [kafka] lbradstreet commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

2020-07-16 Thread GitBox
lbradstreet commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r455835380 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -273,6 +99,28 @@ public boolean equals(Object o) {

[jira] [Commented] (KAFKA-5488) KStream.branch should not return a Array of streams we have to access by known index

2020-07-16 Thread highluck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159285#comment-17159285 ] highluck commented on KAFKA-5488: - @Ivan Ponomarev thanks for comment! Call me whenever y

[GitHub] [kafka] rajinisivaram commented on a change in pull request #8933: KAFKA-10163; Throttle Create Topic, Create Partition and Delete Topic Operations (KIP-599, Part I, Broker Changes)

2020-07-16 Thread GitBox
rajinisivaram commented on a change in pull request #8933: URL: https://github.com/apache/kafka/pull/8933#discussion_r455832706 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -295,34 +312,44 @@ class AdminManager(val config: KafkaConfig, thro

[GitHub] [kafka] vvcephei commented on a change in pull request #9027: KAFKA-9161: add docs for KIP-441 and KIP-613 and other configs that need fixing

2020-07-16 Thread GitBox
vvcephei commented on a change in pull request #9027: URL: https://github.com/apache/kafka/pull/9027#discussion_r455299303 ## File path: docs/streams/developer-guide/config-streams.html ## @@ -181,6 +193,7 @@ bootstrap.serverscache.max.bytes.buffering Medium

[GitHub] [kafka] cmccabe commented on pull request #8948: KAFKA-10174: Prefer --bootstrap-server for configs command in ducker tests

2020-07-16 Thread GitBox
cmccabe commented on pull request #8948: URL: https://github.com/apache/kafka/pull/8948#issuecomment-659508365 ok, that works for me. LGTM This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] cmccabe merged pull request #8948: KAFKA-10174: Prefer --bootstrap-server for configs command in ducker tests

2020-07-16 Thread GitBox
cmccabe merged pull request #8948: URL: https://github.com/apache/kafka/pull/8948 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Resolved] (KAFKA-10174) Prefer --bootstrap-server ducktape tests using kafka_configs.sh

2020-07-16 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-10174. -- Fix Version/s: 2.7 Reviewer: Colin McCabe Resolution: Fixed > Prefer --bootstr

[GitHub] [kafka] ning2008wisc commented on a change in pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-16 Thread GitBox
ning2008wisc commented on a change in pull request #9029: URL: https://github.com/apache/kafka/pull/9029#discussion_r455902217 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -315,9 +319,34 @@ public void te

[GitHub] [kafka] ning2008wisc commented on a change in pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-16 Thread GitBox
ning2008wisc commented on a change in pull request #9029: URL: https://github.com/apache/kafka/pull/9029#discussion_r455903116 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -315,9 +319,34 @@ public void te

[GitHub] [kafka] vvcephei commented on a change in pull request #9020: KAFKA-10271 Performance degradation while fetching a key from a single partition

2020-07-16 Thread GitBox
vvcephei commented on a change in pull request #9020: URL: https://github.com/apache/kafka/pull/9020#discussion_r455904752 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/StreamThreadStateStoreProvider.java ## @@ -20,62 +20,49 @@ import org.apache

[GitHub] [kafka] ning2008wisc edited a comment on pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-16 Thread GitBox
ning2008wisc edited a comment on pull request #9029: URL: https://github.com/apache/kafka/pull/9029#issuecomment-659516303 Hi @showuon thanks for the fix, it looks a good start. Another minor and non-blocking comment may be: if it is a small fix, probably 1 commit in the PR looks more neat

[GitHub] [kafka] ning2008wisc commented on pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-16 Thread GitBox
ning2008wisc commented on pull request #9029: URL: https://github.com/apache/kafka/pull/9029#issuecomment-659516303 He @showuon thanks for the fix, it looks a good start. Another minor and non-blocking comment may be: if it is a small fix, probably 1 commit in the PR looks more neat. ---

[jira] [Commented] (KAFKA-10205) NullPointerException in StreamTask

2020-07-16 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159332#comment-17159332 ] Sophie Blee-Goldman commented on KAFKA-10205: - Given how many people have hi

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9030: MINOR: Filter out quota configs for ConfigCommand using --bootstrap-server

2020-07-16 Thread GitBox
rajinisivaram commented on a change in pull request #9030: URL: https://github.com/apache/kafka/pull/9030#discussion_r455916021 ## File path: clients/src/main/java/org/apache/kafka/common/requests/DescribeClientQuotasResponse.java ## @@ -66,10 +66,11 @@ public DescribeClientQu

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9030: MINOR: Filter out quota configs for ConfigCommand using --bootstrap-server

2020-07-16 Thread GitBox
rajinisivaram commented on a change in pull request #9030: URL: https://github.com/apache/kafka/pull/9030#discussion_r455916169 ## File path: clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java ## @@ -197,18 +197,20 @@ public class RequestRespons

[GitHub] [kafka] vvcephei opened a new pull request #9031: POC: replace abstract Windows with a proper interface

2020-07-16 Thread GitBox
vvcephei opened a new pull request #9031: URL: https://github.com/apache/kafka/pull/9031 Just a POC for illustrative purposes. No need to review. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI buil

[GitHub] [kafka] vinothchandar commented on pull request #8948: KAFKA-10174: Prefer --bootstrap-server for configs command in ducker tests

2020-07-16 Thread GitBox
vinothchandar commented on pull request #8948: URL: https://github.com/apache/kafka/pull/8948#issuecomment-659531282 Thanks @cmccabe This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ableegoldman commented on a change in pull request #9028: KAFKA-10035: Safer conversion of consumer timeout parameters

2020-07-16 Thread GitBox
ableegoldman commented on a change in pull request #9028: URL: https://github.com/apache/kafka/pull/9028#discussion_r455916364 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java ## @@ -151,7 +151,7 @@ private void prepare

[GitHub] [kafka] dima5rr commented on a change in pull request #9020: KAFKA-10271 Performance degradation while fetching a key from a single partition

2020-07-16 Thread GitBox
dima5rr commented on a change in pull request #9020: URL: https://github.com/apache/kafka/pull/9020#discussion_r455934580 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/StreamThreadStateStoreProvider.java ## @@ -20,62 +20,49 @@ import org.apache.

[GitHub] [kafka] dima5rr commented on a change in pull request #9020: KAFKA-10271 Performance degradation while fetching a key from a single partition

2020-07-16 Thread GitBox
dima5rr commented on a change in pull request #9020: URL: https://github.com/apache/kafka/pull/9020#discussion_r455939491 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/WrappingStoreProvider.java ## @@ -46,11 +46,22 @@ public void setStoreQueryPar

[GitHub] [kafka] vvcephei commented on a change in pull request #9020: KAFKA-10271 Performance degradation while fetching a key from a single partition

2020-07-16 Thread GitBox
vvcephei commented on a change in pull request #9020: URL: https://github.com/apache/kafka/pull/9020#discussion_r455948704 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/StreamThreadStateStoreProvider.java ## @@ -51,18 +51,22 @@ public StreamThrea

[jira] [Commented] (KAFKA-10205) NullPointerException in StreamTask

2020-07-16 Thread Brian Forkan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159365#comment-17159365 ] Brian Forkan commented on KAFKA-10205: -- [~mjsax] this fix appears to do the trick.

[GitHub] [kafka] hachikuji commented on pull request #9011: KAFKA-10134: Still depends on existence of any fetchable partitions to block on join

2020-07-16 Thread GitBox
hachikuji commented on pull request #9011: URL: https://github.com/apache/kafka/pull/9011#issuecomment-659560017 @guozhangwang There is one detail I think we're missing. If `updateAssignmentMetadataIfNeeded` does not block, then execution will fall through to `pollForFetches`. I would like

[GitHub] [kafka] dima5rr commented on a change in pull request #9020: KAFKA-10271 Performance degradation while fetching a key from a single partition

2020-07-16 Thread GitBox
dima5rr commented on a change in pull request #9020: URL: https://github.com/apache/kafka/pull/9020#discussion_r455974476 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/StreamThreadStateStoreProvider.java ## @@ -51,18 +51,22 @@ public StreamThread

[jira] [Commented] (KAFKA-10035) Improve the AbstractResetIntegrationTest

2020-07-16 Thread Sergey (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159387#comment-17159387 ] Sergey commented on KAFKA-10035: Thanks! > Improve the AbstractResetIntegrationTest > -

[jira] [Issue Comment Deleted] (KAFKA-10035) Improve the AbstractResetIntegrationTest

2020-07-16 Thread Sergey (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey updated KAFKA-10035: --- Comment: was deleted (was: Thanks!) > Improve the AbstractResetIntegrationTest > --

[jira] [Commented] (KAFKA-10035) Improve the AbstractResetIntegrationTest

2020-07-16 Thread Sergei (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159388#comment-17159388 ] Sergei commented on KAFKA-10035: Thanks! > Improve the AbstractResetIntegrationTest > -

[jira] [Commented] (KAFKA-4620) Connection exceptions in JMXTool do not make it to the top level

2020-07-16 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159392#comment-17159392 ] Kowshik Prakasam commented on KAFKA-4620: - My observation is that it seems this i

[GitHub] [kafka] bdbyrne commented on a change in pull request #9022: KAFKA-10158: Improve test behavior and resolve flakiness of test...

2020-07-16 Thread GitBox
bdbyrne commented on a change in pull request #9022: URL: https://github.com/apache/kafka/pull/9022#discussion_r455998374 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala ## @@ -56,12 +56,17 @@ class TopicCommandWithAdminClientTest exten

[GitHub] [kafka] hachikuji commented on a change in pull request #8979: KAFKA-10223; Use NOT_LEADER_OR_FOLLOWER instead of non-retriable REPLICA_NOT_AVAILABLE for consumers

2020-07-16 Thread GitBox
hachikuji commented on a change in pull request #8979: URL: https://github.com/apache/kafka/pull/8979#discussion_r456008354 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -58,8 +58,8 @@ * * - {@link Errors#OFFSET_OUT_OF_RANGE}

[jira] [Created] (KAFKA-10279) Allow dynamic update of certificates with additional SubjectAltNames

2020-07-16 Thread Rajini Sivaram (Jira)
Rajini Sivaram created KAFKA-10279: -- Summary: Allow dynamic update of certificates with additional SubjectAltNames Key: KAFKA-10279 URL: https://issues.apache.org/jira/browse/KAFKA-10279 Project: Kaf

[GitHub] [kafka] hachikuji commented on pull request #9022: KAFKA-10158: Improve test behavior and resolve flakiness of test...

2020-07-16 Thread GitBox
hachikuji commented on pull request #9022: URL: https://github.com/apache/kafka/pull/9022#issuecomment-659626413 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Commented] (KAFKA-10279) Allow dynamic update of certificates with additional SubjectAltNames

2020-07-16 Thread Maulin Vasavada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159436#comment-17159436 ] Maulin Vasavada commented on KAFKA-10279: - +1 Rajini.  > Allow dynamic update o

[jira] [Created] (KAFKA-10280) Message filtering support based on keys format/Headers

2020-07-16 Thread Raj (Jira)
Raj created KAFKA-10280: --- Summary: Message filtering support based on keys format/Headers Key: KAFKA-10280 URL: https://issues.apache.org/jira/browse/KAFKA-10280 Project: Kafka Issue Type: Improvement

[GitHub] [kafka] jeffkbkim commented on a change in pull request #8935: KAFKA-10189: reset event queue time histogram when queue is empty

2020-07-16 Thread GitBox
jeffkbkim commented on a change in pull request #8935: URL: https://github.com/apache/kafka/pull/8935#discussion_r456064275 ## File path: core/src/main/scala/kafka/controller/ControllerEventManager.scala ## @@ -139,4 +140,19 @@ class ControllerEventManager(controllerId: Int,

[GitHub] [kafka] serjchebotarev commented on a change in pull request #9028: KAFKA-10035: Safer conversion of consumer timeout parameters

2020-07-16 Thread GitBox
serjchebotarev commented on a change in pull request #9028: URL: https://github.com/apache/kafka/pull/9028#discussion_r456067480 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java ## @@ -265,7 +265,7 @@ public void shoul

[GitHub] [kafka] serjchebotarev commented on a change in pull request #9028: KAFKA-10035: Safer conversion of consumer timeout parameters

2020-07-16 Thread GitBox
serjchebotarev commented on a change in pull request #9028: URL: https://github.com/apache/kafka/pull/9028#discussion_r456067480 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java ## @@ -265,7 +265,7 @@ public void shoul

[GitHub] [kafka] serjchebotarev commented on a change in pull request #9028: KAFKA-10035: Safer conversion of consumer timeout parameters

2020-07-16 Thread GitBox
serjchebotarev commented on a change in pull request #9028: URL: https://github.com/apache/kafka/pull/9028#discussion_r456068727 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java ## @@ -151,7 +151,7 @@ private void prepa

[GitHub] [kafka] mumrah commented on pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

2020-07-16 Thread GitBox
mumrah commented on pull request #9008: URL: https://github.com/apache/kafka/pull/9008#issuecomment-659665576 Updated the benchmarks with @lbradstreet's suggestions. Here are the results for 3 partitions, 10 topics. GC profiles included. On this branch: ``` Benchmark

[GitHub] [kafka] mumrah edited a comment on pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

2020-07-16 Thread GitBox
mumrah edited a comment on pull request #9008: URL: https://github.com/apache/kafka/pull/9008#issuecomment-659665576 Updated the benchmarks with @lbradstreet's suggestions. Here are the results for 3 partitions, 10 topics. GC profiles included. On this branch: ``` Benchmark

[GitHub] [kafka] ijuma commented on a change in pull request #8979: KAFKA-10223; Use NOT_LEADER_OR_FOLLOWER instead of non-retriable REPLICA_NOT_AVAILABLE for consumers

2020-07-16 Thread GitBox
ijuma commented on a change in pull request #8979: URL: https://github.com/apache/kafka/pull/8979#discussion_r456074355 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/Errors.java ## @@ -139,13 +139,15 @@ InvalidFetchSizeException::new), L

[GitHub] [kafka] ijuma commented on pull request #8979: KAFKA-10223; Use NOT_LEADER_OR_FOLLOWER instead of non-retriable REPLICA_NOT_AVAILABLE for consumers

2020-07-16 Thread GitBox
ijuma commented on pull request #8979: URL: https://github.com/apache/kafka/pull/8979#issuecomment-659670683 @rajinisivaram With regards to MetadataResponse, it's currently documented as: ``` /** * Possible topic-level error codes: * UnknownTopic (3) * LeaderNotAvail

[GitHub] [kafka] lbradstreet commented on pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

2020-07-16 Thread GitBox
lbradstreet commented on pull request #9008: URL: https://github.com/apache/kafka/pull/9008#issuecomment-659673793 > Updated the benchmarks with @lbradstreet's suggestions. Here are the results for 3 partitions, 10 topics. GC profiles included. > > On this branch: > > ``` >

[GitHub] [kafka] hachikuji commented on pull request #8979: KAFKA-10223; Use NOT_LEADER_OR_FOLLOWER instead of non-retriable REPLICA_NOT_AVAILABLE for consumers

2020-07-16 Thread GitBox
hachikuji commented on pull request #8979: URL: https://github.com/apache/kafka/pull/8979#issuecomment-659676133 I think it would make sense to change `ReplicaNotAvailableException` to extend `InvalidMetadataException`. This

[GitHub] [kafka] hachikuji commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

2020-07-16 Thread GitBox
hachikuji commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r456076927 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AbstractRequestResponse.java ## @@ -16,5 +16,16 @@ */ package org.apache.kafka.co

[GitHub] [kafka] ijuma commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

2020-07-16 Thread GitBox
ijuma commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r456091241 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AbstractRequestResponse.java ## @@ -16,5 +16,16 @@ */ package org.apache.kafka.common

[GitHub] [kafka] hachikuji commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

2020-07-16 Thread GitBox
hachikuji commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r456092037 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AbstractRequestResponse.java ## @@ -16,5 +16,16 @@ */ package org.apache.kafka.co

[GitHub] [kafka] ableegoldman commented on a change in pull request #9028: KAFKA-10035: Safer conversion of consumer timeout parameters

2020-07-16 Thread GitBox
ableegoldman commented on a change in pull request #9028: URL: https://github.com/apache/kafka/pull/9028#discussion_r456101096 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java ## @@ -265,7 +265,7 @@ public void shouldN

[GitHub] [kafka] vvcephei commented on pull request #9028: KAFKA-10035: Safer conversion of consumer timeout parameters

2020-07-16 Thread GitBox
vvcephei commented on pull request #9028: URL: https://github.com/apache/kafka/pull/9028#issuecomment-659701606 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #9028: KAFKA-10035: Safer conversion of consumer timeout parameters

2020-07-16 Thread GitBox
vvcephei commented on pull request #9028: URL: https://github.com/apache/kafka/pull/9028#issuecomment-659701794 Ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] rondagostino opened a new pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-07-16 Thread GitBox
rondagostino opened a new pull request #9032: URL: https://github.com/apache/kafka/pull/9032 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of test

[jira] [Created] (KAFKA-10281) KIP-640: Add log compression analysis tool

2020-07-16 Thread Chris Beard (Jira)
Chris Beard created KAFKA-10281: --- Summary: KIP-640: Add log compression analysis tool Key: KAFKA-10281 URL: https://issues.apache.org/jira/browse/KAFKA-10281 Project: Kafka Issue Type: Improvem

[GitHub] [kafka] ableegoldman commented on pull request #9024: [DO NOT MERGE (yet)] MINOR: bump Streams integration test log level to DEBUG

2020-07-16 Thread GitBox
ableegoldman commented on pull request #9024: URL: https://github.com/apache/kafka/pull/9024#issuecomment-659747346 Well it looks like we still get too many logs from the brokers even at INFO level. I think we should just demote all broker logs to WARN and just bump it back up to INFO if r

[jira] [Commented] (KAFKA-9841) Connector and Task duplicated when a worker join with old generation assignment

2020-07-16 Thread Viktor Utkin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159570#comment-17159570 ] Viktor Utkin commented on KAFKA-9841: - Hi guys, will fix be back-ported to older vers

[GitHub] [kafka] vutkin commented on pull request #8453: KAFKA-9841: Revoke duplicate connectors and tasks when zombie workers return with an outdated assignment

2020-07-16 Thread GitBox
vutkin commented on pull request #8453: URL: https://github.com/apache/kafka/pull/8453#issuecomment-659747738 Hi guys, will fix be back-ported to older versions of kafka? This is an automated message from the Apache Git Servi

[GitHub] [kafka] ableegoldman commented on a change in pull request #9027: KAFKA-9161: add docs for KIP-441 and KIP-613 and other configs that need fixing

2020-07-16 Thread GitBox
ableegoldman commented on a change in pull request #9027: URL: https://github.com/apache/kafka/pull/9027#discussion_r456147419 ## File path: docs/streams/developer-guide/config-streams.html ## @@ -181,6 +193,7 @@ bootstrap.serverscache.max.bytes.buffering Medium

[jira] [Updated] (KAFKA-10172) [Kafka connect] connectors, tasks metrics doubled

2020-07-16 Thread Viktor Utkin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Utkin updated KAFKA-10172: - Affects Version/s: 2.4.0 > [Kafka connect] connectors, tasks metrics doubled > -

[jira] [Commented] (KAFKA-10172) [Kafka connect] connectors, tasks metrics doubled

2020-07-16 Thread Viktor Utkin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159573#comment-17159573 ] Viktor Utkin commented on KAFKA-10172: -- Looks like there is a bugfix: https://issue

[GitHub] [kafka] ableegoldman commented on a change in pull request #9027: KAFKA-9161: add docs for KIP-441 and KIP-613 and other configs that need fixing

2020-07-16 Thread GitBox
ableegoldman commented on a change in pull request #9027: URL: https://github.com/apache/kafka/pull/9027#discussion_r456148936 ## File path: docs/streams/developer-guide/running-app.html ## @@ -110,6 +110,18 @@ Removing capacity from your applicationIf a local state store exis

[GitHub] [kafka] abbccdda commented on pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-07-16 Thread GitBox
abbccdda commented on pull request #9001: URL: https://github.com/apache/kafka/pull/9001#issuecomment-659752993 retest this This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (KAFKA-10282) Log metrics are removed if a log is deleted and re-created quickly enough

2020-07-16 Thread Bob Barrett (Jira)
Bob Barrett created KAFKA-10282: --- Summary: Log metrics are removed if a log is deleted and re-created quickly enough Key: KAFKA-10282 URL: https://issues.apache.org/jira/browse/KAFKA-10282 Project: Kafk

[jira] [Created] (KAFKA-10283) Consolidate client-level and consumer-level assignment within ClientState

2020-07-16 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-10283: - Summary: Consolidate client-level and consumer-level assignment within ClientState Key: KAFKA-10283 URL: https://issues.apache.org/jira/browse/KAFKA-10283 Project:

[GitHub] [kafka] guozhangwang commented on pull request #9024: [DO NOT MERGE (yet)] MINOR: bump Streams integration test log level to DEBUG

2020-07-16 Thread GitBox
guozhangwang commented on pull request #9024: URL: https://github.com/apache/kafka/pull/9024#issuecomment-659774428 @ableegoldman probably because the too much logs cause some of the operations cannot be completed within the timeout; let's demote brokers to WARN and I will trigger jenkins

[GitHub] [kafka] guozhangwang commented on pull request #8997: MINOR: Improve log4j for per-consumer assignment

2020-07-16 Thread GitBox
guozhangwang commented on pull request #8997: URL: https://github.com/apache/kafka/pull/8997#issuecomment-659775048 @abbccdda updated per your comments. This is an automated message from the Apache Git Service. To respond to

[jira] [Created] (KAFKA-10284) Group membership update due to static member rejoin should be persisted

2020-07-16 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-10284: --- Summary: Group membership update due to static member rejoin should be persisted Key: KAFKA-10284 URL: https://issues.apache.org/jira/browse/KAFKA-10284 Project: Kafka

[GitHub] [kafka] abbccdda commented on pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-07-16 Thread GitBox
abbccdda commented on pull request #9001: URL: https://github.com/apache/kafka/pull/9001#issuecomment-659793027 retest this This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-10205) NullPointerException in StreamTask

2020-07-16 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159615#comment-17159615 ] Matthias J. Sax commented on KAFKA-10205: - [~ableegoldman] Good idea. Not everyb

[jira] [Resolved] (KAFKA-8296) Kafka Streams branch method raises type warnings

2020-07-16 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-8296. Resolution: Duplicate Closing this ticket as duplicate. > Kafka Streams branch method rais

[GitHub] [kafka] abbccdda commented on pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-07-16 Thread GitBox
abbccdda commented on pull request #9001: URL: https://github.com/apache/kafka/pull/9001#issuecomment-659793614 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[jira] [Commented] (KAFKA-10284) Group membership update due to static member rejoin should be persisted

2020-07-16 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159616#comment-17159616 ] Boyang Chen commented on KAFKA-10284: - [https://github.com/apache/kafka/blob/trunk/c

  1   2   >