mimaison commented on a change in pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#discussion_r455671951
##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -1077,7 +1077,7 @@ class ReplicaManager(val config: KafkaConfig,
// Try the read first, this tells us whether we need all of
adjustedFetchSize for this partition
val readInfo: LogReadInfo = partition.readRecords(
fetchOffset = fetchInfo.fetchOffset,
- currentLeaderEpoch = fetchInfo.currentLeaderEpoch,
+ currentLeaderEpoch = toScalaOption(fetchInfo.currentLeaderEpoch),
Review comment:
I think it's ok to keep the Scala Option here.
https://github.com/apache/kafka/pull/9008 can just update the field if it
changes name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
