serjchebotarev commented on a change in pull request #9028:
URL: https://github.com/apache/kafka/pull/9028#discussion_r456067480
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java
##########
@@ -265,7 +265,7 @@ public void
shouldNotAllowToResetWhenIntermediateTopicAbsent() throws Exception
public void testResetWhenLongSessionTimeoutConfiguredWithForceOption()
throws Exception {
Review comment:
Tried on this, partially it went good, but several tests fail under
`ResetIntegrationWithSslTest`, namely:
- `shouldNotAllowToResetWhileStreamsIsRunning`
- `shouldNotAllowToResetWhenInputTopicAbsent`
- `shouldNotAllowToResetWhenIntermediateTopicAbsent`
From output of `shouldNotAllowToResetWhileStreamsIsRunning` there are some
log lines that mention SSL handshake failure:
```
...
[2020-07-16 23:00:20,764] INFO stream-thread
[reset-with-ssl-integration-test-not-reset-during-runtime-6971acc7-e471-4973-a652-5a09b7dce10d-StreamThread-1]
State transition from PARTITIONS_ASSIGNED to RUNNING
(org.apache.kafka.streams.processor.internals.StreamThread:220)
[2020-07-16 23:00:20,766] INFO stream-client
[reset-with-ssl-integration-test-not-reset-during-runtime-6971acc7-e471-4973-a652-5a09b7dce10d]
State transition from REBALANCING to RUNNING
(org.apache.kafka.streams.KafkaStreams:283)
[2020-07-16 23:00:20,771] INFO [SocketServer brokerId=0] Failed
authentication with /127.0.0.1 (SSL handshake failed)
(org.apache.kafka.common.network.Selector:616)
[2020-07-16 23:00:21,067] INFO [Consumer
clientId=reset-with-ssl-integration-test-not-reset-during-runtime-6971acc7-e471-4973-a652-5a09b7dce10d-StreamThread-1-consumer,
groupId=reset-with-ssl-integration-test-not-reset-during-runtime] Found no
committed offset for partition inputTopic-0
(org.apache.kafka.clients.consumer.internals.ConsumerCoordinator:1349)
[2020-07-16 23:00:21,093] INFO [Consumer
clientId=reset-with-ssl-integration-test-not-reset-during-runtime-6971acc7-e471-4973-a652-5a09b7dce10d-StreamThread-1-consumer,
groupId=reset-with-ssl-integration-test-not-reset-during-runtime] Resetting
offset for partition inputTopic-0 to offset 0.
(org.apache.kafka.clients.consumer.internals.SubscriptionState:397)
[2020-07-16 23:00:21,174] INFO [SocketServer brokerId=0] Failed
authentication with /127.0.0.1 (SSL handshake failed)
(org.apache.kafka.common.network.Selector:616)
[2020-07-16 23:00:21,548] INFO [SocketServer brokerId=0] Failed
authentication with /127.0.0.1 (SSL handshake failed)
(org.apache.kafka.common.network.Selector:616)
[2020-07-16 23:00:21,798] INFO [SocketServer brokerId=0] Failed
authentication with /127.0.0.1 (SSL handshake failed)
(org.apache.kafka.common.network.Selector:616)
[2020-07-16 23:00:22,028] INFO [SocketServer brokerId=0] Failed
authentication with /127.0.0.1 (SSL handshake failed)
(org.apache.kafka.common.network.Selector:616)
[2020-07-16 23:00:22,329] INFO [SocketServer brokerId=0] Failed
authentication with /127.0.0.1 (SSL handshake failed)
(org.apache.kafka.common.network.Selector:616)
[2020-07-16 23:00:22,556] INFO [SocketServer brokerId=0] Failed
authentication with /127.0.0.1 (SSL handshake failed)
(org.apache.kafka.common.network.Selector:616)
[2020-07-16 23:00:22,793] INFO [SocketServer brokerId=0] Failed
authentication with /127.0.0.1 (SSL handshake failed)
(org.apache.kafka.common.network.Selector:616)
org.apache.kafka.streams.integration.ResetIntegrationWithSslTest >
shouldNotAllowToResetWhileStreamsIsRunning SKIPPED
> Task :streams:test FAILED
:streams:test (Thread[Execution worker for ':',5,main]) completed. Took
14.586 secs.
FAILURE: Build failed with an exception.
```
Was not able to dig deeper into what could be the reason for this. For now
just left these three tests in the base class without `@Test` annotation and
calling them as before in `ResetIntegrationTest` only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
