ableegoldman commented on a change in pull request #9028:
URL: https://github.com/apache/kafka/pull/9028#discussion_r455916364
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java
##########
@@ -151,7 +151,7 @@ private void prepareConfigs() {
streamsConfig.put(StreamsConfig.COMMIT_INTERVAL_MS_CONFIG, 100);
streamsConfig.put(ConsumerConfig.HEARTBEAT_INTERVAL_MS_CONFIG, 100);
streamsConfig.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, "earliest");
- streamsConfig.put(ConsumerConfig.SESSION_TIMEOUT_MS_CONFIG, "" +
STREAMS_CONSUMER_TIMEOUT);
Review comment:
Hah, this was pretty janky. Good catch
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java
##########
@@ -265,7 +265,7 @@ public void
shouldNotAllowToResetWhenIntermediateTopicAbsent() throws Exception
public void testResetWhenLongSessionTimeoutConfiguredWithForceOption()
throws Exception {
Review comment:
Why are none of these tests...actually tests? Can you also fix this, ie
add `@Test` annotations to all the tests here?
I think you can then simplify the two tests that extend this abstract test
class (`ResetIntegrationTest` and `ResetIntegrationWithSslTest`) and just
remove all the tests that just call `super.testXXX` -- they should
automatically run all of the tests in this class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
