[GitHub] [kafka] satishbellapu edited a comment on pull request #8921: KAFKA-10160: Kafka MM2 consumer configuration

satishbellapu edited a comment on pull request #8921: URL: https://github.com/apache/kafka/pull/8921#issuecomment-648602105 @omkreddy can you review? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] cadonna commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

cadonna commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r446050025 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStoreTest.java ## @@ -124,18 +141,19 @@ public void before() {

[GitHub] [kafka] cadonna commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

cadonna commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r446051842 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStoreTest.java ## @@ -91,13 +103,18 @@ private KeyValueSto

[GitHub] [kafka] cadonna commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

cadonna commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r446050025 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStoreTest.java ## @@ -124,18 +141,19 @@ public void before() {

[GitHub] [kafka] cadonna commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

cadonna commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r446056727 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -103,8 +104,13 @@ public void init(final Proce

[GitHub] [kafka] cadonna commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

cadonna commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r446067346 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractStateManager.java ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apac

[GitHub] [kafka] cadonna commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

cadonna commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r446067346 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractStateManager.java ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apac

[GitHub] [kafka] rajinisivaram commented on pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

rajinisivaram commented on pull request #8683: URL: https://github.com/apache/kafka/pull/8683#issuecomment-650080012 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] cadonna commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

cadonna commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r446080239 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -103,8 +104,13 @@ public void init(final Proce

[GitHub] [kafka] cadonna commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

cadonna commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r446084768 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -103,8 +104,13 @@ public void init(final Proce

[GitHub] [kafka] cadonna commented on a change in pull request #8927: KAFKA-10200: Fix testability of PAPI with windowed stores

cadonna commented on a change in pull request #8927: URL: https://github.com/apache/kafka/pull/8927#discussion_r446087980 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextUtils.java ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apa

[GitHub] [kafka] chia7712 opened a new pull request #8932: MINOR: rename "NOT_INITALIZED" to "NOT_INITIALIZED"

chia7712 opened a new pull request #8932: URL: https://github.com/apache/kafka/pull/8932 The enum ```State``` is private so it is fine to fix typo without breaking compatibility. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [

[GitHub] [kafka] showuon commented on a change in pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon commented on a change in pull request #8712: URL: https://github.com/apache/kafka/pull/8712#discussion_r446126644 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -125,35 +131,37 @@ public InternalTopicMan

[jira] [Commented] (KAFKA-10166) Excessive TaskCorruptedException seen in testing

[ https://issues.apache.org/jira/browse/KAFKA-10166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146243#comment-17146243 ] Bruno Cadonna commented on KAFKA-10166: --- [~ableegoldman] [~rhauch] Good news rega

[GitHub] [kafka] showuon commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-650135514 hi @abbccdda , I've fixed the issue. What I did in the final commit are: 1. Return the `topicsNotReady` to `makeReady` including `tempUnknownTopics`, and not create topic to

[GitHub] [kafka] showuon edited a comment on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon edited a comment on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-650135514 hi @abbccdda , I've fixed the issue. What I did in the final commit are: 0. Revert the unnecessary changes 1. Return the `topicsNotReady` to `makeReady` includi

[GitHub] [kafka] showuon edited a comment on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon edited a comment on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-650135514 hi @abbccdda , I've fixed the issue. What I did in the final commit are: 0. Revert the unnecessary changes 1. Return the `topicsNotReady` to `makeReady` includi

[GitHub] [kafka] showuon edited a comment on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon edited a comment on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-650135514 hi @abbccdda , I've fixed the issue. What I did in the final commit are: 0. Revert the unnecessary changes 1. Return the `topicsNotReady` to `makeReady` includi

[GitHub] [kafka] ijuma commented on pull request #8931: MINOR: Update Scala to 2.13.3

ijuma commented on pull request #8931: URL: https://github.com/apache/kafka/pull/8931#issuecomment-650145706 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] ijuma commented on a change in pull request #8931: MINOR: Update Scala to 2.13.3

ijuma commented on a change in pull request #8931: URL: https://github.com/apache/kafka/pull/8931#discussion_r446145858 ## File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala ## @@ -548,9 +550,9 @@ class AclAuthorizer extends Authorizer with Logging {

[GitHub] [kafka] ijuma commented on a change in pull request #8931: MINOR: Update Scala to 2.13.3

ijuma commented on a change in pull request #8931: URL: https://github.com/apache/kafka/pull/8931#discussion_r446146416 ## File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala ## @@ -367,7 +367,8 @@ class AclAuthorizer extends Authorizer with Logging {

[GitHub] [kafka] ijuma commented on a change in pull request #8931: MINOR: Update Scala to 2.13.3

ijuma commented on a change in pull request #8931: URL: https://github.com/apache/kafka/pull/8931#discussion_r446146741 ## File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala ## @@ -566,6 +568,7 @@ object ConsumerGroupCommand extends Logging { /**

[GitHub] [kafka] ijuma commented on a change in pull request #8931: MINOR: Update Scala to 2.13.3

ijuma commented on a change in pull request #8931: URL: https://github.com/apache/kafka/pull/8931#discussion_r446146643 ## File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala ## @@ -538,6 +539,7 @@ class AclAuthorizer extends Authorizer with Logging {

[GitHub] [kafka] ijuma commented on a change in pull request #8931: MINOR: Update Scala to 2.13.3

ijuma commented on a change in pull request #8931: URL: https://github.com/apache/kafka/pull/8931#discussion_r446147436 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1210,7 +1210,7 @@ object KafkaConfig { .define(PasswordEncoderIterationsProp, I

[GitHub] [kafka] ijuma commented on a change in pull request #8931: MINOR: Update Scala to 2.13.3

ijuma commented on a change in pull request #8931: URL: https://github.com/apache/kafka/pull/8931#discussion_r446147874 ## File path: core/src/main/scala/kafka/zk/KafkaZkClient.scala ## @@ -810,10 +810,8 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient, isS

[jira] [Updated] (KAFKA-9693) Kafka latency spikes caused by log segment flush on roll

[ https://issues.apache.org/jira/browse/KAFKA-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] João Oliveirinha updated KAFKA-9693: Attachment: image-2020-06-26-13-43-21-723.png > Kafka latency spikes caused by log segment

[GitHub] [kafka] dajac opened a new pull request #8933: KAFKA-10163; Throttle Create Topic, Create Partition and Delete Topic Operations (KIP-599, Part I, Broker Changes)

dajac opened a new pull request #8933: URL: https://github.com/apache/kafka/pull/8933 TODO ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgra

[jira] [Updated] (KAFKA-9693) Kafka latency spikes caused by log segment flush on roll

[ https://issues.apache.org/jira/browse/KAFKA-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] João Oliveirinha updated KAFKA-9693: Attachment: image-2020-06-26-13-46-52-861.png > Kafka latency spikes caused by log segment

[GitHub] [kafka] dajac commented on a change in pull request #8933: KAFKA-10163; Throttle Create Topic, Create Partition and Delete Topic Operations (KIP-599, Part I, Broker Changes)

dajac commented on a change in pull request #8933: URL: https://github.com/apache/kafka/pull/8933#discussion_r446168944 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java ## @@ -97,7 +97,25 @@ public static RecordingLevel forName(String name) {

[GitHub] [kafka] dajac commented on a change in pull request #8933: KAFKA-10163; Throttle Create Topic, Create Partition and Delete Topic Operations (KIP-599, Part I, Broker Changes)

dajac commented on a change in pull request #8933: URL: https://github.com/apache/kafka/pull/8933#discussion_r446169809 ## File path: core/src/main/scala/kafka/server/ClientQuotaManager.scala ## @@ -154,32 +180,40 @@ object ClientQuotaManager { * @param config @ClientQuotaMan

[GitHub] [kafka] cadonna commented on pull request #8914: MINOR: Do not swallow exception when collecting PIDs

cadonna commented on pull request #8914: URL: https://github.com/apache/kafka/pull/8914#issuecomment-650167432 I kicked off system tests here: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3987/ This is

[jira] [Commented] (KAFKA-9693) Kafka latency spikes caused by log segment flush on roll

[ https://issues.apache.org/jira/browse/KAFKA-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146280#comment-17146280 ] João Oliveirinha commented on KAFKA-9693: - Hi [~junrao], Thanks for your respons

[jira] [Updated] (KAFKA-9693) Kafka latency spikes caused by log segment flush on roll

[ https://issues.apache.org/jira/browse/KAFKA-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] João Oliveirinha updated KAFKA-9693: Attachment: image-2020-06-26-14-06-01-505.png > Kafka latency spikes caused by log segment

[GitHub] [kafka] dajac commented on a change in pull request #8933: KAFKA-10163; Throttle Create Topic, Create Partition and Delete Topic Operations (KIP-599, Part I, Broker Changes)

dajac commented on a change in pull request #8933: URL: https://github.com/apache/kafka/pull/8933#discussion_r446176850 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1684,25 +1685,29 @@ class KafkaApis(val requestChannel: RequestChannel, } def ha

[GitHub] [kafka] dajac commented on pull request #8933: KAFKA-10163; Throttle Create Topic, Create Partition and Delete Topic Operations (KIP-599, Part I, Broker Changes)

dajac commented on pull request #8933: URL: https://github.com/apache/kafka/pull/8933#issuecomment-650174085 @junrao @rajinisivaram @apovzner Whenever you have time, I would appreciate if you could check this one out. Thanks. ---

[GitHub] [kafka] dajac commented on a change in pull request #8672: KAFKA-10002; Improve performances of StopReplicaRequest with large number of partitions to be deleted

dajac commented on a change in pull request #8672: URL: https://github.com/apache/kafka/pull/8672#discussion_r446190937 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -459,7 +459,12 @@ class Partition(val topicPartition: TopicPartition, } } - d

[GitHub] [kafka] dajac commented on a change in pull request #8672: KAFKA-10002; Improve performances of StopReplicaRequest with large number of partitions to be deleted

dajac commented on a change in pull request #8672: URL: https://github.com/apache/kafka/pull/8672#discussion_r446192217 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -433,29 +425,34 @@ class ReplicaManager(val config: KafkaConfig, case H

[GitHub] [kafka] dajac commented on a change in pull request #8672: KAFKA-10002; Improve performances of StopReplicaRequest with large number of partitions to be deleted

dajac commented on a change in pull request #8672: URL: https://github.com/apache/kafka/pull/8672#discussion_r446192909 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -1018,6 +1097,15 @@ class LogManager(logDirs: Seq[File], byDir } + private def l

[jira] [Created] (KAFKA-10204) When producing a message, Kafka Producer throws OffsetOutOfRangeException when awaiting for delivery report

Kaio Chiarato created KAFKA-10204: - Summary: When producing a message, Kafka Producer throws OffsetOutOfRangeException when awaiting for delivery report Key: KAFKA-10204 URL: https://issues.apache.org/jira/browse/

[GitHub] [kafka] dajac commented on pull request #8672: KAFKA-10002; Improve performances of StopReplicaRequest with large number of partitions to be deleted

dajac commented on pull request #8672: URL: https://github.com/apache/kafka/pull/8672#issuecomment-650191087 @junrao Thanks for your feedback. I just pushed an update which addresses your comments. This is an automated messa

[jira] [Updated] (KAFKA-10204) When producing a message, Kafka Producer throws OffsetOutOfRangeException when awaiting for delivery report

[ https://issues.apache.org/jira/browse/KAFKA-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaio Chiarato updated KAFKA-10204: -- Description: In production environment, we are dealing with this situation in which a produce

[jira] [Updated] (KAFKA-10204) When producing a message, Kafka Producer throws OffsetOutOfRangeException when awaiting for delivery report

[ https://issues.apache.org/jira/browse/KAFKA-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaio Chiarato updated KAFKA-10204: -- Description: In production environment, we are dealing with this situation in which a produce

[GitHub] [kafka] showuon edited a comment on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon edited a comment on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-650135514 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] showuon commented on pull request #8894: KAFKA-9509: increase consume timeout to fix flaky test

showuon commented on pull request #8894: URL: https://github.com/apache/kafka/pull/8894#issuecomment-65020 Hi @kkonstantine , The PR already got 3 approves and the flaky tests affects many PR's tests right now (got mentioned in 3 PRs). I think we can merge it if you don't have other co

[jira] [Created] (KAFKA-10205) NullPointerException in StreamTask (Kafka Streams 2.5.0)

Brian Forkan created KAFKA-10205: Summary: NullPointerException in StreamTask (Kafka Streams 2.5.0) Key: KAFKA-10205 URL: https://issues.apache.org/jira/browse/KAFKA-10205 Project: Kafka Issu

[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-650209463 @mimaison If the one failed test is not relevant, are we ready to merge, or anything I can do? Thanks This i

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146368#comment-17146368 ] Neo Wu commented on KAFKA-10134: we have experienced same issue, one easy way to reprod

[GitHub] [kafka] abbccdda commented on pull request #8928: KAFKA-10192: Wait for REST API to become available before testing blocked connectors

abbccdda commented on pull request #8928: URL: https://github.com/apache/kafka/pull/8928#issuecomment-650224041 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[jira] [Comment Edited] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146368#comment-17146368 ] Neo Wu edited comment on KAFKA-10134 at 6/26/20, 3:12 PM: -- we h

[jira] [Comment Edited] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146368#comment-17146368 ] Neo Wu edited comment on KAFKA-10134 at 6/26/20, 3:14 PM: -- we h

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146391#comment-17146391 ] Neo Wu commented on KAFKA-10134:   {code:java} do { client.maybeTriggerWakeup();

[GitHub] [kafka] mimaison merged pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

mimaison merged pull request #7577: URL: https://github.com/apache/kafka/pull/7577 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Resolved] (KAFKA-9076) MirrorMaker 2.0 automated consumer offset sync

[ https://issues.apache.org/jira/browse/KAFKA-9076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-9076. --- Resolution: Fixed > MirrorMaker 2.0 automated consumer offset sync >

[jira] [Comment Edited] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146391#comment-17146391 ] Neo Wu edited comment on KAFKA-10134 at 6/26/20, 3:18 PM: --   {c

[GitHub] [kafka] junrao commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

junrao commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-650240109 For comparison, 29 test failures in trunk http://testing.confluent.io/confluent-kafka-system-test-results/?prefix=2020-06-25--001.1593132363--apache--trunk--3348fc49d/ ---

[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-650247166 Huge thanks to all reviewers and committers for providing valuable comments and testing results This is an a

[GitHub] [kafka] vvcephei commented on a change in pull request #8927: KAFKA-10200: Fix testability of PAPI with windowed stores

vvcephei commented on a change in pull request #8927: URL: https://github.com/apache/kafka/pull/8927#discussion_r446263112 ## File path: streams/test-utils/src/test/java/org/apache/kafka/streams/test/wordcount/WindowedWordCountProcessorTest.java ## @@ -0,0 +1,144 @@ +/* + * Li

[GitHub] [kafka] vvcephei commented on a change in pull request #8927: KAFKA-10200: Fix testability of PAPI with windowed stores

vvcephei commented on a change in pull request #8927: URL: https://github.com/apache/kafka/pull/8927#discussion_r446263222 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextUtils.java ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] ableegoldman commented on pull request #8926: KAFKA-10166: always write checkpoint before closing an (initialized) task

ableegoldman commented on pull request #8926: URL: https://github.com/apache/kafka/pull/8926#issuecomment-650251400 Seems like all the Topology testDriver tests failed, but I got a green build running locally. Do they not run with `./gradlew streams:test`?

[GitHub] [kafka] guozhangwang commented on pull request #8926: KAFKA-10166: always write checkpoint before closing an (initialized) task

guozhangwang commented on pull request #8926: URL: https://github.com/apache/kafka/pull/8926#issuecomment-650261830 > Seems like all the Topology testDriver tests failed, but I got a green build running locally. Do they not run with `./gradlew streams:test`? They are included in stre

[jira] [Created] (KAFKA-10206) Admin can transiently return incorrect results about topics

Tom Bentley created KAFKA-10206: --- Summary: Admin can transiently return incorrect results about topics Key: KAFKA-10206 URL: https://issues.apache.org/jira/browse/KAFKA-10206 Project: Kafka Is

[jira] [Commented] (KAFKA-10206) Admin can transiently return incorrect results about topics

[ https://issues.apache.org/jira/browse/KAFKA-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146444#comment-17146444 ] Tom Bentley commented on KAFKA-10206: - I think the broker needs some alternative to

[GitHub] [kafka] vvcephei commented on a change in pull request #8905: KAFKA-10173: Fix suppress changelog binary schema compatibility

vvcephei commented on a change in pull request #8905: URL: https://github.com/apache/kafka/pull/8905#discussion_r446265559 ## File path: build.gradle ## @@ -97,7 +97,7 @@ ext { buildVersionFileName = "kafka-version.properties" defaultMaxHeapSize = "2g" - defaultJvmArgs

[GitHub] [kafka] vvcephei commented on pull request #8929: KAFKA-4996: Fix findbugs multithreaded correctness warnings for streams

vvcephei commented on pull request #8929: URL: https://github.com/apache/kafka/pull/8929#issuecomment-650271007 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] vvcephei commented on pull request #8929: KAFKA-4996: Fix findbugs multithreaded correctness warnings for streams

vvcephei commented on pull request #8929: URL: https://github.com/apache/kafka/pull/8929#issuecomment-650270782 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] abbccdda commented on pull request #8914: MINOR: Do not swallow exception when collecting PIDs

abbccdda commented on pull request #8914: URL: https://github.com/apache/kafka/pull/8914#issuecomment-650275130 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] abbccdda commented on pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

abbccdda commented on pull request #8902: URL: https://github.com/apache/kafka/pull/8902#issuecomment-650275504 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] vvcephei commented on pull request #8926: KAFKA-10166: always write checkpoint before closing an (initialized) task

vvcephei commented on pull request #8926: URL: https://github.com/apache/kafka/pull/8926#issuecomment-650288465 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8926: KAFKA-10166: always write checkpoint before closing an (initialized) task

vvcephei commented on pull request #8926: URL: https://github.com/apache/kafka/pull/8926#issuecomment-650288339 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] junrao commented on a change in pull request #8479: KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception

junrao commented on a change in pull request #8479: URL: https://github.com/apache/kafka/pull/8479#discussion_r446306280 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -499,7 +500,16 @@ class Partition(val topicPartition: TopicPartition, addingRe

[GitHub] [kafka] ableegoldman commented on a change in pull request #8929: KAFKA-4996: Fix findbugs multithreaded correctness warnings for streams

ableegoldman commented on a change in pull request #8929: URL: https://github.com/apache/kafka/pull/8929#discussion_r446308395 ## File path: gradle/spotbugs-exclude.xml ## @@ -348,14 +348,11 @@ For a detailed description of spotbugs bug categories, see https://spotbugs.read

[GitHub] [kafka] andrewchoi5 commented on a change in pull request #8479: KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception

andrewchoi5 commented on a change in pull request #8479: URL: https://github.com/apache/kafka/pull/8479#discussion_r446309532 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -499,7 +500,16 @@ class Partition(val topicPartition: TopicPartition, add

[jira] [Commented] (KAFKA-10166) Excessive TaskCorruptedException seen in testing

[ https://issues.apache.org/jira/browse/KAFKA-10166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146501#comment-17146501 ] Sophie Blee-Goldman commented on KAFKA-10166: - Thanks for the detailed analy

[GitHub] [kafka] ijuma merged pull request #8931: MINOR: Update Scala to 2.13.3

ijuma merged pull request #8931: URL: https://github.com/apache/kafka/pull/8931 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #8931: MINOR: Update Scala to 2.13.3

ijuma commented on pull request #8931: URL: https://github.com/apache/kafka/pull/8931#issuecomment-650297987 One job passed, two had a single unrelated test failure. This is an automated message from the Apache Git Service. T

[jira] [Commented] (KAFKA-9693) Kafka latency spikes caused by log segment flush on roll

[ https://issues.apache.org/jira/browse/KAFKA-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146527#comment-17146527 ] Jun Rao commented on KAFKA-9693: [~joliveirinha]: Thanks for the analysis. To trigger the

[GitHub] [kafka] junrao commented on a change in pull request #8479: KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception

junrao commented on a change in pull request #8479: URL: https://github.com/apache/kafka/pull/8479#discussion_r446316668 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -499,7 +500,16 @@ class Partition(val topicPartition: TopicPartition, addingRe

[GitHub] [kafka] ableegoldman commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

ableegoldman commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r446316588 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStoreTest.java ## @@ -124,18 +141,19 @@ public void before

[GitHub] [kafka] andrewchoi5 commented on a change in pull request #8479: KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception

andrewchoi5 commented on a change in pull request #8479: URL: https://github.com/apache/kafka/pull/8479#discussion_r446318540 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -499,7 +500,16 @@ class Partition(val topicPartition: TopicPartition, add

[GitHub] [kafka] omkreddy closed pull request #8932: MINOR: rename "NOT_INITALIZED" to "NOT_INITIALIZED"

omkreddy closed pull request #8932: URL: https://github.com/apache/kafka/pull/8932 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] efeg commented on a change in pull request #8579: KAFKA-9930: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.

efeg commented on a change in pull request #8579: URL: https://github.com/apache/kafka/pull/8579#discussion_r446327952 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -382,6 +382,12 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] ableegoldman commented on pull request #8913: KAFKA-10191 fix flaky StreamsOptimizedTest - call KafkaStreams#cleanU…

ableegoldman commented on pull request #8913: URL: https://github.com/apache/kafka/pull/8913#issuecomment-650316087 The system tests I'm triggering keep failing, but not because of this PR. Not sure what's going on :/ But I'll try again: https://jenkins.confluent.io/job/system-test-

[GitHub] [kafka] ijuma commented on pull request #8579: KAFKA-9930: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.

ijuma commented on pull request #8579: URL: https://github.com/apache/kafka/pull/8579#issuecomment-650319283 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] guozhangwang commented on a change in pull request #8905: KAFKA-10173: Fix suppress changelog binary schema compatibility

guozhangwang commented on a change in pull request #8905: URL: https://github.com/apache/kafka/pull/8905#discussion_r446343541 ## File path: tests/kafkatest/tests/streams/streams_upgrade_test.py ## @@ -189,8 +192,8 @@ def test_upgrade_downgrade_brokers(self, from_version, to_v

[GitHub] [kafka] vvcephei commented on a change in pull request #8905: KAFKA-10173: Fix suppress changelog binary schema compatibility

vvcephei commented on a change in pull request #8905: URL: https://github.com/apache/kafka/pull/8905#discussion_r446363798 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryTimeOrderedKeyValueBuffer.java ## @@ -361,26 +366,20 @@ private void

[GitHub] [kafka] vvcephei commented on a change in pull request #8905: KAFKA-10173: Fix suppress changelog binary schema compatibility

vvcephei commented on a change in pull request #8905: URL: https://github.com/apache/kafka/pull/8905#discussion_r446364196 ## File path: streams/upgrade-system-tests-25/src/test/java/org/apache/kafka/streams/tests/StreamsSmokeTest.java ## @@ -0,0 +1,99 @@ +/* + * Licensed to t

[GitHub] [kafka] vvcephei commented on a change in pull request #8905: KAFKA-10173: Fix suppress changelog binary schema compatibility

vvcephei commented on a change in pull request #8905: URL: https://github.com/apache/kafka/pull/8905#discussion_r446364364 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/TimeOrderedKeyValueBufferChangelogDeserializationHelper.java ## @@ -0,0 +1,11

[GitHub] [kafka] vvcephei commented on a change in pull request #8905: KAFKA-10173: Fix suppress changelog binary schema compatibility

vvcephei commented on a change in pull request #8905: URL: https://github.com/apache/kafka/pull/8905#discussion_r446365992 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryTimeOrderedKeyValueBuffer.java ## @@ -258,34 +263,43 @@ private void

[GitHub] [kafka] guozhangwang commented on pull request #8905: KAFKA-10173: Fix suppress changelog binary schema compatibility

guozhangwang commented on pull request #8905: URL: https://github.com/apache/kafka/pull/8905#issuecomment-650354464 test this This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] vvcephei commented on pull request #8905: KAFKA-10173: Fix suppress changelog binary schema compatibility

vvcephei commented on pull request #8905: URL: https://github.com/apache/kafka/pull/8905#issuecomment-650354756 Hmm. Still saw the OOME in https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3134/ This is an automated mess

[GitHub] [kafka] vvcephei commented on pull request #8905: KAFKA-10173: Fix suppress changelog binary schema compatibility

vvcephei commented on pull request #8905: URL: https://github.com/apache/kafka/pull/8905#issuecomment-650355203 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[jira] [Commented] (KAFKA-9693) Kafka latency spikes caused by log segment flush on roll

[ https://issues.apache.org/jira/browse/KAFKA-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146596#comment-17146596 ] João Oliveirinha commented on KAFKA-9693: - [~junrao] thanks for the analysis and

[jira] [Updated] (KAFKA-10181) AlterConfig/IncrementalAlterConfig should go to controller

[ https://issues.apache.org/jira/browse/KAFKA-10181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-10181: Fix Version/s: 2.7.0 > AlterConfig/IncrementalAlterConfig should go to controller > --

[jira] [Updated] (KAFKA-10181) AlterConfig/IncrementalAlterConfig should go to controller

[ https://issues.apache.org/jira/browse/KAFKA-10181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-10181: Component/s: admin > AlterConfig/IncrementalAlterConfig should go to controller >

[GitHub] [kafka] gharris1727 commented on a change in pull request #8910: KAFKA-10188: Prevent SinkTask::preCommit from being called after SinkTask::stop

gharris1727 commented on a change in pull request #8910: URL: https://github.com/apache/kafka/pull/8910#discussion_r446379953 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -689,6 +692,10 @@ else if (!context.pausedPartit

[GitHub] [kafka] cgetzen commented on pull request #8930: Mirror Maker 2: offset-syncs variable

cgetzen commented on pull request #8930: URL: https://github.com/apache/kafka/pull/8930#issuecomment-650381294 Hi @ryannedolan, wondering if you could spare a little guidance. I created `offset-syncs.topic.override` variable with a default of `null`. What I would have loved to do is

[jira] [Commented] (KAFKA-9509) Fix flaky test MirrorConnectorsIntegrationTest.testReplication

[ https://issues.apache.org/jira/browse/KAFKA-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146612#comment-17146612 ] Leah Thomas commented on KAFKA-9509: Failed again: h3. Stacktrace java.lang.RuntimeE

[GitHub] [kafka] cgetzen edited a comment on pull request #8930: Mirror Maker 2: offset-syncs variable

cgetzen edited a comment on pull request #8930: URL: https://github.com/apache/kafka/pull/8930#issuecomment-650381294 Hi @ryannedolan, wondering if you could spare a little guidance. I created `offset-syncs.topic.override` variable with a default of `null`. What I would have loved to

[GitHub] [kafka] ableegoldman commented on pull request #8926: KAFKA-10166: always write checkpoint before closing an (initialized) task

ableegoldman commented on pull request #8926: URL: https://github.com/apache/kafka/pull/8926#issuecomment-650382721 Java 8 and 14 builds passed, Java 11 build failed with...zero failures? This is an automated message from the

[GitHub] [kafka] lct45 commented on pull request #8929: KAFKA-4996: Fix findbugs multithreaded correctness warnings for streams

lct45 commented on pull request #8929: URL: https://github.com/apache/kafka/pull/8929#issuecomment-650384491 Failed connect tests on JDC 14 org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testReplication org.apache.kafka.connect.integration.BlockingConnectorTest.testB

  1   2   >