[GitHub] [kafka] showuon commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

[GitBox]

showuon commented on pull request #8712:
URL: https://github.com/apache/kafka/pull/8712#issuecomment-650135514


   hi @abbccdda , I've fixed the issue. What I did in the final commit are:
       1. Return the `topicsNotReady` to `makeReady` including 
`tempUnknownTopics`, and not create topic to wait for next retry
       2. Empty `tempUnknownTopics` will be created in each retry, since the 
`topicsNotReady` now includes `tempUnknownTopics` (can check below diagram)
       3. add 2 more tests to total test 3 cases:
         3.1 shouldCreateTopicWhenTopicLeaderNotAvailableAndThenTopicNotFound
         3.2 
shouldCompleteValidateWhenTopicLeaderNotAvailableAndThenDescribeSuccess
         3.3 shouldThrowExceptionWhenKeepsTopicLeaderNotAvailable
   
   Below is the sequence diagram for `makeReady`. Hope it's clear for what I 
did. Thanks.
   <img width="1361" alt="image" 
src="https://user-images.githubusercontent.com/43372967/85853165-a06ac600-b7e4-11ea-888e-ac98dc26cca0.png";>
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org