ijuma commented on a change in pull request #8931:
URL: https://github.com/apache/kafka/pull/8931#discussion_r446147436



##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -1210,7 +1210,7 @@ object KafkaConfig {
       .define(PasswordEncoderIterationsProp, INT, 
Defaults.PasswordEncoderIterations, atLeast(1024), LOW, 
PasswordEncoderIterationsDoc)
   }
 
-  def configNames() = configDef.names().asScala.toList.sorted
+  def configNames: Seq[String] = configDef.names.asScala.toBuffer.sorted

Review comment:
       `toBuffer` is more efficient than `toList` and `sorted` returns a copy 
anyway.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to