[GitHub] [kafka] dajac commented on a change in pull request #8933: KAFKA-10163; Throttle Create Topic, Create Partition and Delete Topic Operations (KIP-599, Part I, Broker Changes)

[GitBox]

dajac commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r446168944



##########
File path: clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java
##########
@@ -97,7 +97,25 @@ public static RecordingLevel forName(String name) {
         public boolean shouldRecord(final int configId) {
             return configId == DEBUG.id || configId == this.id;
         }
+    }
 
+    public enum QuotaEnforcementType {
+        /**
+         * The quota is not enforced.
+         */
+        NONE,
+
+        /**
+         * The quota is enforced before updating the sensor. An update
+         * is rejected if the quota is already exhausted.
+         */
+        STRICT,
+
+        /**
+         * The quota is enforced after updating the sensor. An update
+         * is always accepted even if the quota is already exhausted.
+         */
+        PERMISSIVE

Review comment:
       The various quota enforcement types that can be used with a `Sensor`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org