apoorvmittal10 commented on PR #18710:
URL: https://github.com/apache/kafka/pull/18710#issuecomment-2616796029
> @apoorvmittal10 can you add the Flaky tag to the two tests this PR is
fixing? This will let us evaluate the fix on trunk without affecting builds
Added the tags.
--
This
mumrah commented on PR #18710:
URL: https://github.com/apache/kafka/pull/18710#issuecomment-2616788424
@apoorvmittal10 can you add the Flaky tag to the two tests this PR is
fixing? This will let us evaluate the fix on trunk without affecting builds
--
This is an automated message from the
apoorvmittal10 commented on code in PR #18710:
URL: https://github.com/apache/kafka/pull/18710#discussion_r1931119701
##
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##
@@ -167,6 +167,7 @@ public class SharePartitionManagerTest {
public void setUp()
chia7712 commented on code in PR #18710:
URL: https://github.com/apache/kafka/pull/18710#discussion_r1931106086
##
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##
@@ -167,6 +167,7 @@ public class SharePartitionManagerTest {
public void setUp() {
apoorvmittal10 commented on PR #18710:
URL: https://github.com/apache/kafka/pull/18710#issuecomment-2616631301
@AndrewJSchofield unrelated tests failure. No SharePartitionManager test
failure in last 3 consecutive runs.
--
This is an automated message from the Apache Git Service.
To respo
apoorvmittal10 commented on PR #18710:
URL: https://github.com/apache/kafka/pull/18710#issuecomment-2616367544
Iteration 2 of tests with no SharePartitionManagerTests failure,
re-triggering build for another iteration. Final iteration to validate the
fixes.
--
This is an automated messag
apoorvmittal10 commented on PR #18710:
URL: https://github.com/apache/kafka/pull/18710#issuecomment-2616365468
> Does that mean you want to revert the rest of the PR or do the other
changes still stand? I think you wrote what you meant, it was surprisingly
flaky, you think it might be Yamme
AndrewJSchofield commented on PR #18710:
URL: https://github.com/apache/kafka/pull/18710#issuecomment-2616315874
> > This time it's `SharePartitionManagerTest >
testAcknowledgeIncorrectGroupId`. I think you need to remove all of the uses of
`validateBrokerTopicStatsMetrics`.
>
> This
apoorvmittal10 commented on PR #18710:
URL: https://github.com/apache/kafka/pull/18710#issuecomment-2616009425
Iteration 1 of tests with no SharePartitionManagerTests failure,
re-triggering build for another iteration.
--
This is an automated message from the Apache Git Service.
To respon
apoorvmittal10 commented on PR #18710:
URL: https://github.com/apache/kafka/pull/18710#issuecomment-2615739759
> This time it's `SharePartitionManagerTest >
testAcknowledgeIncorrectGroupId`. I think you need to remove all of the uses of
`validateBrokerTopicStatsMetrics`.
This seems s
AndrewJSchofield commented on PR #18710:
URL: https://github.com/apache/kafka/pull/18710#issuecomment-2614598589
This time it's `SharePartitionManagerTest >
testAcknowledgeIncorrectGroupId`. I think you need to remove all of the uses of
`validateBrokerTopicStatsMetrics`.
--
This is an au
AndrewJSchofield commented on PR #18710:
URL: https://github.com/apache/kafka/pull/18710#issuecomment-2614487695
I notice that `SharePartitionManagerTest >
testReplicaManagerFetchShouldNotProceed` is flaky in the test run for this PR.
Please could you take a look @apoorvmittal10 .
--
Thi
apoorvmittal10 opened a new pull request, #18710:
URL: https://github.com/apache/kafka/pull/18710
The PR fixes the below flaky tests:
- testDelayedInitializationShouldCompleteFetchRequest
- testReplicaManagerFetchShouldProceed
The tests are flaky where additional failed fetc
13 matches
Mail list logo
