chia7712 commented on code in PR #18710:
URL: https://github.com/apache/kafka/pull/18710#discussion_r1931106086
##########
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##########
@@ -167,6 +167,7 @@ public class SharePartitionManagerTest {
public void setUp() {
mockTimer = new SystemTimerReaper("sharePartitionManagerTestReaper",
new SystemTimer("sharePartitionManagerTestTimer"));
+ kafka.utils.TestUtils.clearYammerMetrics();
Review Comment:
we call `brokerTopicStats.close()` in the `teardown` method. However, other
tests still seem to be affected by the metrics. Does this indicate that
`brokerTopicStats.close()` does not effectively clean up all metrics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
