AndrewJSchofield commented on PR #18710: URL: https://github.com/apache/kafka/pull/18710#issuecomment-2616315874
> > This time it's `SharePartitionManagerTest > testAcknowledgeIncorrectGroupId`. I think you need to remove all of the uses of `validateBrokerTopicStatsMetrics`. > > This seems strange and took another look at test `testReplicaManagerFetchShouldNotProceed` which should not have failed either as the future is completed. Rather than checking specific metric I have given another try by invoking clean up of Yammer metrics during setup. Does that mean you want to revert the rest of the PR or do the other changes still stand? I think you wrote what you meant, it was surprisingly flaky, you think it might be Yammer-related, and you've added explicit Yammer clean-up in the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
