apoorvmittal10 commented on PR #18710: URL: https://github.com/apache/kafka/pull/18710#issuecomment-2616365468
> Does that mean you want to revert the rest of the PR or do the other changes still stand? I think you wrote what you meant, it was surprisingly flaky, you think it might be Yammer-related, and you've added explicit Yammer clean-up in the PR. Other chnages still seems fine as the fetch/acknowledge requests where future can be pending because the tests didn't need to validate the completion of future rather other processing, only there I moved the checks to specific ones. Else still the code hold the old all ShareFetch/Acknowledge metrics check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
