chia7712 merged PR #19374:
URL: https://github.com/apache/kafka/pull/19374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2040508190
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -21,7 +21,7 @@ import kafka.coordinator.group.{CoordinatorLoaderImpl,
CoordinatorPartitionWrite
import
chia7712 commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2032806352
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -97,7 +97,7 @@ class SocketServer(
private val memoryPool = if (config.queuedMaxBytes > 0) new
Simpl
Parkerhiphop commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2031577526
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -97,7 +97,7 @@ class SocketServer(
private val memoryPool = if (config.queuedMaxBytes > 0) new
S
Parkerhiphop commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2035827481
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -97,7 +97,7 @@ class SocketServer(
private val memoryPool = if (config.queuedMaxBytes > 0) new
S
Parkerhiphop commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2035827481
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -97,7 +97,7 @@ class SocketServer(
private val memoryPool = if (config.queuedMaxBytes > 0) new
S
chia7712 commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2033634374
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -97,7 +97,7 @@ class SocketServer(
private val memoryPool = if (config.queuedMaxBytes > 0) new
Simpl
Parkerhiphop commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2033404556
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -97,7 +97,7 @@ class SocketServer(
private val memoryPool = if (config.queuedMaxBytes > 0) new
S
Parkerhiphop commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2030194156
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -97,7 +97,7 @@ class SocketServer(
private val memoryPool = if (config.queuedMaxBytes > 0) new
S
Parkerhiphop commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2031577526
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -97,7 +97,7 @@ class SocketServer(
private val memoryPool = if (config.queuedMaxBytes > 0) new
S
Parkerhiphop commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2030194156
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -97,7 +97,7 @@ class SocketServer(
private val memoryPool = if (config.queuedMaxBytes > 0) new
S
Parkerhiphop commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2031557837
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -495,8 +491,7 @@ private[kafka] abstract class Acceptor(val socketServer:
SocketServer,
val sh
m1a2st commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2031136549
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -495,8 +491,7 @@ private[kafka] abstract class Acceptor(val socketServer:
SocketServer,
val shouldRu
Parkerhiphop commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2030194156
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -97,7 +97,7 @@ class SocketServer(
private val memoryPool = if (config.queuedMaxBytes > 0) new
S
chia7712 commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2029852866
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -97,7 +97,7 @@ class SocketServer(
private val memoryPool = if (config.queuedMaxBytes > 0) new
Simpl
chia7712 commented on PR #19374:
URL: https://github.com/apache/kafka/pull/19374#issuecomment-2780689476
> could we also remove DataPlaneAcceptor#ThreadPrefix and
DataPlaneAcceptor#MetricPrefix, because the only implementation of Acceptor is
DataPlaneAcceptor?
`DataPlaneAcceptor#Metr
m1a2st commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2028861881
##
core/src/main/scala/kafka/network/RequestChannel.scala:
##
@@ -349,8 +348,8 @@ class RequestChannel(val queueSize: Int,
private val requestQueue = new ArrayBlock
Parkerhiphop commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2028918289
##
core/src/main/scala/kafka/network/RequestChannel.scala:
##
@@ -349,8 +348,8 @@ class RequestChannel(val queueSize: Int,
private val requestQueue = new Arra
Parkerhiphop opened a new pull request, #19374:
URL: https://github.com/apache/kafka/pull/19374
As described in the JIRA ticket, controlPlaneRequestChannelOpt was removed
from KRaft mode, so there's no need to use the metrics prefix anymore.
This change removes `metricNamePrefix` from
19 matches
Mail list logo
