m1a2st commented on code in PR #19374: URL: https://github.com/apache/kafka/pull/19374#discussion_r2031136549
########## core/src/main/scala/kafka/network/SocketServer.scala: ########## @@ -495,8 +491,7 @@ private[kafka] abstract class Acceptor(val socketServer: SocketServer, val shouldRun = new AtomicBoolean(true) - def metricPrefix(): String - def threadPrefix(): String + def threadPrefix(): String = DataPlaneAcceptor.ThreadPrefix Review Comment: I'm not sure it's a good idea for a parent class to use constants from its child classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
