Parkerhiphop commented on code in PR #19374: URL: https://github.com/apache/kafka/pull/19374#discussion_r2030194156
########## core/src/main/scala/kafka/network/SocketServer.scala: ########## @@ -97,7 +97,7 @@ class SocketServer( private val memoryPool = if (config.queuedMaxBytes > 0) new SimpleMemoryPool(config.queuedMaxBytes, config.socketRequestMaxBytes, false, memoryPoolSensor) else MemoryPool.NONE // data-plane private[network] val dataPlaneAcceptors = new ConcurrentHashMap[EndPoint, DataPlaneAcceptor]() - val dataPlaneRequestChannel = new RequestChannel(maxQueuedRequests, DataPlaneAcceptor.MetricPrefix, time, apiVersionManager.newRequestMetrics) Review Comment: @chia7712 Yes, I've remove the `DataPlaneAcceptor#MetricPrefix`. But I'm not sure the method `DataPlaneAcceptor#threadPrefix` should be replaced by `DataPlaneAcceptor#ThreadPrefix` since the `threadPrefix()` is used within the `Acceptor`. And the Acceptor should not use the constant from its child class `DataPlaneAcceptor`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
