dajac merged PR #19461:
URL: https://github.com/apache/kafka/pull/19461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on code in PR #19461:
URL: https://github.com/apache/kafka/pull/19461#discussion_r2055327871
##
clients/src/main/resources/common/message/OffsetCommitRequest.json:
##
@@ -36,8 +36,11 @@
//
// Version 9 is the first version that can be used with the new cons
lianetm commented on code in PR #19461:
URL: https://github.com/apache/kafka/pull/19461#discussion_r2054800972
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -727,7 +727,7 @@ public NetworkClientDelegate.UnsentRequest
toUns
lianetm commented on code in PR #19461:
URL: https://github.com/apache/kafka/pull/19461#discussion_r2049165848
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##
@@ -1308,6 +1308,75 @@ public void testConsumerGroupOffsetCommi
dajac commented on code in PR #19461:
URL: https://github.com/apache/kafka/pull/19461#discussion_r2047364604
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##
@@ -1308,6 +1308,75 @@ public void testConsumerGroupOffsetCommit(
dajac commented on code in PR #19461:
URL: https://github.com/apache/kafka/pull/19461#discussion_r2047359577
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -271,40 +271,62 @@ class KafkaApis(val requestChannel: RequestChannel,
): CompletableFuture[Unit] = {
v
dajac commented on code in PR #19461:
URL: https://github.com/apache/kafka/pull/19461#discussion_r2047359577
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -271,40 +271,62 @@ class KafkaApis(val requestChannel: RequestChannel,
): CompletableFuture[Unit] = {
v
dajac commented on code in PR #19461:
URL: https://github.com/apache/kafka/pull/19461#discussion_r2047360656
##
clients/src/main/resources/common/message/OffsetCommitResponse.json:
##
@@ -34,7 +34,9 @@
// Version 9 is the first version that can be used with the new consumer
dajac commented on code in PR #19461:
URL: https://github.com/apache/kafka/pull/19461#discussion_r2047358176
##
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java:
##
@@ -45,20 +45,24 @@ public static class Builder extends
AbstractRequest.Builder
dajac commented on code in PR #19461:
URL: https://github.com/apache/kafka/pull/19461#discussion_r2047354258
##
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java:
##
@@ -190,12 +203,85 @@ public Builder merge(
}
dajac commented on code in PR #19461:
URL: https://github.com/apache/kafka/pull/19461#discussion_r2047353585
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -271,40 +271,62 @@ class KafkaApis(val requestChannel: RequestChannel,
): CompletableFuture[Unit] = {
v
lianetm commented on code in PR #19461:
URL: https://github.com/apache/kafka/pull/19461#discussion_r2045463288
##
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java:
##
@@ -45,20 +45,24 @@ public static class Builder extends
AbstractRequest.Builder
FrankYang0529 commented on code in PR #19461:
URL: https://github.com/apache/kafka/pull/19461#discussion_r2044060234
##
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java:
##
@@ -190,12 +203,85 @@ public Builder merge(
}
FrankYang0529 commented on code in PR #19461:
URL: https://github.com/apache/kafka/pull/19461#discussion_r2043976062
##
clients/src/test/java/org/apache/kafka/common/message/MessageTest.java:
##
@@ -409,90 +411,49 @@ public void testOffsetForLeaderEpochVersions() throws
Excepti
dajac opened a new pull request, #19461:
URL: https://github.com/apache/kafka/pull/19461
This patch extends the OffsetCommit API to support topic ids. From version
10 of the API, topic ids must be used. Originally, we wanted to support both
using topic ids and topic names from version 10 bu
15 matches
Mail list logo
