FrankYang0529 commented on code in PR #19461:
URL: https://github.com/apache/kafka/pull/19461#discussion_r2043976062
##########
clients/src/test/java/org/apache/kafka/common/message/MessageTest.java:
##########
@@ -409,90 +411,49 @@ public void testOffsetForLeaderEpochVersions() throws
Exception {
new OffsetForLeaderEpochRequestData().setReplicaId(-2));
}
- @Test
- public void testOffsetCommitRequestVersions() throws Exception {
- String groupId = "groupId";
- String topicName = "topic";
- String metadata = "metadata";
- int partition = 2;
- int offset = 100;
-
- testAllMessageRoundTrips(new OffsetCommitRequestData()
- .setGroupId(groupId)
- .setTopics(Collections.singletonList(
- new OffsetCommitRequestTopic()
- .setName(topicName)
-
.setPartitions(Collections.singletonList(
- new
OffsetCommitRequestPartition()
-
.setPartitionIndex(partition)
-
.setCommittedMetadata(metadata)
-
.setCommittedOffset(offset)
- )))));
-
- Supplier<OffsetCommitRequestData> request =
- () -> new OffsetCommitRequestData()
- .setGroupId(groupId)
- .setMemberId("memberId")
- .setGroupInstanceId("instanceId")
- .setTopics(Collections.singletonList(
- new OffsetCommitRequestTopic()
- .setName(topicName)
- .setPartitions(Collections.singletonList(
- new OffsetCommitRequestPartition()
- .setPartitionIndex(partition)
- .setCommittedLeaderEpoch(10)
- .setCommittedMetadata(metadata)
- .setCommittedOffset(offset)
- ))))
- .setRetentionTimeMs(20);
-
- for (short version : ApiKeys.OFFSET_COMMIT.allVersions()) {
- OffsetCommitRequestData requestData = request.get();
-
- if (version > 4) {
- requestData.setRetentionTimeMs(-1);
- }
-
- if (version < 6) {
-
requestData.topics().get(0).partitions().get(0).setCommittedLeaderEpoch(-1);
- }
-
- if (version < 7) {
- requestData.setGroupInstanceId(null);
- }
-
- if (version >= 2 && version <= 4) {
- testAllMessageRoundTripsBetweenVersions(version, (short) 5,
requestData, requestData);
- } else {
- testAllMessageRoundTripsFromVersion(version, requestData);
- }
- }
+ @ParameterizedTest
+ @ApiKeyVersionsSource(apiKey = ApiKeys.OFFSET_COMMIT)
+ public void testOffsetCommitRequestVersions(short version) throws
Exception {
+ OffsetCommitRequestData request = new OffsetCommitRequestData()
+ .setGroupId("groupId")
+ .setMemberId(version >= 1 ? "memberId" : "")
Review Comment:
Since the minimal valid version for OffsetCommitRequest is 2, version is
always bigger than 1 here. We can simplify it as "memberId".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
