[jira] [Assigned] (KAFKA-19169) Enhance AuthorizerIntegrationTest for share group APIs

2025-04-17 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lan Ding reassigned KAFKA-19169: Assignee: Lan Ding > Enhance AuthorizerIntegrationTest for share group APIs > ---

Re: [PR] KAFKA-19173: Add `Feature` for "streams" group [kafka]

2025-04-17 Thread via GitHub
chia7712 commented on code in PR #19509: URL: https://github.com/apache/kafka/pull/19509#discussion_r2050092192 ## tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java: ## @@ -182,6 +186,7 @@ public void testDowngradeWithReleaseVersion(ClusterInstance cluster) {

Re: [PR] KAFKA-19171: Kafka Streams crashes with UnsupportedOperationException [kafka]

2025-04-17 Thread via GitHub
chia7712 commented on code in PR #19507: URL: https://github.com/apache/kafka/pull/19507#discussion_r2050081760 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -553,7 +553,7 @@ private void handleTasksWithStateUpdater(final Map>

Re: [PR] KAFKA-18854: remove `DynamicConfig` inner class [kafka]

2025-04-17 Thread via GitHub
gongxuanzhang commented on PR #19487: URL: https://github.com/apache/kafka/pull/19487#issuecomment-2814581119 @chia7712 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] KAFKA-19173: Add `Feature` for "streams" group [kafka]

2025-04-17 Thread via GitHub
mjsax opened a new pull request, #19509: URL: https://github.com/apache/kafka/pull/19509 Add new StreamsGroupFeature, disabled by default, and add "streams" as default value to `group.coordinator.rebalance.protocols`. -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-18561: Remove withKip853Rpc and replace it with withRaftProtocol [kafka]

2025-04-17 Thread via GitHub
frankvicky commented on PR #18600: URL: https://github.com/apache/kafka/pull/18600#issuecomment-2814471191 Hi @jsancio Since this patch changes the base logic of the test, it would be painful when conflicts happen. Could you please take a look when you have a free moment? Many

Re: [PR] KAFKA-19042: [5/N] Move PlaintextConsumerCommitTest to client-integration-tests module [kafka]

2025-04-17 Thread via GitHub
m1a2st commented on PR #19389: URL: https://github.com/apache/kafka/pull/19389#issuecomment-2814470803 Thanks for @chia7712 comment, I run this test in my local machine, and It all passed ![image](https://github.com/user-attachments/assets/d238da19-b792-47fb-9cf1-4caa0d6502b2) --

Re: [PR] MINOR: Refactored default resource type based auth [kafka]

2025-04-17 Thread via GitHub
github-actions[bot] commented on PR #18130: URL: https://github.com/apache/kafka/pull/18130#issuecomment-2814462967 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] MINOR: Refactored default resource type based auth [kafka]

2025-04-17 Thread via GitHub
github-actions[bot] closed pull request #18130: MINOR: Refactored default resource type based auth URL: https://github.com/apache/kafka/pull/18130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-19171: Kafka Streams crashes with UnsupportedOperationException [kafka]

2025-04-17 Thread via GitHub
FrankYang0529 commented on code in PR #19507: URL: https://github.com/apache/kafka/pull/19507#discussion_r2049948975 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -553,7 +553,7 @@ private void handleTasksWithStateUpdater(final Map>

Re: [PR] KAFKA-6629: parameterise SegmentedCacheFunctionTest for session key schemas [kafka]

2025-04-17 Thread via GitHub
github-actions[bot] commented on PR #19404: URL: https://github.com/apache/kafka/pull/19404#issuecomment-2814429047 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-04-17 Thread via GitHub
github-actions[bot] commented on PR #19236: URL: https://github.com/apache/kafka/pull/19236#issuecomment-2814429111 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18877: Add an mechanism to find cases where we accessed variables from the wrong thread. [kafka]

2025-04-17 Thread via GitHub
github-actions[bot] commented on PR #19231: URL: https://github.com/apache/kafka/pull/19231#issuecomment-2814429122 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19171: Kafka Streams crashes with UnsupportedOperationException [kafka]

2025-04-17 Thread via GitHub
FrankYang0529 commented on code in PR #19507: URL: https://github.com/apache/kafka/pull/19507#discussion_r2049948975 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -553,7 +553,7 @@ private void handleTasksWithStateUpdater(final Map>

Re: [PR] KAFKA-19159: Removed time based evictions for share sessions [kafka]

2025-04-17 Thread via GitHub
chirag-wadhwa5 commented on code in PR #19500: URL: https://github.com/apache/kafka/pull/19500#discussion_r2049324837 ## server/src/test/java/org/apache/kafka/server/share/session/ShareSessionCacheTest.java: ## @@ -44,75 +43,45 @@ public void setUp() { @Test public v

Re: [PR] MINOR: Cleanup Core Module- Scala Modules (1/n) [kafka]

2025-04-17 Thread via GitHub
sjhajharia commented on PR #19380: URL: https://github.com/apache/kafka/pull/19380#issuecomment-2814390496 Hey @chia7712 As expected, the failures were flakes. They passed on a re-run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-19019: Add support for remote storage fetch for share groups [kafka]

2025-04-17 Thread via GitHub
junrao commented on code in PR #19437: URL: https://github.com/apache/kafka/pull/19437#discussion_r2049498194 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -277,9 +323,15 @@ public boolean tryComplete() { return false; } catch (Exce

[jira] [Created] (KAFKA-19173) Add `Feature` for streams groups

2025-04-17 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-19173: --- Summary: Add `Feature` for streams groups Key: KAFKA-19173 URL: https://issues.apache.org/jira/browse/KAFKA-19173 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-16538; Upgrade kraft version [kafka]

2025-04-17 Thread via GitHub
ahuang98 commented on code in PR #19416: URL: https://github.com/apache/kafka/pull/19416#discussion_r2047787462 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -97,11 +105,16 @@ public FeatureControlManager build() {

Re: [PR] KAFKA-18873: Fixed incorrect error message when exceeds 5 for transactional producers [kafka]

2025-04-17 Thread via GitHub
kirktrue commented on PR #19041: URL: https://github.com/apache/kafka/pull/19041#issuecomment-2814264150 @EsMoX— Sorry for the confusion, but the proposed change isn't technically correct. The contents of the string doesn't change the test in any functional way. It's used verbatim in

Re: [PR] KAFKA-17203: StreamThread leaking producer instances [kafka]

2025-04-17 Thread via GitHub
chia7712 commented on PR #16730: URL: https://github.com/apache/kafka/pull/16730#issuecomment-2813614234 @mjsax thanks for reporting. I will take a look at #19507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[jira] [Commented] (KAFKA-17861) Serialize with ByteBuffer instead of byte[]

2025-04-17 Thread Siddhartha Devineni (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945505#comment-17945505 ] Siddhartha Devineni commented on KAFKA-17861: - KIP stands for Kafka Improvem

Re: [PR] MINOR: Replaced internal KafkaConfig field in TransactionLogConfig [kafka]

2025-04-17 Thread via GitHub
apalan60 commented on PR #19482: URL: https://github.com/apache/kafka/pull/19482#issuecomment-2813994916 I’ve updated the unit test to reflect the internal behavior of ```TransactionLogConfig```: it's now immutable after construction and no longer hold ```AbstractConfig```. The upda

Re: [PR] KAFKA-19171: Kafka Streams crashes with UnsupportedOperationException [kafka]

2025-04-17 Thread via GitHub
mjsax commented on code in PR #19507: URL: https://github.com/apache/kafka/pull/19507#discussion_r2049466915 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -553,7 +553,7 @@ private void handleTasksWithStateUpdater(final Map> pr

Re: [PR] KAFKA-19019: Add support for remote storage fetch for share groups [kafka]

2025-04-17 Thread via GitHub
adixitconfluent commented on code in PR #19437: URL: https://github.com/apache/kafka/pull/19437#discussion_r2049540060 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -277,9 +323,15 @@ public boolean tryComplete() { return false; } ca

Re: [PR] KAFKA-19159: Removed time based evictions for share sessions [kafka]

2025-04-17 Thread via GitHub
chia7712 commented on code in PR #19500: URL: https://github.com/apache/kafka/pull/19500#discussion_r2049474291 ## server/src/main/java/org/apache/kafka/server/share/session/ShareSessionCache.java: ## @@ -122,15 +113,9 @@ public synchronized ShareSession remove(ShareSession ses

Re: [PR] KAFKA-19171: Kafka Streams crashes with UnsupportedOperationException [kafka]

2025-04-17 Thread via GitHub
mjsax commented on code in PR #19507: URL: https://github.com/apache/kafka/pull/19507#discussion_r2049479552 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -553,7 +553,7 @@ private void handleTasksWithStateUpdater(final Map> pr

[jira] [Created] (KAFKA-19172) Handle the evictions metric in ShareSessionCache

2025-04-17 Thread Chirag Wadhwa (Jira)
Chirag Wadhwa created KAFKA-19172: - Summary: Handle the evictions metric in ShareSessionCache Key: KAFKA-19172 URL: https://issues.apache.org/jira/browse/KAFKA-19172 Project: Kafka Issue Type

Re: [PR] KAFKA-19171: Kafka Streams crashes with UnsupportedOperationException [kafka]

2025-04-17 Thread via GitHub
mjsax commented on code in PR #19507: URL: https://github.com/apache/kafka/pull/19507#discussion_r2049471025 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -553,7 +553,7 @@ private void handleTasksWithStateUpdater(final Map> pr

Re: [PR] KAFKA-19171: Kafka Streams crashes with UnsupportedOperationException [kafka]

2025-04-17 Thread via GitHub
mjsax commented on code in PR #19507: URL: https://github.com/apache/kafka/pull/19507#discussion_r2049471025 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -553,7 +553,7 @@ private void handleTasksWithStateUpdater(final Map> pr

Re: [PR] KAFKA-19156: removed group.share.max.groups config and initialized ShareSessionCache with maxEntries set as group.share.max.share.sessions [kafka]

2025-04-17 Thread via GitHub
chia7712 commented on code in PR #19505: URL: https://github.com/apache/kafka/pull/19505#discussion_r2049460553 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/modern/share/ShareGroupConfigTest.java: ## @@ -89,24 +87,6 @@ public void testInvalidConfigs() {

Re: [PR] KAFKA-19156: removed group.share.max.groups config and initialized ShareSessionCache with maxEntries set as group.share.max.share.sessions [kafka]

2025-04-17 Thread via GitHub
apoorvmittal10 commented on code in PR #19505: URL: https://github.com/apache/kafka/pull/19505#discussion_r2049467905 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/modern/share/ShareGroupConfigTest.java: ## @@ -89,24 +87,6 @@ public void testInvalidConfig

Re: [PR] KAFKA-19171: Kafka Streams crashes with UnsupportedOperationException [kafka]

2025-04-17 Thread via GitHub
mjsax commented on code in PR #19507: URL: https://github.com/apache/kafka/pull/19507#discussion_r2049466915 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -553,7 +553,7 @@ private void handleTasksWithStateUpdater(final Map> pr

Re: [PR] MINOR: improve (De)Serializer JavaDocs [kafka]

2025-04-17 Thread via GitHub
mjsax merged PR #19467: URL: https://github.com/apache/kafka/pull/19467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Commented] (KAFKA-17861) Serialize with ByteBuffer instead of byte[]

2025-04-17 Thread Sarah Hennenkamp (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945481#comment-17945481 ] Sarah Hennenkamp commented on KAFKA-17861: -- Hey Siddhartha, Pardon my ignoranc

Re: [PR] KAFKA-19159: Removed time based evictions for share sessions [kafka]

2025-04-17 Thread via GitHub
chirag-wadhwa5 commented on code in PR #19500: URL: https://github.com/apache/kafka/pull/19500#discussion_r2049320462 ## server/src/test/java/org/apache/kafka/server/share/session/ShareSessionCacheTest.java: ## @@ -44,75 +43,45 @@ public void setUp() { @Test public v

Re: [PR] KAFKA-19171: Kafka Streams crashes with UnsupportedOperationException [kafka]

2025-04-17 Thread via GitHub
chia7712 commented on code in PR #19507: URL: https://github.com/apache/kafka/pull/19507#discussion_r2049405193 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -553,7 +553,7 @@ private void handleTasksWithStateUpdater(final Map>

Re: [PR] MINOR: Cleanup Core Module- Scala Modules (1/n) [kafka]

2025-04-17 Thread via GitHub
sjhajharia commented on PR #19380: URL: https://github.com/apache/kafka/pull/19380#issuecomment-2813636325 The test did pass locally and the Java 23 build was green too. Pushing in an empty commit to rerun the worklow. -- This is an automated message from the Apache Git Service. To res

Re: [PR] KAFKA-19054: StreamThread exception handling with SHUTDOWN_APPLICATION may trigger a tight loop with MANY logs [kafka]

2025-04-17 Thread via GitHub
mjsax commented on PR #19394: URL: https://github.com/apache/kafka/pull/19394#issuecomment-2813638908 All good. No worries :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] KAFKA-19080 The constraint on segment.ms is not enforced at topic level [kafka]

2025-04-17 Thread via GitHub
chia7712 commented on code in PR #19371: URL: https://github.com/apache/kafka/pull/19371#discussion_r2049095738 ## core/src/main/scala/kafka/raft/KafkaMetadataLog.scala: ## @@ -583,35 +584,72 @@ object KafkaMetadataLog extends Logging { scheduler: Scheduler, config: Me

Re: [PR] KAFKA-19171: Kafka Streams crashes with UnsupportedOperationException [kafka]

2025-04-17 Thread via GitHub
mjsax commented on PR #19507: URL: https://github.com/apache/kafka/pull/19507#issuecomment-2813580246 Need to be cherry-picked to `4.0` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] KAFKA-19171: Kafka Streams crashes with UnsupportedOperationException [kafka]

2025-04-17 Thread via GitHub
mjsax opened a new pull request, #19507: URL: https://github.com/apache/kafka/pull/19507 This PR fixes a regression bug introduced with KAFKA-17203. We need to pass in mutable collections into `closeTaskClean(...)`. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] KAFKA-17203: StreamThread leaking producer instances [kafka]

2025-04-17 Thread via GitHub
mjsax commented on PR #16730: URL: https://github.com/apache/kafka/pull/16730#issuecomment-2813574020 Just an FYI: this PR introduced a regression bug https://issues.apache.org/jira/browse/KAFKA-19171 -- This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Assigned] (KAFKA-19171) Kafka Streams crashes with UnsupportedOperationException

2025-04-17 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-19171: --- Assignee: Matthias J. Sax > Kafka Streams crashes with UnsupportedOperationExceptio

[jira] [Created] (KAFKA-19171) Kafka Streams crashes with UnsupportedOperationException

2025-04-17 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-19171: --- Summary: Kafka Streams crashes with UnsupportedOperationException Key: KAFKA-19171 URL: https://issues.apache.org/jira/browse/KAFKA-19171 Project: Kafka

Re: [PR] KAFKA-19159: Removed time based evictions for share sessions [kafka]

2025-04-17 Thread via GitHub
chirag-wadhwa5 commented on code in PR #19500: URL: https://github.com/apache/kafka/pull/19500#discussion_r2049318957 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -428,8 +428,8 @@ class BrokerServer( val fetchManager = new FetchManager(Time.SYSTEM, new F

Re: [PR] KAFKA-19159: Removed time based evictions for share sessions [kafka]

2025-04-17 Thread via GitHub
chirag-wadhwa5 commented on code in PR #19500: URL: https://github.com/apache/kafka/pull/19500#discussion_r2049318313 ## server/src/main/java/org/apache/kafka/server/share/session/ShareSessionCache.java: ## @@ -140,43 +125,19 @@ public synchronized void touch(ShareSession sessio

Re: [PR] KAFKA-18854: Move `DynamicConfig User` and `DynamicConfig Client` to server module [kafka]

2025-04-17 Thread via GitHub
chia7712 commented on PR #19487: URL: https://github.com/apache/kafka/pull/19487#issuecomment-2813181621 @gongxuanzhang could you please cleanup `IP`, `group`, and `ClientMetrics`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] KAFKA-19082: [1/4] Add client config for enable2PC and overloaded initProducerId (KIP-939) [kafka]

2025-04-17 Thread via GitHub
rreddy-22 commented on code in PR #19429: URL: https://github.com/apache/kafka/pull/19429#discussion_r2049313174 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -654,6 +657,46 @@ public void initTransactions() { transactionManager.ma

Re: [PR] MINOR: Remove the unused parameter from FetchSession update method [kafka]

2025-04-17 Thread via GitHub
chia7712 merged PR #19414: URL: https://github.com/apache/kafka/pull/19414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18960: The default type of ssh key used by vagrant is disabled … [kafka]

2025-04-17 Thread via GitHub
chia7712 commented on code in PR #19264: URL: https://github.com/apache/kafka/pull/19264#discussion_r2049290900 ## tests/README.md: ## @@ -166,6 +166,7 @@ https://cwiki.apache.org/confluence/display/KAFKA/tutorial+-+set+up+and+run+Kafk $ virtualenv -p python3 venv

[jira] [Assigned] (KAFKA-19170) Migrate MetricsDuringTopicCreationDeletionTest to clients-integration-tests module

2025-04-17 Thread Yunchi Pang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yunchi Pang reassigned KAFKA-19170: --- Assignee: Yunchi Pang (was: Chia-Ping Tsai) > Migrate MetricsDuringTopicCreationDeletionTe

Re: [PR] KAFKA-19156: removed group.share.max.groups config and initialized ShareSessionCache with maxEntries set as group.share.max.share.sessions [kafka]

2025-04-17 Thread via GitHub
apoorvmittal10 commented on code in PR #19505: URL: https://github.com/apache/kafka/pull/19505#discussion_r2049280366 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/share/ShareGroupConfig.java: ## @@ -104,7 +97,7 @@ public class ShareGroupConfig {

Re: [PR] KAFKA-18870 Implement describeDelegationToken for controller [kafka]

2025-04-17 Thread via GitHub
chia7712 commented on PR #19306: URL: https://github.com/apache/kafka/pull/19306#issuecomment-2813470200 @johnny94 could you please fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] MINOR: improve (De)Serializer JavaDocs [kafka]

2025-04-17 Thread via GitHub
kirktrue commented on PR #19467: URL: https://github.com/apache/kafka/pull/19467#issuecomment-2813449041 > > Are the line breaking changes for the @param JavaDoc a new style guideline, or one used in Streams? I haven't seen that elsewhere in the project. > > I don't think there is any

[jira] [Created] (KAFKA-19170) Migrate MetricsDuringTopicCreationDeletionTest to clients-integration-tests module

2025-04-17 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19170: -- Summary: Migrate MetricsDuringTopicCreationDeletionTest to clients-integration-tests module Key: KAFKA-19170 URL: https://issues.apache.org/jira/browse/KAFKA-19170

Re: [PR] MINOR: Remove the unused parameter from FetchSession update method [kafka]

2025-04-17 Thread via GitHub
chia7712 commented on PR #19414: URL: https://github.com/apache/kafka/pull/19414#issuecomment-2813467525 the failed test is traced by https://issues.apache.org/jira/browse/KAFKA-19083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-19160: Improve performance of fetching stable offsets [kafka]

2025-04-17 Thread via GitHub
dajac commented on code in PR #19497: URL: https://github.com/apache/kafka/pull/19497#discussion_r2049135046 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -194,9 +194,16 @@ public OffsetMetadataManager build() { /*

Re: [PR] KAFKA-19042: [5/N] Move PlaintextConsumerCommitTest to client-integration-tests module [kafka]

2025-04-17 Thread via GitHub
chia7712 commented on PR #19389: URL: https://github.com/apache/kafka/pull/19389#issuecomment-2813389804 @m1a2st I loop the test and `testAsyncConsumerAutoCommitIntercept` is flaky. Could you please take a look? -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] KAFKA-17897: Deprecate Admin.listConsumerGroups [kafka]

2025-04-17 Thread via GitHub
AndrewJSchofield commented on PR #19477: URL: https://github.com/apache/kafka/pull/19477#issuecomment-2813376422 @chia7712 I actually discovered a problem with the code running against older brokers. `Admin.listGroups(ListGroupsOptions.forConsumerGroups())` actually implies a higher version

Re: [PR] KAFKA-16538; Upgrade kraft version [kafka]

2025-04-17 Thread via GitHub
jsancio commented on code in PR #19416: URL: https://github.com/apache/kafka/pull/19416#discussion_r2049226287 ## raft/src/main/java/org/apache/kafka/raft/FollowerState.java: ## @@ -38,19 +40,20 @@ public class FollowerState implements EpochState { private final Set voters;

Re: [PR] KAFKA-16538; Upgrade kraft version [kafka]

2025-04-17 Thread via GitHub
jsancio commented on code in PR #19416: URL: https://github.com/apache/kafka/pull/19416#discussion_r2049223508 ## raft/src/main/java/org/apache/kafka/raft/FollowerState.java: ## @@ -38,19 +40,20 @@ public class FollowerState implements EpochState { private final Set voters;

Re: [PR] KAFKA-16538; Upgrade kraft version [kafka]

2025-04-17 Thread via GitHub
jsancio commented on code in PR #19416: URL: https://github.com/apache/kafka/pull/19416#discussion_r2049218897 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -225,6 +257,23 @@ private ApiError updateFeature( if (featureName.equal

[PR] MINOR: Correct mismatched comments [kafka]

2025-04-17 Thread via GitHub
yx9o opened a new pull request, #19506: URL: https://github.com/apache/kafka/pull/19506 Correct mismatched comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-19159: Removed time based evictions for share sessions [kafka]

2025-04-17 Thread via GitHub
apoorvmittal10 commented on code in PR #19500: URL: https://github.com/apache/kafka/pull/19500#discussion_r2049196483 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -428,8 +428,8 @@ class BrokerServer( val fetchManager = new FetchManager(Time.SYSTEM, new F

Re: [PR] KAFKA-14690; Add TopicId to OffsetCommit API [kafka]

2025-04-17 Thread via GitHub
lianetm commented on code in PR #19461: URL: https://github.com/apache/kafka/pull/19461#discussion_r2049165848 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -1308,6 +1308,75 @@ public void testConsumerGroupOffsetCommi

Re: [PR] KAFKA-18796-3: Increased the default acquisition lock timeout in SharePartition from 100ms to 2 seconds [kafka]

2025-04-17 Thread via GitHub
apoorvmittal10 commented on PR #19405: URL: https://github.com/apache/kafka/pull/19405#issuecomment-2812752834 @chirag-wadhwa5 Did you get chance to look at this PR, I don't think we are fixing it correctly in this PR hence should we close it? -- This is an automated message from the Apac

Re: [PR] MINOR: Cleanup Core Module- Scala Modules (1/n) [kafka]

2025-04-17 Thread via GitHub
chia7712 commented on PR #19380: URL: https://github.com/apache/kafka/pull/19380#issuecomment-2813150073 @sjhajharia could you please check the failed test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-18796-3: Increased the default acquisition lock timeout in SharePartition from 100ms to 2 seconds [kafka]

2025-04-17 Thread via GitHub
chirag-wadhwa5 commented on PR #19405: URL: https://github.com/apache/kafka/pull/19405#issuecomment-2813020218 Hi @apoorvmittal10, I haven't got a chance to look at it, but I think we can close this PR. I'll go ahead and do that. -- This is an automated message from the Apache Git Servic

[jira] [Resolved] (KAFKA-17897) Deprecate Admin.listConsumerGroups

2025-04-17 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17897. Resolution: Fixed > Deprecate Admin.listConsumerGroups > -

Re: [PR] KAFKA-17897: Deprecate Admin.listConsumerGroups [kafka]

2025-04-17 Thread via GitHub
chia7712 merged PR #19477: URL: https://github.com/apache/kafka/pull/19477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-18332) Fix KafkaRaftClient complexity

2025-04-17 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18332. Fix Version/s: 4.1.0 Resolution: Fixed > Fix KafkaRaftClient complexity > -

Re: [PR] KAFKA-18332: fix ClassDataAbstractionCoupling problem in KafkaRaftClientTest(1/2) [kafka]

2025-04-17 Thread via GitHub
chia7712 merged PR #18926: URL: https://github.com/apache/kafka/pull/18926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-19136) Move metadata-related configs from KRaftConfigs to MetadataLogConfig

2025-04-17 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19136. Fix Version/s: 4.1.0 Resolution: Fixed > Move metadata-related configs from KRaftCo

Re: [PR] KAFKA-19136: Move metadata-related configs from KRaftConfigs to MetadataLogConfig [kafka]

2025-04-17 Thread via GitHub
chia7712 merged PR #19465: URL: https://github.com/apache/kafka/pull/19465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18796-3: Increased the default acquisition lock timeout in SharePartition from 100ms to 2 seconds [kafka]

2025-04-17 Thread via GitHub
chirag-wadhwa5 closed pull request #19405: KAFKA-18796-3: Increased the default acquisition lock timeout in SharePartition from 100ms to 2 seconds URL: https://github.com/apache/kafka/pull/19405 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] KAFKA-19156: removed group.share.max.groups config and initialized ShareSessionCache with maxEntries set as group.share.max.share.sessions [kafka]

2025-04-17 Thread via GitHub
chirag-wadhwa5 opened a new pull request, #19505: URL: https://github.com/apache/kafka/pull/19505 This PR removes the group.share.max.groups config. This config was used to calculate the maximum size of share session cache. But with the new config group.share.max.share.sessions in place wit

Re: [PR] KAFKA-18854: Move `DynamicConfig User` and `DynamicConfig Client` to server module [kafka]

2025-04-17 Thread via GitHub
gongxuanzhang commented on PR #19487: URL: https://github.com/apache/kafka/pull/19487#issuecomment-2812810802 @chia7712 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-17541:[1/2] Improve handling of delivery count [kafka]

2025-04-17 Thread via GitHub
apoorvmittal10 commented on code in PR #19430: URL: https://github.com/apache/kafka/pull/19430#discussion_r2048869119 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1011,6 +1011,8 @@ private Optional releaseAcquiredRecordsForPerOffsetBatch(String membe

Re: [PR] KAFKA-19157: added group.share.max.share.sessions config [kafka]

2025-04-17 Thread via GitHub
AndrewJSchofield merged PR #19503: URL: https://github.com/apache/kafka/pull/19503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Commented] (KAFKA-18871) KRaft migration rollback causes downtime

2025-04-17 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945352#comment-17945352 ] Daniel Urban commented on KAFKA-18871: -- [~showuon] Here is an outline of the test (

Re: [PR] KAFKA-18170: Add scheduled job to snapshot cold share partitions. [kafka]

2025-04-17 Thread via GitHub
AndrewJSchofield commented on PR #19443: URL: https://github.com/apache/kafka/pull/19443#issuecomment-2812208506 When I delete the `__share_group_state` topic I get the following exception information: ``` [2025-04-17 09:41:17,524] INFO [ShareCoordinator id=1] Pruning records in __sha

Re: [PR] KAFKA-17184: Fix the error thrown while accessing the RemoteIndexCache [kafka]

2025-04-17 Thread via GitHub
kamalcph commented on PR #19462: URL: https://github.com/apache/kafka/pull/19462#issuecomment-2812612991 Rebased the PR with trunk. In #19474, while rewriting the tests from scala to Java, some recent updates were not taken. Added those unit test with this PR: 1. testDeleteInvalidIn

[jira] [Commented] (KAFKA-19169) Enhance AuthorizerIntegrationTest for share group APIs

2025-04-17 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945333#comment-17945333 ] Lan Ding commented on KAFKA-19169: -- Hi [~schofielaj] , If this ticket is still open, ma

Re: [PR] KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-04-17 Thread via GitHub
TaiJuWu commented on PR #19286: URL: https://github.com/apache/kafka/pull/19286#issuecomment-2812425250 > Can you rebase on trunk? Update, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-19160: Improve performance of fetching stable offsets [kafka]

2025-04-17 Thread via GitHub
dajac commented on PR #19497: URL: https://github.com/apache/kafka/pull/19497#issuecomment-2812388355 @squah-confluent Thanks for the patch. Could we write a micro benchmark to demonstrate the gain? -- This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Commented] (KAFKA-19166) Release tags are orphaned

2025-04-17 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945272#comment-17945272 ] Mickael Maison commented on KAFKA-19166: It seems to have started when we refact

[PR] KAFKA-19157: added group.share.max.share.sessions config [kafka]

2025-04-17 Thread via GitHub
chirag-wadhwa5 opened a new pull request, #19503: URL: https://github.com/apache/kafka/pull/19503 This PR adds the config group.share.max.share.sessions to ShareGroupConfig Refer: [KAFKA-19157](https://issues.apache.org/jira/browse/KAFKA-19157) -- This is an automated message from t

Re: [PR] KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-04-17 Thread via GitHub
mimaison commented on PR #19286: URL: https://github.com/apache/kafka/pull/19286#issuecomment-2812271635 Can you rebase on trunk? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] MINOR: Supress stdout when checking Log4j 1.x configuration compatibility mode [kafka]

2025-04-17 Thread via GitHub
omkreddy merged PR #19502: URL: https://github.com/apache/kafka/pull/19502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-14523) Move RemoteLogManager to the storage module

2025-04-17 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-14523. Fix Version/s: 4.1.0 Resolution: Fixed > Move RemoteLogManager to the storage modul

Re: [PR] KAFKA-14523: Move kafka.log.remote classes to storage [kafka]

2025-04-17 Thread via GitHub
mimaison merged PR #19474: URL: https://github.com/apache/kafka/pull/19474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18170: Add scheduled job to snapshot cold share partitions. [kafka]

2025-04-17 Thread via GitHub
AndrewJSchofield commented on code in PR #19443: URL: https://github.com/apache/kafka/pull/19443#discussion_r2048505136 ## share-coordinator/src/test/java/org/apache/kafka/coordinator/share/ShareCoordinatorShardTest.java: ## @@ -1357,6 +1358,350 @@ public void testInitializePar

[jira] [Resolved] (KAFKA-19024) Enhance the client behaviour when it tries to exceed the `group.share.max.groups`

2025-04-17 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19024. -- Resolution: Won't Fix The `group.share.max.groups` configuration was removed so this i

[jira] [Reopened] (KAFKA-19024) Enhance the client behaviour when it tries to exceed the `group.share.max.groups`

2025-04-17 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield reopened KAFKA-19024: -- Assignee: Andrew Schofield (was: Lan Ding) Reopened to update the Resolution field.

[jira] [Assigned] (KAFKA-19168) MirrorMaker kafka_metrics_count metric is always incorrect

2025-04-17 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jhen-Yung Hsu reassigned KAFKA-19168: - Assignee: Jhen-Yung Hsu > MirrorMaker kafka_metrics_count metric is always incorrect >

Re: [PR] KAFKA-19019: Add support for remote storage fetch for share groups [kafka]

2025-04-17 Thread via GitHub
adixitconfluent commented on code in PR #19437: URL: https://github.com/apache/kafka/pull/19437#discussion_r2048452612 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -277,9 +323,15 @@ public boolean tryComplete() { return false; } ca

[jira] [Commented] (KAFKA-19168) MirrorMaker kafka_metrics_count metric is always incorrect

2025-04-17 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945276#comment-17945276 ] Jhen-Yung Hsu commented on KAFKA-19168: --- I'm working on this, thanks :) > MirrorM

[jira] [Created] (KAFKA-19168) MirrorMaker kafka_metrics_count metric is always incorrect

2025-04-17 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-19168: -- Summary: MirrorMaker kafka_metrics_count metric is always incorrect Key: KAFKA-19168 URL: https://issues.apache.org/jira/browse/KAFKA-19168 Project: Kafka

Re: [PR] KAFKA-17747: Trigger rebalance on rack topology changes [kafka]

2025-04-17 Thread via GitHub
FrankYang0529 commented on code in PR #17444: URL: https://github.com/apache/kafka/pull/17444#discussion_r2048415609 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/ModernGroup.java: ## @@ -348,54 +376,58 @@ public Map targetAssignment() { }

  1   2   >