dajac commented on code in PR #19497:
URL: https://github.com/apache/kafka/pull/19497#discussion_r2049135046


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##########
@@ -194,9 +194,16 @@ public OffsetMetadataManager build() {
 
     /**
      * The open transactions (producer ids) keyed by group.
+     * Tracks whether groups have any open transactions.
      */
     private final TimelineHashMap<String, TimelineHashSet<Long>> 
openTransactionsByGroup;

Review Comment:
   Can we use openTransactionsByGroupTopicAndPartition for this too? If the 
group is present in openTransactionsByGroupTopicAndPartition, it means that it 
has an open transaction.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to