wernerdv commented on code in PR #19387:
URL: https://github.com/apache/kafka/pull/19387#discussion_r2032487977
##
build.gradle:
##
@@ -3737,6 +3737,7 @@ project(':connect:mirror') {
testImplementation project(':core')
testImplementation project(':test-common:test-comm
FrankYang0529 commented on code in PR #19410:
URL: https://github.com/apache/kafka/pull/19410#discussion_r2032444160
##
core/src/main/scala/kafka/server/ControllerMutationQuotaManager.scala:
##
@@ -63,7 +63,7 @@ abstract class AbstractControllerMutationQuota(private val
time: T
senthilm-ms commented on PR #8103:
URL: https://github.com/apache/kafka/pull/8103#issuecomment-2785163121
Got it and I see the interests from many in the community...
I will spend some time by end of April & early May and send the update PR.
Thanks,
Senthil
From: Matth
gongxuanzhang commented on PR #19356:
URL: https://github.com/apache/kafka/pull/19356#issuecomment-2785145813
@chia7712 WDYT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
gongxuanzhang commented on code in PR #19406:
URL: https://github.com/apache/kafka/pull/19406#discussion_r2032322050
##
core/src/main/scala/kafka/server/ControllerApis.scala:
##
@@ -84,7 +85,7 @@ class ControllerApis(
val configHelper = new ConfigHelper(metadataCache, config,
github-actions[bot] commented on PR #19318:
URL: https://github.com/apache/kafka/pull/19318#issuecomment-2785121312
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19321:
URL: https://github.com/apache/kafka/pull/19321#issuecomment-2785121287
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
adixitconfluent commented on code in PR #19261:
URL: https://github.com/apache/kafka/pull/19261#discussion_r2031767657
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java:
##
@@ -2090,6 +2091,307 @@ public void testComplexS
mjsax commented on PR #8103:
URL: https://github.com/apache/kafka/pull/8103#issuecomment-2785005543
Just a question of review capacity I assume -- I think it would still be
valuable to complete this, but somebody must have time to do the work, plus
some committer agree to help reviewing...
mjsax commented on code in PR #19291:
URL: https://github.com/apache/kafka/pull/19291#discussion_r2032232490
##
docs/streams/developer-guide/dsl-api.html:
##
@@ -764,10 +764,10 @@ Manually trigger repartitioning
of the stream with desired number of partitions. (details)
-
[
https://issues.apache.org/jira/browse/KAFKA-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
黃竣陽 reassigned KAFKA-19102:
---
Assignee: 黃竣陽 (was: Chia-Ping Tsai)
> Enhance the docs of group.coordinator.append.linger.ms
> ---
mjsax commented on PR #19314:
URL: https://github.com/apache/kafka/pull/19314#issuecomment-2784956048
This one is still small enough. -- No reason to split it. -- There is no
fixed rule. It always depends always on the ticket, but I usually try to keep
it below 500 LOC -- if larger, there s
[
https://issues.apache.org/jira/browse/KAFKA-16996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-16996:
---
Component/s: consumer
> The leastLoadedNode() function in kafka-client may choose a faulty n
junrao commented on code in PR #19261:
URL: https://github.com/apache/kafka/pull/19261#discussion_r2031937222
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java:
##
@@ -2090,6 +2091,307 @@ public void testComplexShareConsu
AndrewJSchofield opened a new pull request, #19411:
URL: https://github.com/apache/kafka/pull/19411
Some trivial tidying up in GroupMetadataManager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
[
https://issues.apache.org/jira/browse/KAFKA-18962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-18962:
Affects Version/s: 3.8.0
(was: 3.9.0)
> StateRestoreListener on
mjsax commented on code in PR #19188:
URL: https://github.com/apache/kafka/pull/19188#discussion_r2032155035
##
clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java:
##
@@ -294,13 +306,17 @@ public synchronized ConsumerRecords poll(final
Duration timeout) {
[
https://issues.apache.org/jira/browse/KAFKA-16394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16394:
Fix Version/s: (was: 3.9.1)
> ForeignKey LEFT join propagates null value on foreignKey
mimaison commented on code in PR #19406:
URL: https://github.com/apache/kafka/pull/19406#discussion_r2031923532
##
core/src/main/scala/kafka/server/ControllerApis.scala:
##
@@ -84,7 +85,7 @@ class ControllerApis(
val configHelper = new ConfigHelper(metadataCache, config, meta
jsancio commented on code in PR #19296:
URL: https://github.com/apache/kafka/pull/19296#discussion_r2031970291
##
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##
@@ -353,7 +353,7 @@ public ControllerResult
registerBroker(
if (existing
Colin McCabe created KAFKA-19104:
Summary: Support metadata version downgrade in Kafka
Key: KAFKA-19104
URL: https://issues.apache.org/jira/browse/KAFKA-19104
Project: Kafka
Issue Type: Bug
ahuang98 commented on code in PR #19296:
URL: https://github.com/apache/kafka/pull/19296#discussion_r2031718807
##
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##
@@ -353,7 +353,7 @@ public ControllerResult
registerBroker(
if (existing
mimaison commented on PR #19390:
URL: https://github.com/apache/kafka/pull/19390#issuecomment-2784473414
Should these classes go to the `server` module instead? They only seem to be
used by `AclApis`.
--
This is an automated message from the Apache Git Service.
To respond to the message,
adixitconfluent commented on code in PR #19261:
URL: https://github.com/apache/kafka/pull/19261#discussion_r2031778027
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java:
##
@@ -2090,6 +2091,307 @@ public void testComplexS
adixitconfluent commented on code in PR #19261:
URL: https://github.com/apache/kafka/pull/19261#discussion_r2031745262
##
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##
@@ -6671,15 +6693,441 @@ private String assertionFailedMessage(SharePartition
sharePartiti
adixitconfluent commented on code in PR #19261:
URL: https://github.com/apache/kafka/pull/19261#discussion_r2031757437
##
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##
@@ -6671,15 +6693,441 @@ private String assertionFailedMessage(SharePartition
sharePartiti
[
https://issues.apache.org/jira/browse/KAFKA-19103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941677#comment-17941677
]
Bolin Lin commented on KAFKA-19103:
---
Hi [~chia7712], ** I just jumped in—could you pl
Chia-Ping Tsai created KAFKA-19103:
--
Summary: Remove OffsetConfig
Key: KAFKA-19103
URL: https://issues.apache.org/jira/browse/KAFKA-19103
Project: Kafka
Issue Type: Improvement
R
junrao commented on code in PR #19261:
URL: https://github.com/apache/kafka/pull/19261#discussion_r2031538464
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -2488,6 +2509,190 @@ private long startOffsetDuringInitialization(long
partitionDataStartOffset) thr
lorcanj commented on PR #19314:
URL: https://github.com/apache/kafka/pull/19314#issuecomment-2784070246
Hi @mjsax, I noticed you commented on a ticket that I raised which mentioned
not combining too many changes into 1 PR. Could you advise whether it would be
advisable to split this up into
黃竣陽 created KAFKA-19101:
---
Summary: Remove ControllerMutationQuotaManager#throttleTimeMs
unused parameter
Key: KAFKA-19101
URL: https://issues.apache.org/jira/browse/KAFKA-19101
Project: Kafka
Issue Ty
apalan60 commented on PR #19394:
URL: https://github.com/apache/kafka/pull/19394#issuecomment-2783979984
@FrankYang0529
Thanks for your review.
I've added a test. PTAL, Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Parkerhiphop commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2030194156
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -97,7 +97,7 @@ class SocketServer(
private val memoryPool = if (config.queuedMaxBytes > 0) new
S
m1a2st opened a new pull request, #19410:
URL: https://github.com/apache/kafka/pull/19410
It seems `timeMs` this parameter never used in Kafka project, the method
init commit is
https://github.com/apache/kafka/commit/b5f90daf13b4945305951ca0eecdb454a4dcafc2
--
This is an automated messag
[
https://issues.apache.org/jira/browse/KAFKA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-19097:
Component/s: streams
unit tests
> Fix order of arguments to assertEquals
Parkerhiphop commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2031577526
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -97,7 +97,7 @@ class SocketServer(
private val memoryPool = if (config.queuedMaxBytes > 0) new
S
Parkerhiphop commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2030194156
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -97,7 +97,7 @@ class SocketServer(
private val memoryPool = if (config.queuedMaxBytes > 0) new
S
[
https://issues.apache.org/jira/browse/KAFKA-19098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-19098.
Fix Version/s: 4.1.0
Resolution: Fixed
> Remove lastOffset from PartitionResponse
>
mjsax commented on PR #15607:
URL: https://github.com/apache/kafka/pull/15607#issuecomment-2783873590
As discussed via DM on some other channel, I think the original issue of
duplicate tombstones was already fixed via
https://github.com/apache/kafka/pull/19005
I think we should re-pu
Parkerhiphop commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2031557837
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -495,8 +491,7 @@ private[kafka] abstract class Acceptor(val socketServer:
SocketServer,
val sh
AndrewJSchofield merged PR #19372:
URL: https://github.com/apache/kafka/pull/19372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
AndrewJSchofield commented on code in PR #18976:
URL: https://github.com/apache/kafka/pull/18976#discussion_r2031381756
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -1508,6 +1555,110 @@ private
CompletableFuture
dele
dajac commented on code in PR #19409:
URL: https://github.com/apache/kafka/pull/19409#discussion_r2031502146
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -194,16 +193,9 @@ class KafkaConfig private(doLog: Boolean, val props:
util.Map[_, _])
private val _quoru
m1a2st commented on PR #19393:
URL: https://github.com/apache/kafka/pull/19393#issuecomment-2783697038
Hello @kirktrue, if you have free cycle, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
FrankYang0529 opened a new pull request, #19409:
URL: https://github.com/apache/kafka/pull/19409
Since GroupCoordinatorConfig and GroupCoordinatorConfig are not
reconfigurable, they don't need to be integrated in KafkaConfig.
--
This is an automated message from the Apache Git Service.
To
m1a2st commented on PR #19397:
URL: https://github.com/apache/kafka/pull/19397#issuecomment-2783653368
Thanks for this patch, please use `./gradlew spotlessApply` fix build error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
bbejeck commented on code in PR #19407:
URL: https://github.com/apache/kafka/pull/19407#discussion_r2031311815
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -513,6 +513,8 @@ GroupMetadataManager build() {
*/
pri
m1a2st commented on code in PR #19393:
URL: https://github.com/apache/kafka/pull/19393#discussion_r2031149018
##
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##
@@ -1658,7 +1660,8 @@ public Map
beginningOffsets(Collection par
* @see #seekToE
m1a2st commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2031390658
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -3284,7 +3285,7 @@ private boolean maybeUpdateRegularExpressions(
bbejeck commented on PR #19407:
URL: https://github.com/apache/kafka/pull/19407#issuecomment-2783476733
@aliehsaeedii for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
m1a2st commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2031317020
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -3284,7 +3285,7 @@ private boolean maybeUpdateRegularExpressions(
gongxuanzhang opened a new pull request, #19408:
URL: https://github.com/apache/kafka/pull/19408
about
https://github.com/apache/kafka/pull/19226#issuecomment-2783370917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
cadonna commented on code in PR #19275:
URL: https://github.com/apache/kafka/pull/19275#discussion_r2031317747
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java:
##
@@ -99,8 +99,8 @@ SmokeTestDriver.VerificationRe
[
https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-1:
-
Assignee: (was: Kirk True)
> Flaky KafkaConsumerTest testReturnRecordsDuringRebalance
> ---
bbejeck opened a new pull request, #19407:
URL: https://github.com/apache/kafka/pull/19407
This PR updates the StreamGroup heart beat response to only include the
`endpointToPartitions` information after there has been a task assignment
change and all members have successfully migrated to t
gongxuanzhang commented on PR #19226:
URL: https://github.com/apache/kafka/pull/19226#issuecomment-2783399502
@mimaison @chia7712
Thanks for your comments
I will create a MINOR PR to address it
--
This is an automated message from the Apache Git Service.
To respond to the message
gongxuanzhang opened a new pull request, #19406:
URL: https://github.com/apache/kafka/pull/19406
like title
about jira https://issues.apache.org/jira/browse/KAFKA-19100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
chia7712 commented on PR #19226:
URL: https://github.com/apache/kafka/pull/19226#issuecomment-2783375231
@gongxuanzhang WDYT? If you agree @mimaison's comment, could you please
create a MINOR to address it?
--
This is an automated message from the Apache Git Service.
To respond to the me
mimaison commented on PR #19226:
URL: https://github.com/apache/kafka/pull/19226#issuecomment-2783370917
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
[
https://issues.apache.org/jira/browse/KAFKA-19100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xuanzhang gong reassigned KAFKA-19100:
--
Assignee: xuanzhang gong
> Use ProcessRole.toString instead of String in AclApis
> --
黃竣陽 created KAFKA-19100:
---
Summary: Use ProcessRole.toString instead of String in AclApis
Key: KAFKA-19100
URL: https://issues.apache.org/jira/browse/KAFKA-19100
Project: Kafka
Issue Type: Task
lucasbru merged PR #19359:
URL: https://github.com/apache/kafka/pull/19359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chirag-wadhwa5 commented on PR #19405:
URL: https://github.com/apache/kafka/pull/19405#issuecomment-2783292100
Thanks for the review. Answering the questions -
1. The flakiness could not be reproduced locally in the first place, so
there is no proof of that. Honestly reproducing the error
chia7712 commented on PR #19226:
URL: https://github.com/apache/kafka/pull/19226#issuecomment-2783237052
> RemoteLogManager only uses DelayedRemoteListOffsets hence why we put that
in the storage module. But as far as I can tell other purgatory code could be
in server.
`RemoteLogMana
chirag-wadhwa5 opened a new pull request, #19405:
URL: https://github.com/apache/kafka/pull/19405
This PR increases the default acquisition lock timeout in SharePartitionTest
from 100ms to 2 seconds in an attempt to remove flakiness from the respective
tests. The test reports suggest some o
mimaison commented on PR #19226:
URL: https://github.com/apache/kafka/pull/19226#issuecomment-2783221120
`RemoteLogManager` only uses `DelayedRemoteListOffsets` hence why we put
that in the `storage` module. But as far as I can tell other purgatory code
could be in `server`.
--
This is a
m1a2st commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2031136549
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -495,8 +491,7 @@ private[kafka] abstract class Acceptor(val socketServer:
SocketServer,
val shouldRu
m1a2st commented on code in PR #19347:
URL: https://github.com/apache/kafka/pull/19347#discussion_r2031081161
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -38,12 +34,6 @@
import java.util.function.Consumer;
import java.
chia7712 commented on code in PR #19347:
URL: https://github.com/apache/kafka/pull/19347#discussion_r2031094554
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -38,12 +34,6 @@
import java.util.function.Consumer;
import jav
Rancho-7 commented on code in PR #19347:
URL: https://github.com/apache/kafka/pull/19347#discussion_r2031070243
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -66,13 +68,28 @@
import java.util.stream.IntStream;
import java.ut
chia7712 commented on code in PR #19347:
URL: https://github.com/apache/kafka/pull/19347#discussion_r2031064108
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -66,13 +68,28 @@
import java.util.stream.IntStream;
import java.ut
[
https://issues.apache.org/jira/browse/KAFKA-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941543#comment-17941543
]
Nick Guo commented on KAFKA-19099:
--
Hi [~chia7712] ,I would like to take this issue.Tha
[
https://issues.apache.org/jira/browse/KAFKA-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Guo reassigned KAFKA-19099:
Assignee: Nick Guo (was: Chia-Ping Tsai)
> Remove GroupSyncKey, GroupJoinKey, and MemberKey
> --
[
https://issues.apache.org/jira/browse/KAFKA-6629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941541#comment-17941541
]
Lorcan commented on KAFKA-6629:
---
Hi [~guozhang], I've created a PR for this change:
https:
Chia-Ping Tsai created KAFKA-19099:
--
Summary: Remove GroupSyncKey, GroupJoinKey, and MemberKey
Key: KAFKA-19099
URL: https://issues.apache.org/jira/browse/KAFKA-19099
Project: Kafka
Issue Ty
chia7712 commented on PR #19226:
URL: https://github.com/apache/kafka/pull/19226#issuecomment-2783031557
> I was looking at https://github.com/apache/kafka/pull/19390 and wondering
whether we should put these classes in server instead of server-common as they
don't seem to be used elsewhere
FrankYang0529 commented on PR #19262:
URL: https://github.com/apache/kafka/pull/19262#issuecomment-2783020471
Hi @mumrah, do we have chance to merge this PR? In last 28 days, the
QuorumControllerTest#testMinIsrUpdateWithElr has 5% to get flaky result.
Adds configuration for the SessionKeySchema and parameterises the existing
tests
so that both WindowKeys and SessionK
FrankYang0529 commented on PR #19403:
URL: https://github.com/apache/kafka/pull/19403#issuecomment-2783002149
--
This is an automated message from the Apache Git Ser
FrankYang0529 opened a new pull request, #19403:
URL: https://github.com/apache/kafka/pull/19403
It has been around two weeks since fixing
QuorumControllerTest#testUncleanShutdownBrokerElrEnabled PR
https://github.com/apache/kafka/pull/19240 was merged. There is no flaky result
after 2025/
mimaison commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2031012460
##
metadata/src/main/java/org/apache/kafka/metadata/publisher/AclPublisher.java:
##
@@ -103,6 +105,9 @@ public void onMetadataUpdate(MetadataDelta delta,
MetadataImag
cadonna commented on code in PR #19377:
URL: https://github.com/apache/kafka/pull/19377#discussion_r2030990356
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java:
##
@@ -99,8 +115,17 @@ SmokeTestDriver.Verification
[
https://issues.apache.org/jira/browse/KAFKA-18066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uladzislau Blok reassigned KAFKA-18066:
---
Assignee: Uladzislau Blok (was: Peter Lee)
> Misleading/mismatched StreamThread id
[
https://issues.apache.org/jira/browse/KAFKA-18066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941531#comment-17941531
]
Uladzislau Blok commented on KAFKA-18066:
-
Hey [~peterxcli],
Are you still looki
[
https://issues.apache.org/jira/browse/KAFKA-18066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941532#comment-17941532
]
Peter Lee commented on KAFKA-18066:
---
Sure
> Misleading/mismatched StreamThread id in
mimaison commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2030840916
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTestContext.java:
##
@@ -505,8 +506,8 @@ public Builder
withShareGroupAssign
lucasbru commented on code in PR #19359:
URL: https://github.com/apache/kafka/pull/19359#discussion_r2030885666
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/StreamsGroupTest.java:
##
@@ -1106,4 +1106,33 @@ public void testIsSubscribedToTopic() {
showuon commented on PR #19396:
URL: https://github.com/apache/kafka/pull/19396#issuecomment-2782818007
The Jenkins build adds JDK 23 now, and the build completes with 2 flaky
tests: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-19396/2/
@gharris1727 , please help review.
lucasbru commented on code in PR #19359:
URL: https://github.com/apache/kafka/pull/19359#discussion_r2030885033
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -2226,6 +2224,16 @@ private CoordinatorResult stream
lucasbru merged PR #19219:
URL: https://github.com/apache/kafka/pull/19219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
mimaison commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2030844573
##
server/src/test/java/org/apache/kafka/server/MonitorablePluginsIntegrationTest.java:
##
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
mimaison commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2030836809
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java:
##
@@ -250,7 +251,7 @@ public GroupCoordinatorShard build() {
ShivsundarR opened a new pull request, #19402:
URL: https://github.com/apache/kafka/pull/19402
*What*
- `ShareConsumers` may wait on an unneeded `FindCoordinator` during
`close()`(i.e after the acknowledgements are sent).
- This change https://github.com/apache/kafka/pull/18590
AndrewJSchofield merged PR #19369:
URL: https://github.com/apache/kafka/pull/19369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
showuon commented on code in PR #19336:
URL: https://github.com/apache/kafka/pull/19336#discussion_r2030785098
##
docs/ops.html:
##
@@ -4026,13 +4026,14 @@ Broker
Configurations
-By default, Kafka server will not enable tiered storage feature.
remote.log.storage.system.enabl
stanislavkozlovski opened a new pull request, #19401:
URL: https://github.com/apache/kafka/pull/19401
This patch renames the KIP-405 Plugin variable from
`remoteLogStorageManager` to `remoteStorageManager`. After [writing about
it](https://aiven.io/blog/apache-kafka-tiered-storage-in-depth-
bmscomp commented on PR #13627:
URL: https://github.com/apache/kafka/pull/13627#issuecomment-2782438397
@divijvaidya @ijuma Still think this is a better implementation, I think
what do you think about it ? Or should I close this
--
This is an automated message from the Apache Git Servi
ekuvardin commented on PR #18293:
URL: https://github.com/apache/kafka/pull/18293#issuecomment-2782433185
@chia7712 Could you please help and review code?
Next stage after this MR I would like to rewrite some code connecting to ACL
and replace HashSet with prefix set to improve ACL fi
Yunyung commented on PR #19399:
URL: https://github.com/apache/kafka/pull/19399#issuecomment-2782382998
> It looks like `apiVersions` in `RecordAccumulator` can also be cleanup.
Could you include it in this PR? Thanks.
Done. Thanks.
--
This is an automated message from the Apache G
FrankYang0529 commented on code in PR #19364:
URL: https://github.com/apache/kafka/pull/19364#discussion_r2030671804
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1520,6 +1520,10 @@ class KafkaApis(val requestChannel: RequestChannel,
requestHelper.sendErro
1 - 100 of 106 matches
Mail list logo
