m1a2st commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2031317020
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -3284,7 +3285,7 @@ private boolean maybeUpdateRegularExpressions(
* @param log The log instance.
* @param time The time instance.
* @param image The metadata image to use for listing the topics.
- * @param authorizer The authorizer.
+ * @param authorizerPlugin The authorizer.
Review Comment:
How about update to `The authorizer is wrapped in a {@link
org.apache.kafka.common.internals.Plugin}`?
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -3352,15 +3353,15 @@ public static Map<String, ResolvedRegularExpression>
refreshRegularExpressions(
* that the member is authorized to describe.
*
* @param context The request context.
- * @param authorizer The authorizer.
+ * @param authorizerPlugin The authorizer.
Review Comment:
ditto: How about update to `The authorizer is wrapped in a {@link
org.apache.kafka.common.internals.Plugin}`?
##########
server-common/src/main/java/org/apache/kafka/server/network/EndpointReadyFutures.java:
##########
@@ -79,17 +80,17 @@ public Builder addReadinessFutures(
/**
* Build the EndpointReadyFutures object.
*
- * @param authorizer The authorizer to use, if any. Will be started.
- * @param info Server information to be passed to the
authorizer.
+ * @param authorizerPlugin The authorizer to use, if any. Will be
started.
Review Comment:
How about update to `The authorizer which is wrapped in a {@link
org.apache.kafka.common.internals.Plugin} to use`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
